From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 3 Jun 2016 09:50:12 -0400 Subject: [U-Boot] [PATCH] ti_armv7_common: env: Fix hard coded mmc device for uuid In-Reply-To: <6C6B28D4DC342643927BEAFCE8707BF67621BC1C@DBDE04.ent.ti.com> References: <1464871467-22269-1-git-send-email-ravibabu@ti.com> <20160602195412.GX7419@bill-the-cat> <6C6B28D4DC342643927BEAFCE8707BF67621BC1C@DBDE04.ent.ti.com> Message-ID: <20160603135012.GZ7419@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Jun 03, 2016 at 08:05:58AM +0000, B, Ravi wrote: > Hi > > >>> #define DEFAULT_MMC_TI_ARGS \ > >>> "mmcdev=0\0" \ > >>> "mmcrootfstype=ext4 rootwait\0" \ > >>> - "finduuid=part uuid mmc 0:2 uuid\0" \ > >>> + "finduuid=part uuid mmc ${mmcdev}:2 uuid\0" \ > >>> "args_mmc=run finduuid;setenv bootargs console=${console} " \ > >>> "${optargs} " \ > >>> "root=PARTUUID=${uuid} rw " \ > > >>Good, but incomplete find. am33xx doesn't, but other TI families do, "common"-out the bootpart variable and this is what should be used here, after making sure everyone that uses this has a bootpart set. > > >If I understand you correctly, are you saying to use *bootpart* as common variable and define "bootpart=${mmcdev}:2" > >But you cannot define "bootpart=${mmcdev}:2" like this and use ${bootpart} in finduuid. > >"finduuid=part uuid mmc ${bootpart} uuid\0" - this will _NOT_ work. > > >In order to make finduuid work, bootpart must be hard coded with mmcdev:partition as "bootpart=0:2" or "bootpart=1:2". > > >Please correct me if I understood your idea correctly. > > You are right, use of bootpart would be more ideal than use mmcdev. The bootpart will be set based on platform specific boot device:partition. > > diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h > index 7db0881..bbff06b 100644 > --- a/include/configs/ti_armv7_common.h > +++ b/include/configs/ti_armv7_common.h > @@ -59,7 +59,7 @@ > #define DEFAULT_MMC_TI_ARGS \ > "mmcdev=0\0" \ > "mmcrootfstype=ext4 rootwait\0" \ > - "finduuid=part uuid mmc 0:2 uuid\0" \ > + "finduuid=part uuid mmc ${bootpart} uuid\0" \ > "args_mmc=run finduuid;setenv bootargs console=${console} " \ > "${optargs} " \ > "root=PARTUUID=${uuid} rw " \ Right. But not everyone that uses ti_armv7_common.h and DEFAULT_MMC_TI_ARGS has bootpart set I believe. Use buildman to build all of the TI stuff and run 'strings' on u-boot.img to find cases of 'part uuid' but not having bootpart set. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: