All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] webp: allow to enable demux
Date: Fri, 3 Jun 2016 14:45:55 +0200	[thread overview]
Message-ID: <20160603144555.20ed233a@free-electrons.com> (raw)
In-Reply-To: <20160601033811.6031-4-akihiko.odaki.4i@stu.hosei.ac.jp>

Hello,

On Wed,  1 Jun 2016 12:38:11 +0900, Akihiko Odaki wrote:

> +config BR2_PACKAGE_WEBP_DEMUX
> +	bool "webpdemux"
> +	depends on BR2_PACKAGE_WEBP

We normally use a if BR2_PACKAGE_WEBP ... endif block.

> +	help
> +	  "Demux" is a part of WebPMux for extraction and manipulation of an
> +	  extended format WebP file, which can have features like color profile,
> +	  metadata and animation.

Some lines are slightly too long here, they should not be longer than
72 characters.

> +ifeq ($(BR2_PACKAGE_WEBP_DEMUX),y)
> +WEBP_CONF_OPTS += --enable-libwebpdemux
> +endif

And it should be disabled explicitly in an "else" clause.

I've fixed up those minor nits in a follow-up commit (I normally fix up
the original commit, but I pushed it mistakenly).

Thanks for your contribution!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2016-06-03 12:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01  3:38 [Buildroot] [PATCH 1/1] mesa3d: don't remove OpenGL pc when installing Gallium Akihiko Odaki
2016-06-01  3:38 ` [Buildroot] [PATCH 1/1] qt5base: Enable KMS and GBM if Mesa 3D provides EGL Akihiko Odaki
2016-06-01 22:14   ` Akihiko Odaki
2016-06-25 11:33   ` Akihiko Odaki
2016-07-05 10:44   ` Thomas Petazzoni
2016-07-07  7:15   ` Thomas Petazzoni
2016-06-01  3:38 ` [Buildroot] [PATCH 1/1] qt5wayland: new package Akihiko Odaki
2016-06-01 22:14   ` Akihiko Odaki
2016-06-25 11:33   ` Akihiko Odaki
2016-06-27 18:38   ` Peter Seiderer
2016-06-27 20:05     ` Peter Seiderer
2016-06-27 20:10     ` Yann E. MORIN
2016-06-01  3:38 ` [Buildroot] [PATCH 1/1] webp: allow to enable demux Akihiko Odaki
2016-06-01 22:14   ` Akihiko Odaki
2016-06-03 12:45   ` Thomas Petazzoni [this message]
2016-06-01  6:47 ` [Buildroot] [PATCH 1/1] mesa3d: don't remove OpenGL pc when installing Gallium Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160603144555.20ed233a@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.