From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Subject: Re: [PATCH v3] tools/virtio/ringtest: fix run-on-all.sh to work without /dev/cpu Date: Mon, 6 Jun 2016 09:55:59 +0300 Message-ID: <201606060656.u566rhst006487@mx0a-001b2d01.pphosted.com> References: <20160504101454.2b62e974.cornelia.huck@de.ibm.com> <1462356950-3278-1-git-send-email-rppt@linux.vnet.ibm.com> <20160524124133.GC4725@rapoport-lnx> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org To: "Michael S. Tsirkin" Return-path: Content-Disposition: inline In-Reply-To: <20160524124133.GC4725@rapoport-lnx> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: kvm.vger.kernel.org Ping? On Tue, May 24, 2016 at 03:41:33PM +0300, Mike Rapoport wrote: > Michael, > > Any updates on this? > > On Wed, May 04, 2016 at 01:15:50PM +0300, Mike Rapoport wrote: > > /dev/cpu is only available on x86 with certain modules (e.g. msr) enabled. > > Using lscpu to get processors count is more portable. > > > > Signed-off-by: Mike Rapoport > > --- > > v3: simplify by using lscpu -p=cpu > > v2: use lspcu instead of /proc/cpuinfo as per Cornelia's suggestion > > > > tools/virtio/ringtest/run-on-all.sh | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/virtio/ringtest/run-on-all.sh b/tools/virtio/ringtest/run-on-all.sh > > index 52b0f71..2e69ca8 100755 > > --- a/tools/virtio/ringtest/run-on-all.sh > > +++ b/tools/virtio/ringtest/run-on-all.sh > > @@ -3,10 +3,10 @@ > > #use last CPU for host. Why not the first? > > #many devices tend to use cpu0 by default so > > #it tends to be busier > > -HOST_AFFINITY=$(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n|tail -1) > > +HOST_AFFINITY=$(lscpu -p=cpu | tail -1) > > > > #run command on all cpus > > -for cpu in $(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n); > > +for cpu in $(seq 0 $HOST_AFFINITY) > > do > > #Don't run guest and host on same CPU > > #It actually works ok if using signalling > > -- > > 1.9.1 > > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >