From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752768AbcFFUWs (ORCPT ); Mon, 6 Jun 2016 16:22:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37292 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751755AbcFFUWq (ORCPT ); Mon, 6 Jun 2016 16:22:46 -0400 Date: Mon, 6 Jun 2016 13:22:45 -0700 From: Andrew Morton To: Stephen Rothwell Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King Subject: Re: linux-next: build failure after merge of the akpm-current tree Message-Id: <20160606132245.721921fdc49586f236ff3177@linux-foundation.org> In-Reply-To: <20160606140327.09e40ec6@canb.auug.org.au> References: <20160606140327.09e40ec6@canb.auug.org.au> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Jun 2016 14:03:27 +1000 Stephen Rothwell wrote: > In file included from include/linux/crash_dump.h:5:0, > from arch/powerpc/kernel/crash_dump.c:14: > include/linux/kexec.h:358:9: note: previous implicit declaration of 'phys_to_virt' was here > return phys_to_virt(boot_phys_to_phys(entry)); > ^ > > Caused by commit > > 4382eb9055be ("kexec: allow architectures to override boot mapping") > > Architecture seem to define phys_to_virt() in either asm/io.h or > asm/memory.h or asm/virtconvert.h or asm/page*.h ... or asm-generic/io.h. > :-( > > I have reverted that commit for today (and commit c9aaeae038fa ("ARM: > kexec: fix kexec for Keystone 2")). Let's see how this gets along. From: Andrew Morton Subject: kexec-allow-architectures-to-override-boot-mapping-fix kexec.h needs asm/io.h for phys_to_virt() Reported-by: Stephen Rothwell Cc: Russell King Signed-off-by: Andrew Morton --- --- a/include/linux/kexec.h~kexec-allow-architectures-to-override-boot-mapping-fix +++ a/include/linux/kexec.h @@ -14,6 +14,8 @@ #if !defined(__ASSEMBLY__) +#include + #include #ifdef CONFIG_KEXEC_CORE