From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753200AbcFFOkP (ORCPT ); Mon, 6 Jun 2016 10:40:15 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59215 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752202AbcFFOkK (ORCPT ); Mon, 6 Jun 2016 10:40:10 -0400 Date: Mon, 6 Jun 2016 07:40:09 -0700 From: Greg KH To: Mario Limonciello Cc: hayeswang@realtek.com, LKML , Netdev , Linux USB , pali.rohar@gmail.com, anthony.wong@canonical.com Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Message-ID: <20160606144009.GB4758@kroah.com> References: <1465222521-7217-1-git-send-email-mario_limonciello@dell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465222521-7217-1-git-send-email-mario_limonciello@dell.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2016 at 09:15:20AM -0500, Mario Limonciello wrote: > Since this is a Realtek feature, I feel this shouldn't be moved into a platform > MAC address lookup. The code should only be run when the correct Realtek device > is plugged in. > > Changes from v2: > * Only apply to RTL8153-AD w/ eFuse pass through mac address pass thru > bit set. > * Drop matching DMI information on Dell. Although this is implemented on > Dell, this is a Realtek feature that may may be implemented on other > OEMs as well. > * Test that pass through MAC address is valid, fall back to HW address if > invalid. > * Don't track status of which device has MAC pass through activated. > - Expected experience is that if two docks (RTL8153-AD's w/ mac pass thru > bit set) were plugged in both should have MAC pass through activated. cover letters for single-patch submissions is overkill and confusing, please don't.