From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752467AbcFGHOr (ORCPT ); Tue, 7 Jun 2016 03:14:47 -0400 Received: from mga11.intel.com ([192.55.52.93]:36073 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbcFGHOq (ORCPT ); Tue, 7 Jun 2016 03:14:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,432,1459839600"; d="asc'?scan'208";a="982340032" Date: Tue, 7 Jun 2016 12:51:21 +0530 From: Vinod Koul To: Eric Anholt Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Warren , Lee Jones , dmaengine@vger.kernel.org Subject: Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked. Message-ID: <20160607072121.GM16910@localhost> References: <1465007351-5559-1-git-send-email-eric@anholt.net> <20160606042635.GU16910@localhost> <87a8iy6x41.fsf@eliezer.anholt.net> <20160607052405.GC16910@localhost> <87k2i1leap.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="U3BNvdZEnlJXqmh+" Content-Disposition: inline In-Reply-To: <87k2i1leap.fsf@eliezer.anholt.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --U3BNvdZEnlJXqmh+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 06, 2016 at 11:10:38PM -0700, Eric Anholt wrote: > >> >> - if (ret =3D=3D DMA_COMPLETE || !txstate) > >> >> + if (ret =3D=3D DMA_COMPLETE) > >> > > >> > Why do you change this? txstate can be NULL, so no point calculating= reside > >> > for those cases > >>=20 > >> The point was to go into the "Calculate where we're at in our current > >> DMA (if the current DMA is the one we're asking about status for)" pat= h, > >> so that we could note when the DMA is complete even when there's no > >> txstate passed in. > > > > Can you explain what you mean by current DMA! > > > > The claulation is always done for 'descriptor' represnted by the cookie= =2E So > > it doesnt not matter...! >=20 > By current I mean the current descriptor that has been submitted to the > hardware, in bcm2835_chan->desc. As I said, you calculate for the descriptor respresnted by cookie and not the one getting processed! --=20 ~Vinod --U3BNvdZEnlJXqmh+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXVnXxAAoJEHwUBw8lI4NHKZ0P/RbRVSio5t8cxifkQezCkgJV lSuA5JU+BjNMXUxWhz0q9QsxAvgqy3fdEPLlCqes1q+c/LET6L8mdwWxO0lEv6a1 i5dfqf4EJz5QxSB3PcOqIEcwLIZsbCv+5AdCU1NkpXLkg/NZGY+mLr6qm7yLTdAB YD1jpkNNS1o/nBwoOI7ZI2IEcxnnQBOtus0EanbGMmuhsbLf0k2vGP3BQryYmpt8 v6V3uOA1KhLe1CzczQ/oZVk94T/K2brZ0NQBXToTDD5qOFjVtkZSf/RtTFn8g+6f DrUsU8reWwXMJ9ozPh08ABYNFMcTdzQQGmKSlz+FWHYwMH9KLj8bwfqFRtxZ2vbB BWzH8+ExZDHSU8VWvbaMWawarZBNvDwGerNhWmV7j/6SwYjuBW+DWz09FXwvP4hv SZlEkzE3ujwNSVjEZ0UJK2LWWP1FXeqy/SMLZtzdW+vQlMzDczOoYeAfh0GHerpL HwSCTBxrqkn35TJt/IhZlvvQroNHHtSOdIDfeXi7eKfzQQVgyj6+T+KSirMF89Ra Z+Cd/WuiFomO1lSACbQwIDI1Gyfpu08R7maRrDXCxOn3WdhB+PJFpMRjHF8Pi79B i5qEKH/87tq6sHX7ypx68XtnAHtBKzMsp9Htkz+A6uQeRZ15kK8e/O14vWyARMBo Mch7dsjStlQKe2xnx+AS =kPLs -----END PGP SIGNATURE----- --U3BNvdZEnlJXqmh+-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Tue, 7 Jun 2016 12:51:21 +0530 Subject: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked. In-Reply-To: <87k2i1leap.fsf@eliezer.anholt.net> References: <1465007351-5559-1-git-send-email-eric@anholt.net> <20160606042635.GU16910@localhost> <87a8iy6x41.fsf@eliezer.anholt.net> <20160607052405.GC16910@localhost> <87k2i1leap.fsf@eliezer.anholt.net> Message-ID: <20160607072121.GM16910@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jun 06, 2016 at 11:10:38PM -0700, Eric Anholt wrote: > >> >> - if (ret == DMA_COMPLETE || !txstate) > >> >> + if (ret == DMA_COMPLETE) > >> > > >> > Why do you change this? txstate can be NULL, so no point calculating reside > >> > for those cases > >> > >> The point was to go into the "Calculate where we're at in our current > >> DMA (if the current DMA is the one we're asking about status for)" path, > >> so that we could note when the DMA is complete even when there's no > >> txstate passed in. > > > > Can you explain what you mean by current DMA! > > > > The claulation is always done for 'descriptor' represnted by the cookie. So > > it doesnt not matter...! > > By current I mean the current descriptor that has been submitted to the > hardware, in bcm2835_chan->desc. As I said, you calculate for the descriptor respresnted by cookie and not the one getting processed! -- ~Vinod -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: