From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:33250 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753880AbcFGThp (ORCPT ); Tue, 7 Jun 2016 15:37:45 -0400 Received: by mail-wm0-f66.google.com with SMTP id r5so8510811wmr.0 for ; Tue, 07 Jun 2016 12:37:44 -0700 (PDT) Date: Tue, 7 Jun 2016 21:37:39 +0200 From: Daniel Vetter To: Jani Nikula Cc: Lyude Paul , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Daniel Vetter , Daniel Vetter , intel-gfx@lists.freedesktop.org, "open list:INTEL DRM DRIVERS excluding Poulsbo, Moorestow..., linux-kernel@vger.kernel.org open list" , stable@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH v4] drm/i915/ilk: Don't disable SSC source if it's in use Message-ID: <20160607193739.GD3363@phenom.ffwll.local> References: <20160524185924.GI4329@intel.com> <1464199863-9397-1-git-send-email-cpaul@redhat.com> <20160526075456.GM27098@phenom.ffwll.local> <20160606113022.GE4329@intel.com> <1465241361.7166.2.camel@redhat.com> <87ziqx5vn8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87ziqx5vn8.fsf@intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Jun 07, 2016 at 10:02:35AM +0300, Jani Nikula wrote: > On Mon, 06 Jun 2016, Lyude Paul wrote: > > On Mon, 2016-06-06 at 14:30 +0300, Ville Syrj�l� wrote: > >> On Thu, May 26, 2016 at 09:54:56AM +0200, Daniel Vetter wrote: > >> > > >> > Queued for -next, thanks for the patch. > >> Looks like this one broke one of the ILKs in CI. > >> > >> [���13.100979] [drm:ironlake_init_pch_refclk] has_panel 1 has_lvds 1 has_ck505 > >> 0 using_ssc_source 1 > >> [���13.101413] ------------[ cut here ]------------ > >> [���13.101429] kernel BUG at drivers/gpu/drm/i915/intel_display.c:8528! > >> > >> which is the 'BUG_ON(val != final)' at the end of ironlake_init_pch_refclk(). > >> > > Managed to find a machine at the office here that I could reproduce this on and > > figured out the problem with the patch. Unfortunately, the Optiplex 990 that I > > was seeing this issue on already left the office and the person in charge of it > > just went on PTO until the end of the week. For the time being don't merge this > > patch until I can get access to that machine again and make sure the fixed > > version of this patch still works on the 990. I'll send the new version once I'm > > able to test it. > > Daniel already merged it, should we revert? Oops, can do. Or if I have a fixup right away we can merge that, too. Waiting otoh isn't cool. Lyude? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH v4] drm/i915/ilk: Don't disable SSC source if it's in use Date: Tue, 7 Jun 2016 21:37:39 +0200 Message-ID: <20160607193739.GD3363@phenom.ffwll.local> References: <20160524185924.GI4329@intel.com> <1464199863-9397-1-git-send-email-cpaul@redhat.com> <20160526075456.GM27098@phenom.ffwll.local> <20160606113022.GE4329@intel.com> <1465241361.7166.2.camel@redhat.com> <87ziqx5vn8.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <87ziqx5vn8.fsf@intel.com> Sender: stable-owner@vger.kernel.org To: Jani Nikula Cc: Lyude Paul , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Daniel Vetter , Daniel Vetter , intel-gfx@lists.freedesktop.org, "open list:INTEL DRM DRIVERS excluding Poulsbo, Moorestow..., linux-kernel@vger.kernel.org open list" , stable@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Tue, Jun 07, 2016 at 10:02:35AM +0300, Jani Nikula wrote: > On Mon, 06 Jun 2016, Lyude Paul wrote: > > On Mon, 2016-06-06 at 14:30 +0300, Ville Syrj=E4l=E4 wrote: > >> On Thu, May 26, 2016 at 09:54:56AM +0200, Daniel Vetter wrote: > >> >=20 > >> > Queued for -next, thanks for the patch. > >> Looks like this one broke one of the ILKs in CI. > >>=20 > >> [=A0=A0=A013.100979] [drm:ironlake_init_pch_refclk] has_panel 1 ha= s_lvds 1 has_ck505 > >> 0 using_ssc_source 1 > >> [=A0=A0=A013.101413] ------------[ cut here ]------------ > >> [=A0=A0=A013.101429] kernel BUG at drivers/gpu/drm/i915/intel_disp= lay.c:8528! > >>=20 > >> which is the 'BUG_ON(val !=3D final)' at the end of ironlake_init_= pch_refclk(). > >>=20 > > Managed to find a machine at the office here that I could reproduce= this on and > > figured out the problem with the patch. Unfortunately, the Optiplex= 990 that I > > was seeing this issue on already left the office and the person in = charge of it > > just went on PTO until the end of the week. For the time being don'= t merge this > > patch until I can get access to that machine again and make sure th= e fixed > > version of this patch still works on the 990. I'll send the new ver= sion once I'm > > able to test it. >=20 > Daniel already merged it, should we revert? Oops, can do. Or if I have a fixup right away we can merge that, too. Waiting otoh isn't cool. Lyude? -Daniel --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch