From: Jacob Keller <jacob.e.keller@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2 17/18] fm10k: return proper error code when pci_enable_msix_range fails
Date: Tue, 7 Jun 2016 16:09:01 -0700 [thread overview]
Message-ID: <20160607230902.5457-18-jacob.e.keller@intel.com> (raw)
In-Reply-To: <20160607230902.5457-1-jacob.e.keller@intel.com>
The pci_enable_msix_range() function returns a positive value of the
number of allocated vectors if it succeeds. On failure it returns
a negative error code. Return this code properly so that the error
message printed by the driver will show the actual error code instead of
being masked by -ENOMEM.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c
index c85fc98945fa..f72d1cae10ff 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c
@@ -1858,7 +1858,7 @@ static int fm10k_init_msix_capability(struct fm10k_intfc *interface)
if (v_budget < 0) {
kfree(interface->msix_entries);
interface->msix_entries = NULL;
- return -ENOMEM;
+ return v_budget;
}
/* record the number of queues available for q_vectors */
--
2.9.0.rc1.405.g81f467e
next prev parent reply other threads:[~2016-06-07 23:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 23:08 [Intel-wired-lan] [PATCH v2 00/18] fm10k fixes for suspend/resume and related Jacob Keller
2016-06-07 23:08 ` [Intel-wired-lan] [PATCH v2 01/18] fm10k: prevent multiple threads updating statistics Jacob Keller
2016-07-11 19:24 ` Singh, Krishneil K
2016-06-07 23:08 ` [Intel-wired-lan] [PATCH v2 02/18] fm10k: Reset mailbox global interrupts Jacob Keller
2016-06-23 23:19 ` Singh, Krishneil K
2016-06-07 23:08 ` [Intel-wired-lan] [PATCH v2 03/18] fm10k: don't stop reset due to FM10K_ERR_REQUESTS_PENDING Jacob Keller
2016-06-23 23:19 ` Singh, Krishneil K
2016-06-07 23:08 ` [Intel-wired-lan] [PATCH v2 04/18] fm10k: perform data path reset even when switch is not ready Jacob Keller
2016-06-23 23:20 ` Singh, Krishneil K
2016-06-07 23:08 ` [Intel-wired-lan] [PATCH v2 05/18] fm10k: use actual hardware registers when checking for pending Tx Jacob Keller
2016-06-23 23:22 ` Singh, Krishneil K
2016-06-07 23:08 ` [Intel-wired-lan] [PATCH v2 06/18] fm10k: only warn when stop_hw fails with FM10K_ERR_REQUESTS_PENDING Jacob Keller
2016-06-23 23:23 ` Singh, Krishneil K
2016-06-07 23:08 ` [Intel-wired-lan] [PATCH v2 07/18] fm10k: wait for queues to drain if stop_hw() fails once Jacob Keller
2016-06-23 23:24 ` Singh, Krishneil K
2016-06-07 23:08 ` [Intel-wired-lan] [PATCH v2 08/18] fm10k: split fm10k_reinit into two functions Jacob Keller
2016-06-23 23:25 ` Singh, Krishneil K
2016-06-07 23:08 ` [Intel-wired-lan] [PATCH v2 09/18] fm10k: implement prepare_suspend and handle_resume Jacob Keller
2016-06-23 23:25 ` Singh, Krishneil K
2016-06-07 23:08 ` [Intel-wired-lan] [PATCH v2 10/18] fm10k: use common reset flow when handling io errors from PCI stack Jacob Keller
2016-06-23 23:26 ` Singh, Krishneil K
2016-06-07 23:08 ` [Intel-wired-lan] [PATCH v2 11/18] fm10k: implement reset_notify handler for PCIe FLR events Jacob Keller
2016-06-23 23:27 ` Singh, Krishneil K
2016-06-07 23:08 ` [Intel-wired-lan] [PATCH v2 12/18] fm10k: use common flow for suspend and resume Jacob Keller
2016-06-23 23:28 ` Singh, Krishneil K
2016-06-07 23:08 ` [Intel-wired-lan] [PATCH v2 13/18] fm10k: enable bus master after every reset Jacob Keller
2016-06-23 23:29 ` Singh, Krishneil K
2016-06-07 23:08 ` [Intel-wired-lan] [PATCH v2 14/18] fm10k: check if PCIe link is restored Jacob Keller
2016-06-23 23:29 ` Singh, Krishneil K
2016-06-07 23:08 ` [Intel-wired-lan] [PATCH v2 15/18] fm10k: implement request_lport_map pointer Jacob Keller
2016-06-23 23:30 ` Singh, Krishneil K
2016-06-07 23:09 ` [Intel-wired-lan] [PATCH v2 16/18] fm10k: force link to remain down for at least a second on resume events Jacob Keller
2016-06-23 23:31 ` Singh, Krishneil K
2016-06-07 23:09 ` Jacob Keller [this message]
2016-06-23 23:31 ` [Intel-wired-lan] [PATCH v2 17/18] fm10k: return proper error code when pci_enable_msix_range fails Singh, Krishneil K
2016-06-07 23:09 ` [Intel-wired-lan] [PATCH v2 18/18] fm10k: bump version number Jacob Keller
2016-06-14 16:47 ` Singh, Krishneil K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607230902.5457-18-jacob.e.keller@intel.com \
--to=jacob.e.keller@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.