From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 01/62] drm/i915: Only start retire worker when idle Date: Wed, 8 Jun 2016 12:06:02 +0100 Message-ID: <20160608110602.GV32344@nuc-i3427.alporthouse.com> References: <1464971847-15809-1-git-send-email-chris@chris-wilson.co.uk> <1464971847-15809-2-git-send-email-chris@chris-wilson.co.uk> <1465299067.5626.15.camel@linux.intel.com> <20160608105315.GT32344@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id 205EE6E98E for ; Wed, 8 Jun 2016 11:06:05 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160608105315.GT32344@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joonas Lahtinen , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdW4gMDgsIDIwMTYgYXQgMTE6NTM6MTVBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIFR1ZSwgSnVuIDA3LCAyMDE2IGF0IDAyOjMxOjA3UE0gKzAzMDAsIEpvb25hcyBM YWh0aW5lbiB3cm90ZToKPiA+IE9uIHBlLCAyMDE2LTA2LTAzIGF0IDE3OjM2ICswMTAwLCBDaHJp cyBXaWxzb24gd3JvdGU6Cj4gPiA+IMKgaTkxNV9nZW1faWRsZV93b3JrX2hhbmRsZXIoc3RydWN0 IHdvcmtfc3RydWN0ICp3b3JrKQo+ID4gPiDCoHsKPiA+ID4gwqAJc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2ID0KPiA+ID4gLQkJY29udGFpbmVyX29mKHdvcmssIHR5cGVvZigqZGV2 X3ByaXYpLCBtbS5pZGxlX3dvcmsud29yayk7Cj4gPiA+ICsJCWNvbnRhaW5lcl9vZih3b3JrLCB0 eXBlb2YoKmRldl9wcml2KSwgZ3QuaWRsZV93b3JrLndvcmspOwo+ID4gPiDCoAlzdHJ1Y3QgZHJt X2RldmljZSAqZGV2ID0gZGV2X3ByaXYtPmRldjsKPiA+ID4gwqAJc3RydWN0IGludGVsX2VuZ2lu ZV9jcyAqZW5naW5lOwo+ID4gPiDCoAo+ID4gPiAtCWZvcl9lYWNoX2VuZ2luZShlbmdpbmUsIGRl dl9wcml2KQo+ID4gPiAtCQlpZiAoIWxpc3RfZW1wdHkoJmVuZ2luZS0+cmVxdWVzdF9saXN0KSkK PiA+ID4gLQkJCXJldHVybjsKPiA+ID4gKwlpZiAoIVJFQURfT05DRShkZXZfcHJpdi0+Z3QuYXdh a2UpKQo+ID4gPiArCQlyZXR1cm47Cj4gPiA+IMKgCj4gPiA+IC0JLyogd2UgcHJvYmFibHkgc2hv dWxkIHN5bmMgd2l0aCBoYW5nY2hlY2sgaGVyZSwgdXNpbmcgY2FuY2VsX3dvcmtfc3luYy4KPiA+ ID4gLQnCoCogQWxzbyBsb2NraW5nIHNlZW1zIHRvIGJlIGZ1YmFyIGhlcmUsIGVuZ2luZS0+cmVx dWVzdF9saXN0IGlzIHByb3RlY3RlZAo+ID4gPiAtCcKgKiBieSBkZXYtPnN0cnVjdF9tdXRleC4g Ki8KPiA+ID4gKwltdXRleF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gPiA+ICsJaWYgKGRl dl9wcml2LT5ndC5hY3RpdmVfZW5naW5lcykKPiA+ID4gKwkJZ290byBvdXQ7Cj4gPiA+IMKgCj4g PiA+IC0JaW50ZWxfbWFya19pZGxlKGRldl9wcml2KTsKPiA+ID4gKwlmb3JfZWFjaF9lbmdpbmUo ZW5naW5lLCBkZXZfcHJpdikKPiA+ID4gKwkJaTkxNV9nZW1fYmF0Y2hfcG9vbF9maW5pKCZlbmdp bmUtPmJhdGNoX3Bvb2wpOwo+ID4gPiDCoAo+ID4gPiAtCWlmIChtdXRleF90cnlsb2NrKCZkZXYt PnN0cnVjdF9tdXRleCkpIHsKPiA+ID4gLQkJZm9yX2VhY2hfZW5naW5lKGVuZ2luZSwgZGV2X3By aXYpCj4gPiA+IC0JCQlpOTE1X2dlbV9iYXRjaF9wb29sX2ZpbmkoJmVuZ2luZS0+YmF0Y2hfcG9v bCk7Cj4gPiA+ICsJR0VNX0JVR19PTighZGV2X3ByaXYtPmd0LmF3YWtlKTsKPiA+ID4gKwlkZXZf cHJpdi0+Z3QuYXdha2UgPSBmYWxzZTsKPiA+ID4gwqAKPiA+ID4gLQkJbXV0ZXhfdW5sb2NrKCZk ZXYtPnN0cnVjdF9tdXRleCk7Cj4gPiA+ICsJaWYgKElOVEVMX0lORk8oZGV2X3ByaXYpLT5nZW4g Pj0gNikKPiA+ID4gKwkJZ2VuNl9ycHNfaWRsZShkZXZfcHJpdik7Cj4gPiA+ICsJaW50ZWxfcnVu dGltZV9wbV9wdXQoZGV2X3ByaXYpOwo+ID4gPiArb3V0Ogo+ID4gPiArCW11dGV4X3VubG9jaygm ZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ID4gPiArCj4gPiA+ICsJaWYgKCFkZXZfcHJpdi0+Z3QuYXdh a2UgJiYKPiA+IAo+ID4gTm8gUkVBRF9PTkNFIGhlcmUsIGV2ZW4gd2UganVzdCB1bmxvY2tlZCB0 aGUgbXV0ZXguIFNvIGxhY2tzIHNvbWUKPiA+IGNvbnNpc3RlbmN5Lgo+ID4gCj4gPiBBbHNvLCB0 aGlzIGFzc3VtZXMgd2UgbWlnaHQgYmUgcHJlLWVtcHRlZCBiZXR3ZWVuIHVubG9ja2luZyBtdXRl eCBhbmQKPiA+IG1ha2luZyB0aGlzIHRlc3QsIHNvIEknbSBsaXR0bGUgYml0IGNvbmZ1c2VkLiBE byB5b3Ugd2FudCB0byBvcHRpbWl6ZQo+ID4gYnkgYXZvaWRpbmcgY2FsbGluZyBjYW5jZWxfZGVs YXllZF93b3JrX3N5bmM/Cj4gCj4gR2VuZXJhbCBwcmluY2lwbGUgdG8gbmV2ZXIgY2FsbCB3b3Jr X3N5bmMgZnVuY3Rpb25zIHdpdGggbG9ja3MgaGVsZC4gSQo+IGhhZCBhY3R1YWxseSB0aG91Z2h0 IEkgaGFkIGZpeGVkIHRoaXMgdXAgKGJ1dCByZWFsaXplZCB0aGF0IEkganVzdAo+IHJld3JvdGUg aGFuZ2NoZWNrIGxhdGVyIG9uIGluc3RlYWQgOykKPiAKPiBPaywgd2hhdCBJIHRoaW5rIGlzIHNh ZmVyIGhlcmUgaXMKPiAKPiAJYm9vbCBoYW5nY2hlY2sgPSBjYW5jZWxfZGVsYXlfd29ya19zeW5j KGhhbmdjaGVja193b3JrKQo+IAo+IAltdXRleF9sb2NrKCkKPiAJaWYgKGFjdHVhbGx5X2lkbGUo KSkgewo+IAkJYXdha2UgPSBmYWxzZTsKPiAJCW1pc3NlZF9pcnFfcmluZ3MgfD0gaW50ZWxfa2lj a193YWl0ZXJzKCk7Cj4gCX0KPiAJbXV0ZXhfdW5sb2NrKCk7Cj4gCj4gCWlmIChhd2FrZSAmJiBo YW5nY2hlY2spCj4gCQlxdWV1ZV9oYW5nY2hlY2soKQo+IAkKPiBTbyBhbHdheXMga2ljayB0aGUg aGFuZ2NoZWNrIGFuZCByZWVhbmJsZSBpZiB3ZSB0cmllZCB0byBpZGxlIHRvbyBlYXJseS4KPiBU aGlzIHdpbGwgcG90ZW50aWFsbHkgZGVsYXkgaGFuZ2NoZWNrIGJ5IG9uZSBmdWxsIGhhbmdjaGVj ayBwZXJpb2QgaWYgd2UKPiBkbyBlbmNvdW50ZXIgdGhhdCByYWNlLiBCdXQgd2Ugc2hvdWxkbid0 IGJlIGhpdHRpbmcgdGhpcyByYWNlIHRoYXQKPiBvZnRlbiwgb3IgaGFuZ2luZyB0aGUgR1BVIGZv ciB0aGF0IG10ZXJyLgoKQWN0dWFsIGRlbHRhOgoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCmluZGV4 IDQwNjA0NmY2NmUzNi4uODU2ZGE0MDM2ZmIzIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbS5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKQEAg LTMwNjYsMTAgKzMwNjYsMTUgQEAgaTkxNV9nZW1faWRsZV93b3JrX2hhbmRsZXIoc3RydWN0IHdv cmtfc3RydWN0ICp3b3JrKQogICAgICAgICAgICAgICAgY29udGFpbmVyX29mKHdvcmssIHR5cGVv ZigqZGV2X3ByaXYpLCBndC5pZGxlX3dvcmsud29yayk7CiAgICAgICAgc3RydWN0IGRybV9kZXZp Y2UgKmRldiA9IGRldl9wcml2LT5kZXY7CiAgICAgICAgc3RydWN0IGludGVsX2VuZ2luZV9jcyAq ZW5naW5lOworICAgICAgIHVuc2lnbmVkIHN0dWNrX2VuZ2luZXM7CisgICAgICAgYm9vbCByZWFy bV9oYW5nY2hlY2s7CiAKICAgICAgICBpZiAoIVJFQURfT05DRShkZXZfcHJpdi0+Z3QuYXdha2Up KQogICAgICAgICAgICAgICAgcmV0dXJuOwogCisgICAgICAgcmVhcm1faGFuZ2NoZWNrID0KKyAg ICAgICAgICAgICAgIGNhbmNlbF9kZWxheWVkX3dvcmtfc3luYygmZGV2X3ByaXYtPmdwdV9lcnJv ci5oYW5nY2hlY2tfd29yayk7CisKICAgICAgICBtdXRleF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRl eCk7CiAgICAgICAgaWYgKGRldl9wcml2LT5ndC5hY3RpdmVfZW5naW5lcykKICAgICAgICAgICAg ICAgIGdvdG8gb3V0OwpAQCAtMzA3OSw2ICszMDg0LDEzIEBAIGk5MTVfZ2VtX2lkbGVfd29ya19o YW5kbGVyKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKIAogICAgICAgIEdFTV9CVUdfT04oIWRl dl9wcml2LT5ndC5hd2FrZSk7CiAgICAgICAgZGV2X3ByaXYtPmd0LmF3YWtlID0gZmFsc2U7Cisg ICAgICAgcmVhcm1faGFuZ2NoZWNrID0gZmFsc2U7CisKKyAgICAgICBzdHVja19lbmdpbmVzID0g aW50ZWxfa2lja193YWl0ZXJzKGRldl9wcml2KTsKKyAgICAgICBpZiAodW5saWtlbHkoc3R1Y2tf ZW5naW5lcykpIHsKKyAgICAgICAgICAgICAgIERSTV9ERUJVR19EUklWRVIoImtpY2tlZCBzdHVj ayB3YWl0ZXJzLi4ubWlzc2VkIGlycVxuIik7CisgICAgICAgICAgICAgICBkZXZfcHJpdi0+Z3B1 X2Vycm9yLm1pc3NlZF9pcnFfcmluZ3MgfD0gc3R1Y2tfZW5naW5lczsKKyAgICAgICB9CiAKICAg ICAgICBpZiAoSU5URUxfSU5GTyhkZXZfcHJpdiktPmdlbiA+PSA2KQogICAgICAgICAgICAgICAg Z2VuNl9ycHNfaWRsZShkZXZfcHJpdik7CkBAIC0zMDg2LDE0ICszMDk4LDggQEAgaTkxNV9nZW1f aWRsZV93b3JrX2hhbmRsZXIoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQogb3V0OgogICAgICAg IG11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwogCi0gICAgICAgaWYgKCFkZXZfcHJp di0+Z3QuYXdha2UgJiYKLSAgICAgICAgICAgY2FuY2VsX2RlbGF5ZWRfd29ya19zeW5jKCZkZXZf cHJpdi0+Z3B1X2Vycm9yLmhhbmdjaGVja193b3JrKSkgewotICAgICAgICAgICAgICAgdW5zaWdu ZWQgc3R1Y2sgPSBpbnRlbF9raWNrX3dhaXRlcnMoZGV2X3ByaXYpOwotICAgICAgICAgICAgICAg aWYgKHVubGlrZWx5KHN0dWNrKSkgewotICAgICAgICAgICAgICAgICAgICAgICBEUk1fREVCVUdf RFJJVkVSKCJraWNrZWQgc3R1Y2sgd2FpdGVycy4uLm1pc3NlZCBpcnFcbiIpOwotICAgICAgICAg ICAgICAgICAgICAgICBkZXZfcHJpdi0+Z3B1X2Vycm9yLm1pc3NlZF9pcnFfcmluZ3MgfD0gc3R1 Y2s7Ci0gICAgICAgICAgICAgICB9Ci0gICAgICAgfQorICAgICAgIGlmIChyZWFybV9oYW5nY2hl Y2spCisgICAgICAgICAgICAgICBpOTE1X3F1ZXVlX2hhbmdjaGVjayhkZXZfcHJpdik7CiB9Ci1D aHJpcwoKLS0gCkNocmlzIFdpbHNvbiwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50 cmUKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==