From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423273AbcFHTFk (ORCPT ); Wed, 8 Jun 2016 15:05:40 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:46553 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161583AbcFHTFi (ORCPT ); Wed, 8 Jun 2016 15:05:38 -0400 Date: Wed, 8 Jun 2016 13:05:29 -0600 From: Jason Gunthorpe To: Ed Swierk Cc: tpmdd-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH v4 3/4] tpm: Allow TPM chip drivers to override reported command durations Message-ID: <20160608190529.GA26925@obsidianresearch.com> References: <1465346740-60120-1-git-send-email-eswierk@skyportsystems.com> <1465346740-60120-4-git-send-email-eswierk@skyportsystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465346740-60120-4-git-send-email-eswierk@skyportsystems.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2016 at 05:45:39PM -0700, Ed Swierk wrote: > + case 0x32041114: /* Atmel 3204 */ > + chip->vendor.timeout_a = TIS_SHORT_TIMEOUT * HZ / 1000; > + chip->vendor.timeout_b = TIS_LONG_TIMEOUT * HZ / 1000; > + chip->vendor.timeout_c = TIS_SHORT_TIMEOUT * HZ / 1000; > + chip->vendor.timeout_d = TIS_SHORT_TIMEOUT * HZ / 1000; Shouldn't these use msec_to_jiffies? Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v4 3/4] tpm: Allow TPM chip drivers to override reported command durations Date: Wed, 8 Jun 2016 13:05:29 -0600 Message-ID: <20160608190529.GA26925@obsidianresearch.com> References: <1465346740-60120-1-git-send-email-eswierk@skyportsystems.com> <1465346740-60120-4-git-send-email-eswierk@skyportsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1465346740-60120-4-git-send-email-eswierk-FilZDy9cOaHkQYj/0HfcvtBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Ed Swierk Cc: linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Tue, Jun 07, 2016 at 05:45:39PM -0700, Ed Swierk wrote: > + case 0x32041114: /* Atmel 3204 */ > + chip->vendor.timeout_a = TIS_SHORT_TIMEOUT * HZ / 1000; > + chip->vendor.timeout_b = TIS_LONG_TIMEOUT * HZ / 1000; > + chip->vendor.timeout_c = TIS_SHORT_TIMEOUT * HZ / 1000; > + chip->vendor.timeout_d = TIS_SHORT_TIMEOUT * HZ / 1000; Shouldn't these use msec_to_jiffies? Jason ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e