From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bB7xZ-00053y-9l for qemu-devel@nongnu.org; Thu, 09 Jun 2016 17:57:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bB7xX-00085f-ES for qemu-devel@nongnu.org; Thu, 09 Jun 2016 17:57:52 -0400 Date: Thu, 9 Jun 2016 18:57:43 -0300 From: Eduardo Habkost Message-ID: <20160609215743.GC18662@thinpad.lan.raisama.net> References: <1465494036-23928-1-git-send-email-ehabkost@redhat.com> <5759C573.1070403@redhat.com> <20160609202134.GZ18662@thinpad.lan.raisama.net> <20160609204740.GA18662@thinpad.lan.raisama.net> <5759D79B.9040509@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5759D79B.9040509@redhat.com> Subject: Re: [Qemu-devel] [PATCH] error: Avoid redudant error_propagate() usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Markus Armbruster , kwolf@redhat.com, cornelia.huck@de.ibm.com, mreitz@redhat.com, qemu-block@nongnu.org, borntraeger@de.ibm.com On Thu, Jun 09, 2016 at 02:54:51PM -0600, Eric Blake wrote: > On 06/09/2016 02:47 PM, Eduardo Habkost wrote: > > On Thu, Jun 09, 2016 at 05:21:34PM -0300, Eduardo Habkost wrote: > >> This patch simplifies code that uses a local_err variable just to immediately > >> use it for an error_propagate() call. > > > > Please ignore this one. I found a better way to tell Coccinelle > > to do that. Updated Coccinelle patch is below, but I will send > > the actual patch tomorrow. > > Cool. Worth sticking these in scripts/coccinelle/ as part of your > commit so that we can rerun them later (and refer to them for ideas when > writing new scripts)? I didn't know about scripts/coccinelle. I will do! -- Eduardo