From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] [PATCH v2] net: au1000_eth: fix PHY detection Date: Fri, 10 Jun 2016 23:35:06 -0700 (PDT) Message-ID: <20160610.233506.1374606248492334480.davem@davemloft.net> References: <20160610221304.694639-1-manuel.lauss@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, andrew@lunn.ch To: manuel.lauss@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:35291 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041AbcFKGfI (ORCPT ); Sat, 11 Jun 2016 02:35:08 -0400 In-Reply-To: <20160610221304.694639-1-manuel.lauss@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Manuel Lauss Date: Sat, 11 Jun 2016 00:13:04 +0200 > Commit 7f854420fbfe9d49afe2ffb1df052cfe8e215541 > ("phy: Add API for {un}registering an mdio device to a bus.") > broke PHY detection on this driver with a copy-paste bug: > The code is looking 32 times for a PHY at address 0. > > Fixes ethernet on AMD DB1100/DB1500/DB1550 boards which have > their (autodetected) PHYs at address 31. > > Cc: Andrew Lunn > Signed-off-by: Manuel Lauss > --- > v2: unbreak "use highest phy addr" case. I just noticed this and fixed up my tree to use this version instead.