From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel@ffwll.ch (Daniel Vetter) Date: Fri, 10 Jun 2016 16:19:27 +0200 Subject: [PATCH 03/27] drm/arc: Actually bother with handling atomic events. In-Reply-To: <1465564954.2942.40.camel@synopsys.com> References: <1465469639.3203.57.camel@synopsys.com> <20160609122631.GO3363@phenom.ffwll.local> <1465476465.3203.66.camel@synopsys.com> <20160609132327.GQ3363@phenom.ffwll.local> <1465478829.3203.68.camel@synopsys.com> <20160609135222.GS3363@phenom.ffwll.local> <1465482496.3203.73.camel@synopsys.com> <1465564954.2942.40.camel@synopsys.com> List-ID: Message-ID: <20160610141927.GA3363@phenom.ffwll.local> To: linux-snps-arc@lists.infradead.org On Fri, Jun 10, 2016@01:23:22PM +0000, Alexey Brodkin wrote: > Hi Daniel, > > On Thu, 2016-06-09@16:37 +0200, Daniel Vetter wrote: > > On Thu, Jun 9, 2016@4:31 PM, Daniel Vetter wrote: > > > > > > On Thu, Jun 9, 2016 at 4:29 PM, Alexey Brodkin > > > wrote: > > > > > > > > Hi Daniel, > > > > > > > > On Thu, 2016-06-09@15:52 +0200, Daniel Vetter wrote: > > > > > > > > > > > > > > > The fake implementation is fundamentally racy, and I don't want to write > > > > > helpers which can't be used correctly. Anyway I think without this patch > > > > > (or something similar) arcpgu will stall badly with the new nonblocking > > > > > helpers, because arcpgu didn't bother at all to implement nonblocking. Can > > > > > you pls ack this, or even better, test the entire patch series? The > > > > > helpers themselves should work, but in all 5 drivers tested thus far they > > > > > discovered some bugs. > > > > Sure I will happily test this series. > > > > The only question then is what should I use as a proper base? > > > It should apply on drm-next from Dave. > > > > And indeed it won't work at all because arcpgu doesn't call > > drm_crtc_handle_vblank anywhere. So you need to add your patch to > > enable vblank interrupts somewhere. Note that as long as you leave > > max_vblank_counter as 0, the only bits you need is drm_vblank_init and > > drm_crtc_handle_vblanke() from the irq handler. > > So is there any sense in testing that series if vblank interrupt is not yet > supported (I'm looking forward to implementing it sometime soon but definitely > I'm not there yet)? Well, it might break your driver, so yes. I'm ofc happy to help unbreak it, but without someone who tests there's not much I can do, so will just go ahead and apply and hope it works. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 03/27] drm/arc: Actually bother with handling atomic events. Date: Fri, 10 Jun 2016 16:19:27 +0200 Message-ID: <20160610141927.GA3363@phenom.ffwll.local> References: <1465469639.3203.57.camel@synopsys.com> <20160609122631.GO3363@phenom.ffwll.local> <1465476465.3203.66.camel@synopsys.com> <20160609132327.GQ3363@phenom.ffwll.local> <1465478829.3203.68.camel@synopsys.com> <20160609135222.GS3363@phenom.ffwll.local> <1465482496.3203.73.camel@synopsys.com> <1465564954.2942.40.camel@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D44C6ED71 for ; Fri, 10 Jun 2016 14:19:36 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id n184so18303299wmn.1 for ; Fri, 10 Jun 2016 07:19:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1465564954.2942.40.camel@synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexey Brodkin Cc: "daniel.vetter@intel.com" , "linux-snps-arc@lists.infradead.org" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKdW4gMTAsIDIwMTYgYXQgMDE6MjM6MjJQTSArMDAwMCwgQWxleGV5IEJyb2RraW4g d3JvdGU6Cj4gSGkgRGFuaWVsLAo+IAo+IE9uIFRodSwgMjAxNi0wNi0wOSBhdCAxNjozNyArMDIw MCwgRGFuaWVsIFZldHRlciB3cm90ZToKPiA+IE9uIFRodSwgSnVuIDksIDIwMTYgYXQgNDozMSBQ TSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90ZToKPiA+ID4gCj4gPiA+IE9u IFRodSwgSnVuIDksIDIwMTYgYXQgNDoyOSBQTSwgQWxleGV5IEJyb2RraW4KPiA+ID4gPEFsZXhl eS5Ccm9ka2luQHN5bm9wc3lzLmNvbT4gd3JvdGU6Cj4gPiA+ID4gCj4gPiA+ID4gSGkgRGFuaWVs LAo+ID4gPiA+IAo+ID4gPiA+IE9uIFRodSwgMjAxNi0wNi0wOSBhdCAxNTo1MiArMDIwMCwgRGFu aWVsIFZldHRlciB3cm90ZToKPiA+ID4gPiA+IAo+ID4gPiA+ID4gCj4gPiA+ID4gPiBUaGUgZmFr ZSBpbXBsZW1lbnRhdGlvbiBpcyBmdW5kYW1lbnRhbGx5IHJhY3ksIGFuZCBJIGRvbid0IHdhbnQg dG8gd3JpdGUKPiA+ID4gPiA+IGhlbHBlcnMgd2hpY2ggY2FuJ3QgYmUgdXNlZCBjb3JyZWN0bHku IEFueXdheSBJIHRoaW5rIHdpdGhvdXQgdGhpcyBwYXRjaAo+ID4gPiA+ID4gKG9yIHNvbWV0aGlu ZyBzaW1pbGFyKSBhcmNwZ3Ugd2lsbCBzdGFsbCBiYWRseSB3aXRoIHRoZSBuZXcgbm9uYmxvY2tp bmcKPiA+ID4gPiA+IGhlbHBlcnMsIGJlY2F1c2UgYXJjcGd1IGRpZG4ndCBib3RoZXIgYXQgYWxs IHRvIGltcGxlbWVudCBub25ibG9ja2luZy4gQ2FuCj4gPiA+ID4gPiB5b3UgcGxzIGFjayB0aGlz LCBvciBldmVuIGJldHRlciwgdGVzdCB0aGUgZW50aXJlIHBhdGNoIHNlcmllcz8gVGhlCj4gPiA+ ID4gPiBoZWxwZXJzIHRoZW1zZWx2ZXMgc2hvdWxkIHdvcmssIGJ1dCBpbiBhbGwgNSBkcml2ZXJz IHRlc3RlZCB0aHVzIGZhciB0aGV5Cj4gPiA+ID4gPiBkaXNjb3ZlcmVkIHNvbWUgYnVncy4KPiA+ ID4gPiBTdXJlIEkgd2lsbCBoYXBwaWx5IHRlc3QgdGhpcyBzZXJpZXMuCj4gPiA+ID4gVGhlIG9u bHkgcXVlc3Rpb24gdGhlbiBpcyB3aGF0IHNob3VsZCBJIHVzZSBhcyBhIHByb3BlciBiYXNlPwo+ ID4gPiBJdCBzaG91bGQgYXBwbHkgb24gZHJtLW5leHQgZnJvbSBEYXZlLgo+ID4KPiA+IEFuZCBp bmRlZWQgaXQgd29uJ3Qgd29yayBhdCBhbGwgYmVjYXVzZSBhcmNwZ3UgZG9lc24ndCBjYWxsCj4g PiBkcm1fY3J0Y19oYW5kbGVfdmJsYW5rIGFueXdoZXJlLiBTbyB5b3UgbmVlZCB0byBhZGQgeW91 ciBwYXRjaCB0bwo+ID4gZW5hYmxlIHZibGFuayBpbnRlcnJ1cHRzIHNvbWV3aGVyZS4gTm90ZSB0 aGF0IGFzIGxvbmcgYXMgeW91IGxlYXZlCj4gPiBtYXhfdmJsYW5rX2NvdW50ZXIgYXMgMCwgdGhl IG9ubHkgYml0cyB5b3UgbmVlZCBpcyBkcm1fdmJsYW5rX2luaXQgYW5kCj4gPiBkcm1fY3J0Y19o YW5kbGVfdmJsYW5rZSgpIGZyb20gdGhlIGlycSBoYW5kbGVyLgo+IAo+IFNvIGlzIHRoZXJlIGFu eSBzZW5zZSBpbiB0ZXN0aW5nIHRoYXQgc2VyaWVzIGlmIHZibGFuayBpbnRlcnJ1cHQgaXMgbm90 IHlldAo+IHN1cHBvcnRlZCAoSSdtIGxvb2tpbmcgZm9yd2FyZCB0byBpbXBsZW1lbnRpbmcgaXQg c29tZXRpbWUgc29vbiBidXQgZGVmaW5pdGVseQo+IEknbSBub3QgdGhlcmUgeWV0KT8KCldlbGws IGl0IG1pZ2h0IGJyZWFrIHlvdXIgZHJpdmVyLCBzbyB5ZXMuIEknbSBvZmMgaGFwcHkgdG8gaGVs cCB1bmJyZWFrIGl0LApidXQgd2l0aG91dCBzb21lb25lIHdobyB0ZXN0cyB0aGVyZSdzIG5vdCBt dWNoIEkgY2FuIGRvLCBzbyB3aWxsIGp1c3QgZ28KYWhlYWQgYW5kIGFwcGx5IGFuZCBob3BlIGl0 IHdvcmtzLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRl bCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK