From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel@ffwll.ch (Daniel Vetter) Date: Fri, 10 Jun 2016 17:09:00 +0200 Subject: [PATCH 03/27] drm/arc: Actually bother with handling atomic events. In-Reply-To: <1465570815.7097.4.camel@synopsys.com> References: <20160609132327.GQ3363@phenom.ffwll.local> <1465478829.3203.68.camel@synopsys.com> <20160609135222.GS3363@phenom.ffwll.local> <1465482496.3203.73.camel@synopsys.com> <1465564954.2942.40.camel@synopsys.com> <20160610141927.GA3363@phenom.ffwll.local> <20160610145402.GG3363@phenom.ffwll.local> <1465570815.7097.4.camel@synopsys.com> List-ID: Message-ID: <20160610150900.GH3363@phenom.ffwll.local> To: linux-snps-arc@lists.infradead.org On Fri, Jun 10, 2016@03:01:03PM +0000, Alexey Brodkin wrote: > Hi Daniel, > > On Fri, 2016-06-10@16:54 +0200, Daniel Vetter wrote: > > On Fri, Jun 10, 2016@04:19:27PM +0200, Daniel Vetter wrote: > > > > > > On Fri, Jun 10, 2016@01:23:22PM +0000, Alexey Brodkin wrote: > > > > > > > > Hi Daniel, > > > > > > > > On Thu, 2016-06-09@16:37 +0200, Daniel Vetter wrote: > > > > > > > > > > On Thu, Jun 9, 2016@4:31 PM, Daniel Vetter wrote: > > > > > > > > > > > > > > > > > > On Thu, Jun 9, 2016 at 4:29 PM, Alexey Brodkin > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Hi Daniel, > > > > > > > > > > > > > > On Thu, 2016-06-09@15:52 +0200, Daniel Vetter wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The fake implementation is fundamentally racy, and I don't want to write > > > > > > > > helpers which can't be used correctly. Anyway I think without this patch > > > > > > > > (or something similar) arcpgu will stall badly with the new nonblocking > > > > > > > > helpers, because arcpgu didn't bother at all to implement nonblocking. Can > > > > > > > > you pls ack this, or even better, test the entire patch series? The > > > > > > > > helpers themselves should work, but in all 5 drivers tested thus far they > > > > > > > > discovered some bugs. > > > > > > > Sure I will happily test this series. > > > > > > > The only question then is what should I use as a proper base? > > > > > > It should apply on drm-next from Dave. > > > > > And indeed it won't work at all because arcpgu doesn't call > > > > > drm_crtc_handle_vblank anywhere. So you need to add your patch to > > > > > enable vblank interrupts somewhere. Note that as long as you leave > > > > > max_vblank_counter as 0, the only bits you need is drm_vblank_init and > > > > > drm_crtc_handle_vblanke() from the irq handler. > > > > So is there any sense in testing that series if vblank interrupt is not yet > > > > supported (I'm looking forward to implementing it sometime soon but definitely > > > > I'm not there yet)? > > > Well, it might break your driver, so yes. I'm ofc happy to help unbreak it, > > > but without someone who tests there's not much I can do, so will just go > > > ahead and apply and hope it works. > > > > Ok I went ahead and pushed a slight revised version of that patch which > > just unconditionally sends out the event. That's not correct, but at least > > that way the nonblocking changes won't totally break arcpgu and I can move > > ahead with those. > > Thanks for that. > In the meantime I tried previously sent patches: > --------------->8------------- > 9267484 drm/arc: Actually bother with handling atomic events. > cf4a489 drm/arc: Nuke event_list > 9c3152e drm/atomic-helper: Massage swap_state signature somewhat > --------------->8------------- > and on both boards (axs103 and nSIM OSCI) video works quite fine. The possible breakage only starts when you move further into the series, up to patch 10. That implements generic nonblocking commit, but that support relies upon crtc_state->event being signalled. Anyway I'm pulling it all into drm-misc now, so you can just test that branch (or linux-next when it's rebuild next week). -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 03/27] drm/arc: Actually bother with handling atomic events. Date: Fri, 10 Jun 2016 17:09:00 +0200 Message-ID: <20160610150900.GH3363@phenom.ffwll.local> References: <20160609132327.GQ3363@phenom.ffwll.local> <1465478829.3203.68.camel@synopsys.com> <20160609135222.GS3363@phenom.ffwll.local> <1465482496.3203.73.camel@synopsys.com> <1465564954.2942.40.camel@synopsys.com> <20160610141927.GA3363@phenom.ffwll.local> <20160610145402.GG3363@phenom.ffwll.local> <1465570815.7097.4.camel@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E57F6E13E for ; Fri, 10 Jun 2016 15:09:05 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id m124so18577960wme.3 for ; Fri, 10 Jun 2016 08:09:05 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1465570815.7097.4.camel@synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexey Brodkin Cc: "daniel.vetter@intel.com" , "linux-snps-arc@lists.infradead.org" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKdW4gMTAsIDIwMTYgYXQgMDM6MDE6MDNQTSArMDAwMCwgQWxleGV5IEJyb2RraW4g d3JvdGU6Cj4gSGkgRGFuaWVsLAo+IAo+IE9uIEZyaSwgMjAxNi0wNi0xMCBhdCAxNjo1NCArMDIw MCwgRGFuaWVsIFZldHRlciB3cm90ZToKPiA+IE9uIEZyaSwgSnVuIDEwLCAyMDE2IGF0IDA0OjE5 OjI3UE0gKzAyMDAsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPiA+IAo+ID4gPiBPbiBGcmksIEp1 biAxMCwgMjAxNiBhdCAwMToyMzoyMlBNICswMDAwLCBBbGV4ZXkgQnJvZGtpbiB3cm90ZToKPiA+ ID4gPiAKPiA+ID4gPiBIaSBEYW5pZWwsCj4gPiA+ID4gCj4gPiA+ID4gT24gVGh1LCAyMDE2LTA2 LTA5IGF0IDE2OjM3ICswMjAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4gPiA+ID4gCj4gPiA+ ID4gPiBPbiBUaHUsIEp1biA5LCAyMDE2IGF0IDQ6MzEgUE0sIERhbmllbCBWZXR0ZXIgPGRhbmll bEBmZndsbC5jaD4gd3JvdGU6Cj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4g T24gVGh1LCBKdW4gOSwgMjAxNiBhdCA0OjI5IFBNLCBBbGV4ZXkgQnJvZGtpbgo+ID4gPiA+ID4g PiA8QWxleGV5LkJyb2RraW5Ac3lub3BzeXMuY29tPiB3cm90ZToKPiA+ID4gPiA+ID4gPiAKPiA+ ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBIaSBEYW5pZWwsCj4gPiA+ID4gPiA+ID4gCj4gPiA+ ID4gPiA+ID4gT24gVGh1LCAyMDE2LTA2LTA5IGF0IDE1OjUyICswMjAwLCBEYW5pZWwgVmV0dGVy IHdyb3RlOgo+ID4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+ IAo+ID4gPiA+ID4gPiA+ID4gVGhlIGZha2UgaW1wbGVtZW50YXRpb24gaXMgZnVuZGFtZW50YWxs eSByYWN5LCBhbmQgSSBkb24ndCB3YW50IHRvIHdyaXRlCj4gPiA+ID4gPiA+ID4gPiBoZWxwZXJz IHdoaWNoIGNhbid0IGJlIHVzZWQgY29ycmVjdGx5LiBBbnl3YXkgSSB0aGluayB3aXRob3V0IHRo aXMgcGF0Y2gKPiA+ID4gPiA+ID4gPiA+IChvciBzb21ldGhpbmcgc2ltaWxhcikgYXJjcGd1IHdp bGwgc3RhbGwgYmFkbHkgd2l0aCB0aGUgbmV3IG5vbmJsb2NraW5nCj4gPiA+ID4gPiA+ID4gPiBo ZWxwZXJzLCBiZWNhdXNlIGFyY3BndSBkaWRuJ3QgYm90aGVyIGF0IGFsbCB0byBpbXBsZW1lbnQg bm9uYmxvY2tpbmcuIENhbgo+ID4gPiA+ID4gPiA+ID4geW91IHBscyBhY2sgdGhpcywgb3IgZXZl biBiZXR0ZXIsIHRlc3QgdGhlIGVudGlyZSBwYXRjaCBzZXJpZXM/IFRoZQo+ID4gPiA+ID4gPiA+ ID4gaGVscGVycyB0aGVtc2VsdmVzIHNob3VsZCB3b3JrLCBidXQgaW4gYWxsIDUgZHJpdmVycyB0 ZXN0ZWQgdGh1cyBmYXIgdGhleQo+ID4gPiA+ID4gPiA+ID4gZGlzY292ZXJlZCBzb21lIGJ1Z3Mu Cj4gPiA+ID4gPiA+ID4gU3VyZSBJIHdpbGwgaGFwcGlseSB0ZXN0IHRoaXMgc2VyaWVzLgo+ID4g PiA+ID4gPiA+IFRoZSBvbmx5IHF1ZXN0aW9uIHRoZW4gaXMgd2hhdCBzaG91bGQgSSB1c2UgYXMg YSBwcm9wZXIgYmFzZT8KPiA+ID4gPiA+ID4gSXQgc2hvdWxkIGFwcGx5IG9uIGRybS1uZXh0IGZy b20gRGF2ZS4KPiA+ID4gPiA+IEFuZCBpbmRlZWQgaXQgd29uJ3Qgd29yayBhdCBhbGwgYmVjYXVz ZSBhcmNwZ3UgZG9lc24ndCBjYWxsCj4gPiA+ID4gPiBkcm1fY3J0Y19oYW5kbGVfdmJsYW5rIGFu eXdoZXJlLiBTbyB5b3UgbmVlZCB0byBhZGQgeW91ciBwYXRjaCB0bwo+ID4gPiA+ID4gZW5hYmxl IHZibGFuayBpbnRlcnJ1cHRzIHNvbWV3aGVyZS4gTm90ZSB0aGF0IGFzIGxvbmcgYXMgeW91IGxl YXZlCj4gPiA+ID4gPiBtYXhfdmJsYW5rX2NvdW50ZXIgYXMgMCwgdGhlIG9ubHkgYml0cyB5b3Ug bmVlZCBpcyBkcm1fdmJsYW5rX2luaXQgYW5kCj4gPiA+ID4gPiBkcm1fY3J0Y19oYW5kbGVfdmJs YW5rZSgpIGZyb20gdGhlIGlycSBoYW5kbGVyLgo+ID4gPiA+IFNvIGlzIHRoZXJlIGFueSBzZW5z ZSBpbiB0ZXN0aW5nIHRoYXQgc2VyaWVzIGlmIHZibGFuayBpbnRlcnJ1cHQgaXMgbm90IHlldAo+ ID4gPiA+IHN1cHBvcnRlZCAoSSdtIGxvb2tpbmcgZm9yd2FyZCB0byBpbXBsZW1lbnRpbmcgaXQg c29tZXRpbWUgc29vbiBidXQgZGVmaW5pdGVseQo+ID4gPiA+IEknbSBub3QgdGhlcmUgeWV0KT8K PiA+ID4gV2VsbCwgaXQgbWlnaHQgYnJlYWsgeW91ciBkcml2ZXIsIHNvIHllcy4gSSdtIG9mYyBo YXBweSB0byBoZWxwIHVuYnJlYWsgaXQsCj4gPiA+IGJ1dCB3aXRob3V0IHNvbWVvbmUgd2hvIHRl c3RzIHRoZXJlJ3Mgbm90IG11Y2ggSSBjYW4gZG8sIHNvIHdpbGwganVzdCBnbwo+ID4gPiBhaGVh ZCBhbmQgYXBwbHkgYW5kIGhvcGUgaXQgd29ya3MuCj4gPgo+ID4gT2sgSSB3ZW50IGFoZWFkIGFu ZCBwdXNoZWQgYSBzbGlnaHQgcmV2aXNlZCB2ZXJzaW9uIG9mIHRoYXQgcGF0Y2ggd2hpY2gKPiA+ IGp1c3QgdW5jb25kaXRpb25hbGx5IHNlbmRzIG91dCB0aGUgZXZlbnQuIFRoYXQncyBub3QgY29y cmVjdCwgYnV0IGF0IGxlYXN0Cj4gPiB0aGF0IHdheSB0aGUgbm9uYmxvY2tpbmcgY2hhbmdlcyB3 b24ndCB0b3RhbGx5IGJyZWFrIGFyY3BndSBhbmQgSSBjYW4gbW92ZQo+ID4gYWhlYWQgd2l0aCB0 aG9zZS4KPiAKPiBUaGFua3MgZm9yIHRoYXQuCj4gSW4gdGhlIG1lYW50aW1lIEkgdHJpZWQgcHJl dmlvdXNseSBzZW50IHBhdGNoZXM6Cj4gLS0tLS0tLS0tLS0tLS0tPjgtLS0tLS0tLS0tLS0tCj4g OTI2NzQ4NCBkcm0vYXJjOiBBY3R1YWxseSBib3RoZXIgd2l0aCBoYW5kbGluZyBhdG9taWMgZXZl bnRzLgo+IGNmNGE0ODkgZHJtL2FyYzogTnVrZSBldmVudF9saXN0Cj4gOWMzMTUyZSBkcm0vYXRv bWljLWhlbHBlcjogTWFzc2FnZSBzd2FwX3N0YXRlIHNpZ25hdHVyZSBzb21ld2hhdAo+IC0tLS0t LS0tLS0tLS0tLT44LS0tLS0tLS0tLS0tLQo+IGFuZCBvbiBib3RoIGJvYXJkcyAoYXhzMTAzIGFu ZCBuU0lNIE9TQ0kpIHZpZGVvIHdvcmtzIHF1aXRlIGZpbmUuCgpUaGUgcG9zc2libGUgYnJlYWth Z2Ugb25seSBzdGFydHMgd2hlbiB5b3UgbW92ZSBmdXJ0aGVyIGludG8gdGhlIHNlcmllcywKdXAg dG8gcGF0Y2ggMTAuIFRoYXQgaW1wbGVtZW50cyBnZW5lcmljIG5vbmJsb2NraW5nIGNvbW1pdCwg YnV0IHRoYXQKc3VwcG9ydCByZWxpZXMgdXBvbiBjcnRjX3N0YXRlLT5ldmVudCBiZWluZyBzaWdu YWxsZWQuIEFueXdheSBJJ20gcHVsbGluZwppdCBhbGwgaW50byBkcm0tbWlzYyBub3csIHNvIHlv dSBjYW4ganVzdCB0ZXN0IHRoYXQgYnJhbmNoIChvciBsaW51eC1uZXh0CndoZW4gaXQncyByZWJ1 aWxkIG5leHQgd2VlaykuCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5l ZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=