From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: [PATCH] Makefile: Possible fix for warning of duplicated target
Date: Fri, 10 Jun 2016 09:31:38 -0700 [thread overview]
Message-ID: <20160610163138.GA3868@linux.vnet.ibm.com> (raw)
In-Reply-To: <a30d1a2e-88e1-b75f-a3bb-21952c06f46a@gmail.com>
On Fri, Jun 10, 2016 at 11:46:27PM +0900, Akira Yokosawa wrote:
> >From ad4c29bc05026135cb56f66e79585b6788c2a3aa Mon Sep 17 00:00:00 2001
> From: Akira Yokosawa <akiyks@gmail.com>
> Date: Fri, 10 Jun 2016 23:26:01 +0900
> Subject: [PATCH] Makefile: Possible fix for warning of duplicated target
>
> This commit fixes use of flavors of variables in Makefile.
> We should use "simply expanded variables" for variables
> which are referenced in definitions of other variables.
>
> Reported-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
This gets rid of the warnings, thank you! Queued and pushed.
Thanx, Paul
> ---
> Makefile | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 446c5f8..b508e61 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -5,29 +5,29 @@ LATEXSOURCES = \
> */*.tex \
> */*/*.tex
>
> -EPSSOURCES_FROM_TEX = \
> +EPSSOURCES_FROM_TEX := \
> SMPdesign/DiningPhilosopher5.eps \
> SMPdesign/DiningPhilosopher5TB.eps \
> SMPdesign/DiningPhilosopher4part-b.eps \
> SMPdesign/DiningPhilosopher5PEM.eps
>
> -DOTSOURCES = $(wildcard */*.dot)
> +DOTSOURCES := $(wildcard */*.dot)
>
> EPSSOURCES_FROM_DOT := $(DOTSOURCES:%.dot=%.eps)
>
> -EPSSOURCES_DUP = \
> +EPSSOURCES_DUP := \
> $(wildcard */*.eps) \
> $(wildcard */*/*.eps) \
> $(EPSSOURCES_FROM_TEX) \
> $(EPSSOURCES_FROM_DOT)
>
> -EPSSOURCES = $(sort $(EPSSOURCES_DUP))
> +EPSSOURCES := $(sort $(EPSSOURCES_DUP))
>
> PDFTARGETS_OF_EPS := $(EPSSOURCES:%.eps=%.pdf)
>
> BIBSOURCES = bib/*.bib
>
> -SVGSOURCES = $(wildcard */*.svg)
> +SVGSOURCES := $(wildcard */*.svg)
>
> PDFTARGETS_OF_SVG := $(SVGSOURCES:%.svg=%.pdf)
>
> --
> 1.9.1
>
>
prev parent reply other threads:[~2016-06-10 18:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 14:36 [GIT PULL] Follow-up patches of cleanup-makefile Akira Yokosawa
2016-06-09 16:17 ` Paul E. McKenney
2016-06-09 22:09 ` Akira Yokosawa
2016-06-09 23:07 ` Paul E. McKenney
2016-06-10 14:44 ` Akira Yokosawa
2016-06-10 14:46 ` [PATCH] Makefile: Possible fix for warning of duplicated target Akira Yokosawa
2016-06-10 16:31 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610163138.GA3868@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akiyks@gmail.com \
--cc=perfbook@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.