From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49128)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1bBS2e-0005dp-4D
	for qemu-devel@nongnu.org; Fri, 10 Jun 2016 15:24:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1bBS2a-0006x4-SZ
	for qemu-devel@nongnu.org; Fri, 10 Jun 2016 15:24:28 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44333)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1bBS2Y-0006pb-GG
	for qemu-devel@nongnu.org; Fri, 10 Jun 2016 15:24:24 -0400
Date: Fri, 10 Jun 2016 15:24:12 -0400
From: "Emilio G. Cota" <cota@braap.org>
Message-ID: <20160610192412.GA22607@flamenco>
References: <CAFEAcA-1RZrdEC+f+WxM=uahtcbdEC+SZDyTkYSeObWPKVEP9w@mail.gmail.com>
	<CAFEAcA8nFKcG5vy3EoWJhjLYmzOLFS1nYY74Dtu3E51oWPnuEw@mail.gmail.com>
	<20160610163432.GA22231@flamenco>
	<CAFEAcA8ALC0i250JFBWn0G-ZwyaryrKTR6r=ixscngbrjT7M3w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAFEAcA8ALC0i250JFBWn0G-ZwyaryrKTR6r=ixscngbrjT7M3w@mail.gmail.com>
Subject: Re: [Qemu-devel] [PULL 00/15] tb hash improvements
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Richard Henderson <rth@twiddle.net>, QEMU Developers <qemu-devel@nongnu.org>

On Fri, Jun 10, 2016 at 17:41:26 +0100, Peter Maydell wrote:
> On 10 June 2016 at 17:34, Emilio G. Cota <cota@braap.org> wrote:
> > On Fri, Jun 10, 2016 at 16:33:10 +0100, Peter Maydell wrote:
> >> Fails to build on ppc64be :-(
> >>
> >> In file included from /home/pm215/qemu/include/qemu/thread.h:4:0,
> >>                  from /home/pm215/qemu/include/block/aio.h:20,
> >>                  from /home/pm215/qemu/include/block/block.h:4,
> >>                  from /home/pm215/qemu/include/monitor/monitor.h:6,
> >>                  from /home/pm215/qemu/trace/control.c:23:
> >> /home/pm215/qemu/include/qemu/processor.h:24:35: error: expected
> >> identifier or ‘(’ before string constant
> >>                                    "or 2, 2, 2;" ::: "memory")
> >
> > On Fri, Jun 10, 2016 at 16:57:19 +0100, Peter Maydell wrote:
> >> Also fails trying to build a test on 32-bit:
> >>
> >> /home/petmay01/qemu/tests/qht-bench.c: In function 'pr_params':
> >> /home/petmay01/qemu/tests/qht-bench.c:270:5: error: format '%zu'
> >> expects argument of type 'size_t', but argument 2 has type 'long
> >> unsigned int' [-Werror=format=]
> >>      printf(" lookup range:      %zu\n", lookup_range);
> >
> > Can you please test again after applying the appended delta?
> 
> I will test.
> 
> For the PPC asm, is it not just wanting the "\n" between instructions?
> Shouldn't be necessary to use two separate asm() lines...

I can't test on ppc so I was just being paranoid to avoid
wasting your time :-)

		E.