From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bC5z8-00015N-9G for qemu-devel@nongnu.org; Sun, 12 Jun 2016 10:03:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bC5z6-0003le-Ah for qemu-devel@nongnu.org; Sun, 12 Jun 2016 10:03:29 -0400 Date: Sun, 12 Jun 2016 16:03:16 +0200 From: Andrew Jones Message-ID: <20160612140316.rdpdfr6xgw7tvvoq@hawk.localdomain> References: <1465580427-13596-1-git-send-email-drjones@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465580427-13596-1-git-send-email-drjones@redhat.com> Subject: Re: [Qemu-devel] [PATCH RFC 00/16] Rework SMP parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, qemu-arm@nongnu.org Cc: peter.maydell@linaro.org, ehabkost@redhat.com, agraf@suse.de, pbonzini@redhat.com, dgibson@redhat.com, imammedo@redhat.com, david@gibson.dropbear.id.au On Fri, Jun 10, 2016 at 07:40:11PM +0200, Andrew Jones wrote: > This series is a first step in eliminating smp_* global > variables (the last patch gets rid of two of them!) And, it's > a first step in deprecating '-smp' in favor of using machine > properties, e.g. > qemu -machine pc,sockets=2,cores=2,threads=2,maxcpus=8,cpus=8 ... > > It's also a first step in allowing machine types to override > the default parameter parsing, which makes assumptions that > not all machine types may agree with. (mach-virt is coming...) > > So, three first steps, I guess that's 3 steps. And a forth > thing it does is some fixes for the smp parsing and also for > SMBIOS use of cpu topology. > > Tested with kvm-unit-tests on all five arches supported > there, x86_64 both with KVM and TCG, and booting an x86_64 > guest (KVM) to check SMBIOS before and after in order to make > sure it was the same. Also compile tested all targets. I forgot to run 'make check'. Just did now. All but one test passed. Nope, it wasn't pc-cpu-test (the only cpu topology using test) that failed. That one did output two new warnings, so I should fix and/or deprecate it. The one that did fail was vhost-user-test. I confirmed that it does not fail without this series. I'll look into it soon, maybe tomorrow. drew