From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933077AbcFLR45 (ORCPT ); Sun, 12 Jun 2016 13:56:57 -0400 Received: from mail-bn1on0068.outbound.protection.outlook.com ([157.56.110.68]:2240 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932081AbcFLR4w (ORCPT ); Sun, 12 Jun 2016 13:56:52 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Sun, 12 Jun 2016 20:56:44 +0300 From: Yury Norov To: "Zhangjian (Bamvor)" CC: , , , , , , , , , , , , , , , , , , , , , , Andrew Pinski , Hanjun Guo Subject: Re: [PATCH 13/23] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat) Message-ID: <20160612175644.GA12475@yury-N73SV> References: <1464048292-30136-1-git-send-email-ynorov@caviumnetworks.com> <1464048292-30136-14-git-send-email-ynorov@caviumnetworks.com> <575D53B0.5020408@huawei.com> <575D5ECC.4030000@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <575D5ECC.4030000@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [96.95.216.225] X-ClientProxiedBy: CY1PR21CA0063.namprd21.prod.outlook.com (10.163.250.159) To BN4PR07MB2241.namprd07.prod.outlook.com (10.164.63.147) X-MS-Office365-Filtering-Correlation-Id: 24200560-d440-4b62-e19a-08d392eaed6a X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2241;2:ev1NpVC6J9u6IVrT20ne7pVCJE1uN57sJdRPCkoG1/GQ4dlmdDYoUCjI4kVcS9klb8NyYCG+Ny+j+DzxTo5c84DK7s8FK3mJwF6IStOzqhgIOhqB7d0rMu38mRAnN9h4aH/5sjYHWThO+2nVN/bamVAYbak1Brymj2tV9+gIuXrGL5MXm/oddYAjfhCd6gwY;3:UIsJHM7ThYORkAWxMIyilogABDHGfP7n8Nm+bp5+3O2VuvtaO/ztDnQCV2JsUJUiMM+lzzRfewp9J9L2dA3yl8UY4+Un7Vb/x4Pj2XiZl4/FQzrlauzNpZ3X3FPD0wot;25:XfHNTP+KFRsFZFV/Q8FDq07HgIQMcNX/XwPTIWqkHtbBcAVlek3lWoDRDj1FulQ63LZEIMdUk3Ac/hIgB8cQgEJSp6gXhmgFbFlotNImtzI+sw+GXLi+tntCcmnOdU3n10YXZkVYIDkzX0Tpmj0fBu3Jx6kh6sCO2gwajcO7YqRzB11dDAv9cegDWiH2hJgr1hsXbTp+39H7XM7V3tP7GkzbD88gnl6+ZOJGkyUHNT5qkrLqWOeMAzkCaWaGaerNwg4EC7spSmM5KaIoPm5mdqeXLqlFdvMNBR/WP32Y8oyYZDxOVZnHVto8UhpROwJz8vT2RdOrYWKkNfu6VgOt+mLsR/s1qeTe/gvlIHxelrKRJLM19bRK1tSZVRx4TAuOyC7PkiQcYogEiUhnYt8oHY05ApTRtA5+3bU2qBnWoyQ= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2241; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2241;20:NtKx71a5W0rbou356WhIN3NAlc9LXVL1n5QrbXvfVv5bLql3H+Gw/3k6dEqMp+PKkgUH9b0DpTMiqr0nYOFvlZ/4+vZo2rdJ/Di0GLzytqD8kfy8wAXCnCdpagqlRGE9pfmC/zKPi6z3uG2XBWGkPXNcfYh/TimccpGGsyVe131xn0POvw/Pp8pwS0kvrlW4TRrQ05ccjJSx33SK9yfGZx30bJDb8TpzVGPrlZri8N/dLPqFz2A8++OvqzUJcwF3jZDZGKZ1e97R9uEoUC8mQsdQCxegzJSys/YbC364cDFzj9kGmfhIxTmx3x3+5uNbn9oGM9GlARh1lqlc0M1tSrqZxSZfL6sIfblyBDy+7afW7hwpPImiA5lbBNnL8YxCCRCSdCVrnqmdtLCwjuo+PXZN54N2QWDIu8QormuO2EZkkgo56OnXvlYJ2R18hPD5/GpLnPmC4b+fui/wcay/xXLVSABAqHhz7dba6mdCheel0w++OtFZuEZlGS0V+3TcBYk8Zh3kokIS2j/BP4LpRhkWU1FdHK9Fl9QUVD/+xsuNK74QQTg4CWp8g80ki+c02s4iwfEjcWHTtIyQtmUTxAV1f9Q9T5i+ELiwGqkWQMk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BN4PR07MB2241;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2241; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2241;4:tZgoyIw9VujPx+XHlOInUCxlRWznwvA06OrxE/Z0tHUZQkD1ztcEQq+jOm/jFk/UFjavrOYB/xWg9V22zKxGqtpfS/dEtNzdUQfQrgXYQJx3zLVJ2CMw+xtr8FY4hTfXTqZiRGhQhtWhkzQ/+dhxEmhMvKG7DviFCpriiAughV/K2WxO/9lFgbAL0bAd9cwmDA3JApguNJF4dze8+9iuN7UwYrEfAb36J6w2AJC9Ysi0fx734WludhEDj5/jPpF29eFAxLSyKYjzM464+lqDtZXbqc/w9vvEF330YEGi6QQKAthFrRcNwy9osK/mX88/3IB+aHuO0ePM52qp1otOhjyUgw3qVLN2v3wr0H5XT3bhzlzIu2yeW1DYCYM3CCjA X-Forefront-PRVS: 0971922F40 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(199003)(189002)(24454002)(586003)(97756001)(2906002)(23726003)(1076002)(2950100001)(6116002)(81156014)(81166006)(9686002)(3846002)(4326007)(101416001)(54356999)(76176999)(50986999)(33716001)(92566002)(42186005)(76506005)(68736007)(77096005)(83506001)(66066001)(47776003)(5008740100001)(50466002)(33656002)(106356001)(93886004)(46406003)(110136002)(8676002)(5004730100002)(105586002)(97736004)(189998001)(4001350100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2241;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN4PR07MB2241;23:fsB2hxzuluPYVcqe/IQIkzv0rxxHA7jHZ3Hzu4h9j?= =?us-ascii?Q?TC9Czw1VpDxv4QIIZjSBc6pf5uEqSbubEkIkOXmQCU3J9Q82UD2D2gYMTHq6?= =?us-ascii?Q?8iXEjfTiEKOjyQX+EKU7+ZCJriyAea6TvDc4I22S7slJOntzKtdMF97w2ajZ?= =?us-ascii?Q?hkPtTftSITi4mto3nNAIk5cYPVk1Gi9ePTtiosU6VJ9D8LQmsPn5EbwKlSJG?= =?us-ascii?Q?aHQMpBO/UBnxWLssBXO8yufiKgUHgksgc02UALHgrEecIo1fkhcqCTb/lc0f?= =?us-ascii?Q?fQPrjKKVLWsPNnvAUgqZ1ZrD/jZE6uPv36eBFcNjkG2qDZ7BHf9o0LEd0a7q?= =?us-ascii?Q?iXVT5uhg0B5ena2daa2XC3Kw98btphkCY73pIwUUWDLo1hNIq7O6QzRKy/4e?= =?us-ascii?Q?9e7JZrSbvcZAHGvUDexh/o6yswe5gZXkeNoPFFbVhcqiihVGVeE6PZF4WCRo?= =?us-ascii?Q?b3ksbXfo1FSDr8zDsaylTnzoEGc4gQAKaK+XHLaaDroRLaIYfSWns5QF1rMt?= =?us-ascii?Q?yOJBwU+9F3536Yi0M2xDwQlknv0l1p2wC1sesql9jVotYfeXjLIFAUbi+VA6?= =?us-ascii?Q?U4Y1yYU3u2aGwTkOwbm1U7tvjOrrTbVYQ7CKlShYXwBqZDLrYqEKYs1AlxDu?= =?us-ascii?Q?9ybIkWYgBkkohqediniGPY94aI76juNJepfhl0qiBMP4OJyEL1qOiIFWZrh0?= =?us-ascii?Q?7f5nKHVn+XfOXXdisPLjiXhfmM9uec1p5ipBqWwEd4lugZnyyOHPHuSHRLti?= =?us-ascii?Q?YiqUzpzbD1CdHV1WGRc5gwIfzXVBGCR9URql3XnGAEQdVhkN7xBnmq3UyfrU?= =?us-ascii?Q?7erc4OR9pBM1UzdFYP/igJHCV9j/1bV1w0sEwCmyYyAzYdVEeLVCMjkO90XU?= =?us-ascii?Q?WcDRpAz6sDgBS7gXHp8wF+gLb5l3qc14+arlfz+okkE8yMKInBqW9ag767/x?= =?us-ascii?Q?2jB9X71tEYNdHYS8bE1lwDOGJF8g6NkFQjZhBCW83G0c1GpvbJ+AxGEjXr2H?= =?us-ascii?Q?NoCtWW1EeAVD5xs/qQBlnR+OKUUiz66ZeyodQ4PcTTC8X0uvrssjHkCNAYZJ?= =?us-ascii?Q?a2bpyctArbvMl3K70ZvvGxrnbvLh+zzwV1vTmiTVNBxL08E8gpyuaOXOnWKw?= =?us-ascii?Q?ALcEM8f/e0SlkNsu1cE3UEKwJ0meAHB?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2241;5:NwAk+Oc1es8at6fwXlo2eRwbcAuqkVN7K2sSBDRfoulznqXrvGep7P2LinxNUtMm3D2Ew5poI693G9gtFKDJdXxZwGmkv1u5PhUyqTYo8uVPcq1780GwwwAWrLdSHH54sZeEEWt8idv0BkLkB6aK0A==;24:XFMUJRqdgCtM2pcUUOvQ00AlxhF/jxiVK/bRRnY0/OjwuU7tuyye9HWwGpL1orb+qjoHDsWvtZ4KKq8Dt+yTD+V+Jfte4jFUCDgAePeWg4U=;7:Hf3mAMZ319qwiluCDsb3SXXjSD1n459E301gF9Gf66r6fpLFZnDBxxbqXrobourfr6RvyDC0SkHl01zDuGK42KTmTj+B5dnFF/2P3mvPRy+LCXb3Px0J8+Hu+ydf5HRhkWjCYbUez+7E3EWAhGcKZjycrAHPSErJ/PFHBjmgzsaU/UKNbpxrup7mYtJvZXeNGJ8mTkmdXlXgqgPPdfZBkQ== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2016 17:56:48.9922 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2241 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 12, 2016 at 09:08:28PM +0800, Zhangjian (Bamvor) wrote: > >> #ifdef CONFIG_COMPAT > >> #define TASK_SIZE_32 UL(0x100000000) > >>-#define TASK_SIZE (test_thread_flag(TIF_32BIT) ? \ > >>+#define TASK_SIZE (is_compat_task() ? \ > >> TASK_SIZE_32 : TASK_SIZE_64) > >> #define TASK_SIZE_OF(tsk) (test_tsk_thread_flag(tsk, TIF_32BIT) ? \ > >> TASK_SIZE_32 : TASK_SIZE_64) > >Should we update or delete this macro? > > #define TASK_SIZE_OF(tsk) (is_compat_task() ? \ > >TASK_SIZE_32 : TASK_SIZE_64) > Sorry it should be: > #define TASK_SIZE_OF(tsk) ((is_a32_compat_thread(task_thread_info(tsk)) \ > || is_ilp32_compat_thread(task_thread_info(tsk))) ? \ > TASK_SIZE_32 : TASK_SIZE_64) Thank you. I know about this, but always forget to fix. ) I think we'd introduce is_compat_thread() as well. > >x86, sparc, mips, ppc, parisc, s390 define its own version. But > >"include/linux/sched.h" will define it if > >TASK_SIZE_OF does not exist: > >#ifndef TASK_SIZE_OF > >#define TASK_SIZE_OF(tsk) TASK_SIZE > >#endif > > > > > >Regards > > > >Bamvor > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yury Norov Subject: Re: [PATCH 13/23] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat) Date: Sun, 12 Jun 2016 20:56:44 +0300 Message-ID: <20160612175644.GA12475@yury-N73SV> References: <1464048292-30136-1-git-send-email-ynorov@caviumnetworks.com> <1464048292-30136-14-git-send-email-ynorov@caviumnetworks.com> <575D53B0.5020408@huawei.com> <575D5ECC.4030000@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Content-Disposition: inline In-Reply-To: <575D5ECC.4030000@huawei.com> List-Archive: List-Post: To: "Zhangjian (Bamvor)" Cc: arnd@arndb.de, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, libc-alpha@sourceware.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, pinskia@gmail.com, broonie@kernel.org, joseph@codesourcery.com, christoph.muellner@theobroma-systems.com, szabolcs.nagy@arm.com, klimov.linux@gmail.com, Nathan_Lynch@mentor.com, agraf@suse.de, Prasun.Kapoor@caviumnetworks.com, kilobyte@angband.pl, geert@linux-m68k.org, philipp.tomsich@theobroma-systems.com, Andrew Pinski , Hanjun Guo List-ID: On Sun, Jun 12, 2016 at 09:08:28PM +0800, Zhangjian (Bamvor) wrote: > >> #ifdef CONFIG_COMPAT > >> #define TASK_SIZE_32 UL(0x100000000) > >>-#define TASK_SIZE (test_thread_flag(TIF_32BIT) ? \ > >>+#define TASK_SIZE (is_compat_task() ? \ > >> TASK_SIZE_32 : TASK_SIZE_64) > >> #define TASK_SIZE_OF(tsk) (test_tsk_thread_flag(tsk, TIF_32BIT) ? \ > >> TASK_SIZE_32 : TASK_SIZE_64) > >Should we update or delete this macro? > > #define TASK_SIZE_OF(tsk) (is_compat_task() ? \ > >TASK_SIZE_32 : TASK_SIZE_64) > Sorry it should be: > #define TASK_SIZE_OF(tsk) ((is_a32_compat_thread(task_thread_info(tsk)) \ > || is_ilp32_compat_thread(task_thread_info(tsk))) ? \ > TASK_SIZE_32 : TASK_SIZE_64) Thank you. I know about this, but always forget to fix. ) I think we'd introduce is_compat_thread() as well. > >x86, sparc, mips, ppc, parisc, s390 define its own version. But > >"include/linux/sched.h" will define it if > >TASK_SIZE_OF does not exist: > >#ifndef TASK_SIZE_OF > >#define TASK_SIZE_OF(tsk) TASK_SIZE > >#endif > > > > > >Regards > > > >Bamvor > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: ynorov@caviumnetworks.com (Yury Norov) Date: Sun, 12 Jun 2016 20:56:44 +0300 Subject: [PATCH 13/23] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat) In-Reply-To: <575D5ECC.4030000@huawei.com> References: <1464048292-30136-1-git-send-email-ynorov@caviumnetworks.com> <1464048292-30136-14-git-send-email-ynorov@caviumnetworks.com> <575D53B0.5020408@huawei.com> <575D5ECC.4030000@huawei.com> Message-ID: <20160612175644.GA12475@yury-N73SV> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Jun 12, 2016 at 09:08:28PM +0800, Zhangjian (Bamvor) wrote: > >> #ifdef CONFIG_COMPAT > >> #define TASK_SIZE_32 UL(0x100000000) > >>-#define TASK_SIZE (test_thread_flag(TIF_32BIT) ? \ > >>+#define TASK_SIZE (is_compat_task() ? \ > >> TASK_SIZE_32 : TASK_SIZE_64) > >> #define TASK_SIZE_OF(tsk) (test_tsk_thread_flag(tsk, TIF_32BIT) ? \ > >> TASK_SIZE_32 : TASK_SIZE_64) > >Should we update or delete this macro? > > #define TASK_SIZE_OF(tsk) (is_compat_task() ? \ > >TASK_SIZE_32 : TASK_SIZE_64) > Sorry it should be: > #define TASK_SIZE_OF(tsk) ((is_a32_compat_thread(task_thread_info(tsk)) \ > || is_ilp32_compat_thread(task_thread_info(tsk))) ? \ > TASK_SIZE_32 : TASK_SIZE_64) Thank you. I know about this, but always forget to fix. ) I think we'd introduce is_compat_thread() as well. > >x86, sparc, mips, ppc, parisc, s390 define its own version. But > >"include/linux/sched.h" will define it if > >TASK_SIZE_OF does not exist: > >#ifndef TASK_SIZE_OF > >#define TASK_SIZE_OF(tsk) TASK_SIZE > >#endif > > > > > >Regards > > > >Bamvor > >