From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCRlq-0007fb-MK for qemu-devel@nongnu.org; Mon, 13 Jun 2016 09:19:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCRlm-0002c7-VJ for qemu-devel@nongnu.org; Mon, 13 Jun 2016 09:19:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCRlm-0002bx-Pl for qemu-devel@nongnu.org; Mon, 13 Jun 2016 09:19:10 -0400 Date: Mon, 13 Jun 2016 14:19:08 +0100 From: Stefan Hajnoczi Message-ID: <20160613131908.GO27781@stefanha-x1.localdomain> References: <1464686130-12265-1-git-send-email-den@openvz.org> <1464686130-12265-9-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9pS2hy4/DrI8BQlq" Content-Disposition: inline In-Reply-To: <1464686130-12265-9-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH 08/11] drive-backup: added support for data compression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: qemu-devel@nongnu.org, Pavel Butsykin , Jeff Cody , Markus Armbruster , Eric Blake , John Snow , Kevin Wolf --9pS2hy4/DrI8BQlq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 31, 2016 at 12:15:27PM +0300, Denis V. Lunev wrote: > From: Pavel Butsykin >=20 > The idea is simple - backup is "written-once" data. It is written block > by block and it is large enough. It would be nice to save storage > space and compress it. >=20 > The patch adds a flag to the qmp/hmp drive-backup command which enables > block compression. Compression should be implemented in the format driver > to enable this feature. >=20 > There are some limitations of the format driver to allow compressed write= s. > We can write data only once. Though for backup this is perfectly fine. > These limitations are maintained by the driver and the error will be > reported if we are doing something wrong. >=20 > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > CC: Jeff Cody > CC: Markus Armbruster > CC: Eric Blake > CC: John Snow > CC: Stefan Hajnoczi > CC: Kevin Wolf > --- > block/backup.c | 13 +++++++++++++ > blockdev.c | 12 ++++++++++-- > hmp-commands.hx | 8 +++++--- > hmp.c | 3 ++- > include/block/block_int.h | 1 + > qapi/block-core.json | 5 ++++- > qmp-commands.hx | 5 ++++- > 7 files changed, 39 insertions(+), 8 deletions(-) Reviewed-by: Stefan Hajnoczi --9pS2hy4/DrI8BQlq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXXrLMAAoJEJykq7OBq3PI8zYH/jXA9nL6O6RBVYD2PkaxkUJ0 jsxZg6rcLTlbcSSvAKBUfrS7+CUS5WxqXDA97Qjq9cNwBo+7am3CYvK4WSUJcc9K u3OZC9wWsg3qWeNx+QU1suJbyLk0W+Ts6FUOWH7Wm0Z88wf2RJtgc8PeSQE2k/5l ey9hqpMKwejZ4kMyUzz48Pu0Gqbx1TklRqNpK7ohVyyRuwWlUy3nhHInXg3xx3Ra YSn202Mti2CFFeiPPgPVf6fJPdckCsD0Z2fwLWWPPIlbVyIeSKAS8ypic/yZlZMs RLaPta2u8zxifFWtK5dRXmiSOZE1m+fUcM8sM0+/L+/GSOKdWWsMZ4XCcfbQNBk= =3Jfn -----END PGP SIGNATURE----- --9pS2hy4/DrI8BQlq--