All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sudarsana.kalluru@qlogic.com
Cc: netdev@vger.kernel.org, Yuval.Mintz@qlogic.com
Subject: Re: [PATCH net-next 1/1] Remove the redundant initialization statement.
Date: Tue, 14 Jun 2016 22:28:23 -0700 (PDT)	[thread overview]
Message-ID: <20160614.222823.1233657486694266740.davem@davemloft.net> (raw)
In-Reply-To: <1465808470-27424-1-git-send-email-sudarsana.kalluru@qlogic.com>

From: Sudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com>
Date: Mon, 13 Jun 2016 05:01:10 -0400

> The callback ".getcbx" is being initialized twice. This was introduced by
> the commit 0fdeb72aa6c9 ("qede: Add dcbnl support."). The patch removes the
> redundant initialization statement.
> 
> Reported-by: Julia Lawall <julia.lawall@lip6.fr> 
> Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
> Signed-off-by: Sudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com>

This subject line is not properly formed.

After "[PATCH ...] " you must provide a proper subsystem prefix specifier
followed by a colon character, and a SPACE.

Otherwise nobody reading the GIT shortlog has any idea where in the kernel
your change is taking place.

An appropriate subsystem prefix for this patch woult be "qede: ".

      reply	other threads:[~2016-06-15  5:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-13  9:01 [PATCH net-next 1/1] Remove the redundant initialization statement Sudarsana Reddy Kalluru
2016-06-15  5:28 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160614.222823.1233657486694266740.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Yuval.Mintz@qlogic.com \
    --cc=netdev@vger.kernel.org \
    --cc=sudarsana.kalluru@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.