Re: [V3, 2/4] spi: bcm-qspi: Add SPI flash and MSPI driver

From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Kamal Dasu <kdasu.kdev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
	vikram.prakash-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
	andy.fung-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
	jon.mason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
	Yendapally Reddy Dhananjaya Reddy
	<yendapally.reddy-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Subject: Re: [V3, 2/4] spi: bcm-qspi: Add SPI flash and MSPI driver
Date: Tue, 14 Jun 2016 09:45:38 +0100	[thread overview]
Message-ID: <20160614084538.GM2282@sirena.org.uk> (raw)
In-Reply-To: <575F0EAD.5080608-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

On Mon, Jun 13, 2016 at 12:51:09PM -0700, Florian Fainelli wrote:
> On 06/13/2016 03:13 AM, Mark Brown wrote:
> >> +static const struct of_device_id bcm_qspi_of_match[] = {
> >> +	{ .compatible = "brcm,spi-bcm-qspi" },
> >> +	{ .compatible = "brcm,qspi-brcmstb" },
> >> +	{ .compatible = "brcm,spi-brcmstb-mspi"},
> >> +	{},
> >> +};
> >> +MODULE_DEVICE_TABLE(of, bcm_qspi_of_match);

> > This is adding new DT bindings but there is no documentation,
> > documentation is required for all DT bindings.

> The binding documentation is added to patch 1, which you are listed as a
> recipient for.

So this is a perfect example of why you should use standard formats for
subject lines, if things don't look relevant they're likely to get
missed.  In this case it's both the prefix and the fact that the version
is added in a weird way.  Frankly I didn't even notice that it wasn't a
cover letter.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]