Re: [PATCH 2/8] MIPS: KVM: Add kvm_aux trace event

[James Hogan <james.hogan@imgtec.com>]

[-- Attachment #1: Type: text/plain, Size: 1653 bytes --]

On Tue, Jun 14, 2016 at 11:15:40AM +0200, Paolo Bonzini wrote:
> 
> 
> On 14/06/2016 10:55, James Hogan wrote:
> > hmm, sorry, I don't know how i didn't spot when I checked these over
> > that fpu_msa is still referred to here instead of aux. I'll post a V2 of
> > this patch with s/fpu_msa/aux/.
> 
> I can fix it up to kvm_trace_symbol_aux_op and kvm_trace_symbol_aux_state.

Great, thanks Paolo. Looks good.

Cheers
James

> 
> diff --git a/arch/mips/kvm/trace.h b/arch/mips/kvm/trace.h
> index 32ac7cc82e13..f3ada591ca25 100644
> --- a/arch/mips/kvm/trace.h
> +++ b/arch/mips/kvm/trace.h
> @@ -48,14 +48,14 @@ TRACE_EVENT(kvm_exit,
>  #define KVM_TRACE_AUX_MSA		2
>  #define KVM_TRACE_AUX_FPU_MSA		3
>  
> -#define kvm_trace_symbol_fpu_msa_op		\
> +#define kvm_trace_symbol_aux_op		\
>  	{ KVM_TRACE_AUX_RESTORE, "restore" },	\
>  	{ KVM_TRACE_AUX_SAVE,    "save" },	\
>  	{ KVM_TRACE_AUX_ENABLE,  "enable" },	\
>  	{ KVM_TRACE_AUX_DISABLE, "disable" },	\
>  	{ KVM_TRACE_AUX_DISCARD, "discard" }
>  
> -#define kvm_trace_symbol_fpu_msa_state		\
> +#define kvm_trace_symbol_aux_state		\
>  	{ KVM_TRACE_AUX_FPU,     "FPU" },	\
>  	{ KVM_TRACE_AUX_MSA,     "MSA" },	\
>  	{ KVM_TRACE_AUX_FPU_MSA, "FPU & MSA" }
> @@ -78,9 +78,9 @@ TRACE_EVENT(kvm_aux,
>  
>  	    TP_printk("%s %s PC: 0x%08lx",
>  		      __print_symbolic(__entry->op,
> -				       kvm_trace_symbol_fpu_msa_op),
> +				       kvm_trace_symbol_aux_op),
>  		      __print_symbolic(__entry->state,
> -				       kvm_trace_symbol_fpu_msa_state),
> +				       kvm_trace_symbol_aux_state),
>  		      __entry->pc)
>  );
>  
> 
> Paolo

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]