From mboxrd@z Thu Jan  1 00:00:00 1970
From: yunhong jiang <yunhong.jiang@linux.intel.com>
Subject: Re: [RFC PATCH V2 2/4] Utilize the vmx preemption timer
Date: Tue, 14 Jun 2016 09:46:06 -0700
Message-ID: <20160614094606.3fc0ed03@jnakajim-build>
References: <1464128852-14138-1-git-send-email-yunhong.jiang@linux.intel.com>
	<1464128852-14138-3-git-send-email-yunhong.jiang@linux.intel.com>
	<20160614125537.b3qlcjytjb64ezht@rkaganb.sw.ru>
	<27f8a049-4e8f-27fd-8fe2-6121f6218f25@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Roman Kagan <rkagan@virtuozzo.com>, kvm@vger.kernel.org,
	mtosatti@redhat.com, rkrcmar@redhat.com, kernellwp@gmail.com
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mga01.intel.com ([192.55.52.88]:54914 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751727AbcFNQux (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 14 Jun 2016 12:50:53 -0400
In-Reply-To: <27f8a049-4e8f-27fd-8fe2-6121f6218f25@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, 14 Jun 2016 15:41:07 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> 
> 
> On 14/06/2016 15:23, Roman Kagan wrote:
> >> >  
> >> > +static int cpu_preemption_timer_multi;
> >> > +static bool __read_mostly enable_hv_timer;
> >> > +module_param_named(enable_hv_timer, enable_hv_timer, bool,
> >> > S_IRUGO); +
> > Non-techincal issue: I think the naming for the parameter is
> > unfortunate, as it looks similar to a number of CPU properties in
> > QEMU that start with "hv-", which are all related to MS Hyper-V
> > compatibility features.
> 
> Non-technical but important.  Let's change it to preemption_timer (and
> the variable to enable_preemption_timer).
> 
> The code can keep the "hv_timer" moniker though.

Hi, Paolo, should I resend the patch for this change?

Thanks
--jyh

> 
> Paolo