All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kenneth Westfield <kwestfie@codeaurora.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
	alsa-devel@alsa-project.org, Patrick Lai <plai@codeaurora.org>,
	Banajit Goswami <bgoswami@codeaurora.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH v2 2/2] sound: lpass-platform: Move dma channel allocation to pcmops
Date: Tue, 14 Jun 2016 09:33:07 -0700	[thread overview]
Message-ID: <20160614163248.GA13496@kwestfie-linux.qualcomm.com> (raw)
In-Reply-To: <576007FA.2050705@linaro.org>

On Tue, Jun 14, 2016 at 06:34:50AM -0700, Srinivas Kandagatla wrote:
> On 14/06/16 13:49, Kenneth Westfield wrote:
> >On Tue, Jun 14, 2016 at 09:30:03AM +0100, Srinivas Kandagatla wrote:

> >>-	data = devm_kzalloc(soc_runtime->dev, sizeof(*data), GFP_KERNEL);
> >>+	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
> >
> >Is the reason for changing the dev pointer similar to why it was changed
> >for snd_dma_alloc_pages() below?
> Yep, Only reason is that I can fit stuff in single line.

The original line fit in one as well.  If that is the reason, maybe
just leave it unchanged.

-- 
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project

      reply	other threads:[~2016-06-14 16:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14  8:30 [PATCH v2 1/2] sound: lpass-cpu: add module licence and description Srinivas Kandagatla
2016-06-14  8:30 ` Srinivas Kandagatla
2016-06-14  8:30 ` [PATCH v2 2/2] sound: lpass-platform: Move dma channel allocation to pcmops Srinivas Kandagatla
2016-06-14 12:49   ` Kenneth Westfield
2016-06-14 13:34     ` Srinivas Kandagatla
2016-06-14 16:33       ` Kenneth Westfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160614163248.GA13496@kwestfie-linux.qualcomm.com \
    --to=kwestfie@codeaurora.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@codeaurora.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=plai@codeaurora.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.