From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752149AbcFOEbw (ORCPT ); Wed, 15 Jun 2016 00:31:52 -0400 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:60144 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750801AbcFOEbv (ORCPT ); Wed, 15 Jun 2016 00:31:51 -0400 Date: Wed, 15 Jun 2016 07:31:16 +0300 From: Sakari Ailus To: Rob Herring Cc: Ivaylo Dimitrov , sre@kernel.org, pali.rohar@gmail.com, pavel@ucw.cz, linux-media@vger.kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, mchehab@osg.samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] media: et8ek8: Add documentation Message-ID: <20160615043116.GG26360@valkosipuli.retiisi.org.uk> References: <1465659593-16858-1-git-send-email-ivo.g.dimitrov.75@gmail.com> <1465659593-16858-3-git-send-email-ivo.g.dimitrov.75@gmail.com> <20160614220517.GA23504@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160614220517.GA23504@rob-hp-laptop> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On Tue, Jun 14, 2016 at 05:05:17PM -0500, Rob Herring wrote: > On Sat, Jun 11, 2016 at 06:39:53PM +0300, Ivaylo Dimitrov wrote: > > Add DT bindings description > > Not exactly the best commit msg. > > > > > Signed-off-by: Ivaylo Dimitrov > > --- > > .../bindings/media/i2c/toshiba,et8ek8.txt | 50 ++++++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > > new file mode 100644 > > index 0000000..997d268 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > > @@ -0,0 +1,50 @@ > > +Toshiba et8ek8 5MP sensor > > + > > +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device > > + > > +More detailed documentation can be found in > > +Documentation/devicetree/bindings/media/video-interfaces.txt . > > + > > + > > +Mandatory properties > > +-------------------- > > + > > +- compatible: "toshiba,et8ek8" > > +- reg: I2C address (0x3e, or an alternative address) > > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts > > > +- clocks: External clock to the sensor > > +- clock-frequency: Frequency of the external clock to the sensor > > These should be mutually-exclusive. If you have a clock, then you can > get the frequency at runtime. Yes, you can. But the intention is to set the frequency: the sensor requires a particular, pre-determined frequency. Typically this is specific to the board. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk