From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 12/14] drm: Move master pointer from drm_minor to drm_device Date: Wed, 15 Jun 2016 17:33:14 +0100 Message-ID: <20160615163314.GB6754@nuc-i3427.alporthouse.com> References: <1465930269-7883-1-git-send-email-daniel.vetter@ffwll.ch> <1465930269-7883-13-git-send-email-daniel.vetter@ffwll.ch> <20160615121035.GP4184@nuc-i3427.alporthouse.com> <20160615160141.GP1338@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160615160141.GP1338@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , Julia Lawall , DRI Development , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKdW4gMTUsIDIwMTYgYXQgMDY6MDE6NDFQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBXZWQsIEp1biAxNSwgMjAxNiBhdCAwMToxMDozNVBNICswMTAwLCBDaHJpcyBX aWxzb24gd3JvdGU6Cj4gPiBPbiBUdWUsIEp1biAxNCwgMjAxNiBhdCAwODo1MTowN1BNICswMjAw LCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4gPiBUaGVyZSBjYW4gb25seSBiZSBvbmUgY3VycmVu dCBtYXN0ZXIsIGFuZCBpdCdzIGZvciB0aGUgb3ZlcmFsbCBkZXZpY2UuCj4gPiA+IFJlbmRlci9j b250cm9sIG1pbm9ycyBkb24ndCBzdXBwb3J0IG1hc3Rlci1iYXNlZCBhdXRoIGF0IGFsbC4KPiA+ ID4gCj4gPiA+IFRoaXMgc2ltcGxpZmllcyB0aGUgbWFzdGVyIGxvZ2ljIGEgbG90LCBhdCBsZWFz dCBpbiBteSBleWVzOiBBbGwgdGhlc2UKPiA+ID4gYWRkaXRpb25hbCBwb2ludGVyIGNoYXNlcyBh cmUganVzdCBjb25mdXNpbmcuCj4gPiAKPiA+IE9uZSBtYXN0ZXIgZm9yIHRoZSBkZXZpY2UsIG9u IHRoZSBzdHJ1Y3QgZHJtX2RldmljZSwgYXMgb3Bwb3NlZCB0byBoaWRkZW4KPiA+IGJlaGluZCB0 aGUgZmlyc3Qgb2YgdGhyZWUgbWlub3JzLCBtYWtlcyBzZW5zZS4KPiA+IAo+ID4gPiBAQCAtMTI4 LDEzICsxMjgsMTMgQEAgc3RhdGljIGludCBkcm1fbmV3X3NldF9tYXN0ZXIoc3RydWN0IGRybV9k ZXZpY2UgKmRldiwgc3RydWN0IGRybV9maWxlICpmcHJpdikKPiA+ID4gIAlsb2NrZGVwX2Fzc2Vy dF9oZWxkX29uY2UoJmRldi0+bWFzdGVyX211dGV4KTsKPiA+ID4gIAo+ID4gPiAgCS8qIGNyZWF0 ZSBhIG5ldyBtYXN0ZXIgKi8KPiA+ID4gLQlmcHJpdi0+bWlub3ItPm1hc3RlciA9IGRybV9tYXN0 ZXJfY3JlYXRlKGZwcml2LT5taW5vci0+ZGV2KTsKPiA+ID4gLQlpZiAoIWZwcml2LT5taW5vci0+ bWFzdGVyKQo+ID4gPiArCWRldi0+bWFzdGVyID0gZHJtX21hc3Rlcl9jcmVhdGUoZGV2KTsKPiA+ ID4gKwlpZiAoIWRldi0+bWFzdGVyKQo+ID4gPiAgCQlyZXR1cm4gLUVOT01FTTsKPiA+ID4gIAo+ ID4gPiAgCS8qIHRha2UgYW5vdGhlciByZWZlcmVuY2UgZm9yIHRoZSBjb3B5IGluIHRoZSBsb2Nh bCBmaWxlIHByaXYgKi8KPiA+ID4gIAlvbGRfbWFzdGVyID0gZnByaXYtPm1hc3RlcjsKPiA+ID4g LQlmcHJpdi0+bWFzdGVyID0gZHJtX21hc3Rlcl9nZXQoZnByaXYtPm1pbm9yLT5tYXN0ZXIpOwo+ ID4gPiArCWZwcml2LT5tYXN0ZXIgPSBkcm1fbWFzdGVyX2dldChkZXYtPm1hc3Rlcik7Cj4gPiA+ ICAKPiA+ID4gIAlpZiAoZGV2LT5kcml2ZXItPm1hc3Rlcl9jcmVhdGUpIHsKPiA+ID4gIAkJcmV0 ID0gZGV2LT5kcml2ZXItPm1hc3Rlcl9jcmVhdGUoZGV2LCBmcHJpdi0+bWFzdGVyKTsKPiA+IAo+ ID4gPiBAQCAtMjM0LDEwICsyMzQsMTAgQEAgaW50IGRybV9tYXN0ZXJfb3BlbihzdHJ1Y3QgZHJt X2ZpbGUgKmZpbGVfcHJpdikKPiA+ID4gIAkvKiBpZiB0aGVyZSBpcyBubyBjdXJyZW50IG1hc3Rl ciBtYWtlIHRoaXMgZmQgaXQsIGJ1dCBkbyBub3QgY3JlYXRlCj4gPiA+ICAJICogYW55IG1hc3Rl ciBvYmplY3QgZm9yIHJlbmRlciBjbGllbnRzICovCj4gPiA+ICAJbXV0ZXhfbG9jaygmZGV2LT5t YXN0ZXJfbXV0ZXgpOwo+ID4gPiAtCWlmICghZmlsZV9wcml2LT5taW5vci0+bWFzdGVyKQo+ID4g PiArCWlmICghZGV2LT5tYXN0ZXIpCj4gPiA+ICAJCXJldCA9IGRybV9uZXdfc2V0X21hc3Rlcihk ZXYsIGZpbGVfcHJpdik7Cj4gPiA+ICAJZWxzZQo+ID4gPiAtCQlmaWxlX3ByaXYtPm1hc3RlciA9 IGRybV9tYXN0ZXJfZ2V0KGZpbGVfcHJpdi0+bWlub3ItPm1hc3Rlcik7Cj4gPiA+ICsJCWZpbGVf cHJpdi0+bWFzdGVyID0gZHJtX21hc3Rlcl9nZXQoZGV2LT5tYXN0ZXIpOwo+ID4gPiAgCW11dGV4 X3VubG9jaygmZGV2LT5tYXN0ZXJfbXV0ZXgpOwo+ID4gCj4gPiBZb3UgY291bGQgdGFrZSB0aGUg b3Bwb3J0dW5pdHkgdG8gbWFrZSB0aGlzIGEgYml0IHNpbXBsZXI6Cj4gPiAKPiA+IAlpZiAoIVJF QURfT05DRShkZXYtPm1hc3RlcikpIHsKPiA+IAkJaW50IHJldDsKPiA+IAo+ID4gCQlyZXQgPSAw Owo+ID4gCQltdXRleF9sb2NrKCZkZXYtPm1hc3Rlcl9tdXRleCk7Cj4gPiAJCWlmICghZGV2LT5t YXN0ZXIpCj4gPiAJCQlyZXQgPSBkcm1fbmV3X21hc3RlcihkZXYpOwo+ID4gCQltdXRleF91bmxv Y2soJmRldi0+bWFzdGVyX211dGV4KTsKPiA+IAkJaWYgKHJldCkKPiA+IAkJCXJldHVybiByZXQ7 Cj4gPiAJfQo+ID4gCj4gPiAJZmlsZV9wcml2LT5tYXN0ZXIgPSBkcm1fbWFzdGVyX2dldChkZXYt Pm1hc3Rlcik7Cj4gCj4gZHJtX21hc3Rlcl9nZXQoZGV2LT5tYXN0ZXIpIG11c3QgYmUgdW5kZXIg dGhlIG1hc3Rlcl9tdXRleCwgd2l0aG91dCBpdCB3ZQo+IGNvdWxkIHJhY2Ugd2l0aCBhIGRybV9t YXN0ZXJfcHV0KCZkZXYtPm1hc3RlcikgYW5kIGVuZCB1cCBkb2luZyBhIGtyZWZfZ2V0Cj4gd2hl biB0aGUgcmVmY291bnQgYWxyZWFkeSByZWFjaGVkIDAuCgpTb21ldGhpbmcgaXMgdmVyeSBmaXNo eSB0aGVuLiBUaGUgYmVoYXZpb3VyIG9mIGRybV9uZXdfbWFzdGVyKCkgd291bGQKYXBwZWFyIHRv IGJlIHRvIGNyZWF0ZSBhIGRybV9tYXN0ZXIgb3duZWQgYnkgdGhlIGRldmljZSwgYnV0IHJlYWxs eSBpdCBpcwpvd25lZCBieSBmaWxlX3ByaXY/CgoqIGNoZWNrcyBiYWNrIG9uIGRybV9tYXN0ZXIK ClNvIGRybV9tYXN0ZXIgaXMgdGhlIGF1dGhlbnRpY2F0aW9uIHN0cnVjdHVyZSB0aGF0IG5lZWRz IHRvIGJlIHVuaXF1ZSB0bwphIGhpZXJhY2h5LiBTbyBkcm1fbmV3X3NldF9tYXN0ZXIoKSBhbmQg aGVyZSByZWFsbHkgZG8gYXBwZWFyIGJhY2t3YXJkcy4KClRoZSBvbGQgZHJtX25ld19zZXRfbWFz dGVyKCkgbWFrZXMgbW9yZSBzZW5zZSwgaXQgYXNzaWducyB0byB0aGUKZmlsZV9wcml2LCBhbmQg dGhlbiBwZXJmb3JtcyBhIHNldG1hc3RlciBvcGVyYXRpb24uIEluIHRoYXQgb3JkZXJpbmcsCnlv dSBjb3VsZCBldmVuIGRvIHRoZSBmaWxlX3ByaXYgbG9jYWwgb3BlcmF0aW9uIG9mIGNyZWF0aW5n IHRoZSBuZXcKbWFzdGVyIHN0cnVjdHVyZSBiZWZvcmUgdGFraW5nIHRoZSBsb2NrIHRvIHBlcmZv cm0gc2V0bWFzdGVyLgoKCj4gPiBKdXN0IHRvIHN0cmFpZ2h0ZW4gb3V0IHRoZSBrcmVmIGRhbmNl Lgo+ID4gCj4gPiA+ICAKPiA+ID4gIAlyZXR1cm4gcmV0Owo+ID4gPiBAQCAtMjcxLDExICsyNzEs MTEgQEAgdm9pZCBkcm1fbWFzdGVyX3JlbGVhc2Uoc3RydWN0IGRybV9maWxlICpmaWxlX3ByaXYp Cj4gPiA+ICAJCW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ID4gPiAgCX0KPiA+ ID4gIAo+ID4gPiAtCWlmIChmaWxlX3ByaXYtPm1pbm9yLT5tYXN0ZXIgPT0gZmlsZV9wcml2LT5t YXN0ZXIpIHsKPiA+ID4gKwlpZiAoZGV2LT5tYXN0ZXIgPT0gZmlsZV9wcml2LT5tYXN0ZXIpIHsK PiA+ID4gIAkJLyogZHJvcCB0aGUgcmVmZXJlbmNlIGhlbGQgbXkgdGhlIG1pbm9yICovCj4gPiA+ ICAJCWlmIChkZXYtPmRyaXZlci0+bWFzdGVyX2Ryb3ApCj4gPiA+ICAJCQlkZXYtPmRyaXZlci0+ bWFzdGVyX2Ryb3AoZGV2LCBmaWxlX3ByaXYsIHRydWUpOwo+ID4gPiAtCQlkcm1fbWFzdGVyX3B1 dCgmZmlsZV9wcml2LT5taW5vci0+bWFzdGVyKTsKPiA+ID4gKwkJZHJtX21hc3Rlcl9wdXQoJmRl di0+bWFzdGVyKTsKPiA+IAo+ID4gVGhpcyBzdGlsbCBtYWtlcyBtZSB1bmVhc3kuIFRoaXMgaXMg bm90IGVxdWl2YWxlbnQgdG8gZHJvcG1hc3Rlcl9pb2N0bAo+ID4gYW5kIHN1YnNlcXVlbnQgc2V0 bWFzdGVyX2lvY3RsIHdpbGwgZmFpbCBhcyBkZXYtPm1hc3RlciBpcyBzdGlsbAo+ID4gYXNzaWdu ZWQgKGJ1dCB0aGUgb3duZXIgaGFzIGdvbmUpLgo+IAo+IGRybV9tYXN0ZXJfcHV0IGNsZWFycyB0 aGUgcG9pbnRlciBwYXNzZWQgdG8gaXQsIHNvIGRldi0+bWFzdGVyIHdpbGwgYmUgc2V0Cj4gdG8g TlVMTC4gQW5kIGl0IGRvZXMgdGhlIHNhbWUgYXMgZHJvcF9tYXN0ZXIgKHdydCBkZXYtPm1hc3Rl ciBhdCBsZWFzdCwKPiBtYXN0ZXJfcmVsZWFzZSBhbHNvIG5lZWRzIHRvIGNsZWFuIHVwIGZpbGVf cHJpdi0+bWFzdGVyIG9uIHRvcCkuIE5vdCBzdXJlCj4gaXQncyB3b3J0aCBpdCB0byBleHRyYWN0 IHRob3NlIDUgbGluZXMgaW50byBhIF9fZHJtX2Ryb3BfbWFzdGVyKCkgaGVscGVyCj4gZnVuY3Rp b24/IEkgY2FuIHJlc3BpbiB3aXRoIHRoYXQgaWYgeW91IHdhbnQuIE9uIHRoZSBtYXN0ZXJfb3Bl bi9zZXRtYXN0ZXIKPiBzaWRlIHRoZSBzaGFyZWQgY29kZSBpcyBhbHJlYWR5IGV4dHJhY3RlZCBp biBkcm1fbmV3X3NldF9tYXN0ZXIoKS4KCmRybV9tYXN0ZXJfcHV0KCkgbnVsbGlmaWVzLCBkaWRu J3QgZXhwZWN0IHRoYXQuCi1DaHJpcwoKLS0gCkNocmlzIFdpbHNvbiwgSW50ZWwgT3BlbiBTb3Vy Y2UgVGVjaG5vbG9neSBDZW50cmUKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==