From: Dave Chinner <david@fromorbit.com>
To: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH v3] shared: regression test for hang when processing corrupted orphaned inode list
Date: Thu, 16 Jun 2016 08:55:59 +1000 [thread overview]
Message-ID: <20160615225559.GH12670@dastard> (raw)
In-Reply-To: <1465968091-8912-1-git-send-email-fenggw-fnst@cn.fujitsu.com>
On Wed, Jun 15, 2016 at 01:21:31PM +0800, Guangwen Feng wrote:
> Commit c9eb13a fixed this bug:
> ext4: fix hang when processing corrupted orphaned inode list
Unfortunately, I don't know what this bug is, or what the test is
actually doing from this description or from reading the actual
test. Please assume that not just the reviewer but someone reading
this description 5 yers from now knows *nothing* about the problem
the test addresses. Hence the patch description needs to explain
more fully what the problem is that the test is exercising....
It's also unfortunate that kernel tree commits are being referenced
without saying what tree they belong to. i.e. this should read
"kernel commit ab1234cd" so we know that commit is not something
from the fstests tree, or e2fsprogs, or some other unknown tree.
Again - think about someone reading this in 5 years time and trying
to work out what it means...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-06-15 22:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 9:09 [PATCH] ext4: regression test for hang when processing corrupted orphaned inode list Guangwen Feng
2016-06-13 9:33 ` Eryu Guan
2016-06-13 10:15 ` Guangwen Feng
2016-06-14 2:31 ` Guangwen Feng
2016-06-14 2:58 ` [PATCH v2] shared: " Guangwen Feng
2016-06-14 4:39 ` Eryu Guan
2016-06-15 3:35 ` Eryu Guan
2016-06-15 3:43 ` Guangwen Feng
2016-06-15 5:21 ` [PATCH v3] " Guangwen Feng
2016-06-15 22:55 ` Dave Chinner [this message]
2016-06-16 3:41 ` [PATCH v4] " Guangwen Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615225559.GH12670@dastard \
--to=david@fromorbit.com \
--cc=fenggw-fnst@cn.fujitsu.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.