From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v5 02/38] bnxt: add HWRM init code Date: Thu, 16 Jun 2016 10:46:27 +0100 Message-ID: <20160616094627.GC11016@bricha3-MOBL3> References: <1465250923-78695-1-git-send-email-stephen.hurd@broadcom.com> <1465944971-113413-1-git-send-email-stephen.hurd@broadcom.com> <1465944971-113413-2-git-send-email-stephen.hurd@broadcom.com> <57618188.8090804@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ferruh Yigit , dev@dpdk.org, Ajit Kumar Khaparde To: Stephen Hurd Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 49430C50A for ; Thu, 16 Jun 2016 11:46:31 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 15, 2016 at 01:28:13PM -0700, Stephen Hurd wrote: > On Wed, Jun 15, 2016 at 9:25 AM, Ferruh Yigit > wrote: > > > > > Hi Stephen, > > > > I run basic checks on the patch set, mainly it compiles and applies > > fine, overall patch set looks good. > > > > Only get following checkpatch warning: > > Only v5,02/38 has one WARNING:MACRO_WITH_FLOW_CONTROL > > > > This is intentional, is this style of copy/paste avoidance not allowed? > It's fine. Some checkpatch exceptions like this are allowed when they make sense. Regards, /Bruce