All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: netdev@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
	Brett Rudley <brudley@broadcom.com>,
	Arend van Spriel <arend@broadcom.com>,
	"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
	Hante Meuleman <meuleman@broadcom.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	Johannes Berg <johannes.berg@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/8] wireless: brcmsmac: fix old-style declaration
Date: Thu, 16 Jun 2016 15:52:09 +0200	[thread overview]
Message-ID: <20160616135245.3198419-2-arnd@arndb.de> (raw)
In-Reply-To: <20160616135245.3198419-1-arnd@arndb.de>

Modern C standards expect the 'static' keyword to come first in a
declaration, and we get a warning for this with "make W=1":

drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c:3353:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
index e16ee60639f5..c2a938b59044 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
@@ -3349,8 +3349,8 @@ static void brcms_b_coreinit(struct brcms_c_info *wlc)
 	dma_rxfill(wlc_hw->di[RX_FIFO]);
 }
 
-void
-static brcms_b_init(struct brcms_hardware *wlc_hw, u16 chanspec) {
+static void brcms_b_init(struct brcms_hardware *wlc_hw, u16 chanspec)
+{
 	u32 macintmask;
 	bool fastclk;
 	struct brcms_c_info *wlc = wlc_hw->wlc;
-- 
2.9.0


  reply	other threads:[~2016-06-16 13:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 13:50 [PATCH 0/8] net: fix old-style declarations Arnd Bergmann
2016-06-16 13:52 ` [PATCH 1/8] wireless: airo: rename 'register' variable Arnd Bergmann
2016-06-16 13:52   ` Arnd Bergmann [this message]
2016-06-16 13:52   ` [PATCH 3/8] wireless: ipw2200: fix old-style declaration Arnd Bergmann
2016-06-24 17:46     ` Stanislav Yakovlev
2016-06-16 13:52   ` [PATCH 4/8] hamradio: baycom: " Arnd Bergmann
2016-06-17  5:06     ` David Miller
2016-06-16 13:52   ` [PATCH 5/8] isdn: eicon: fix old-style declarations Arnd Bergmann
2016-06-17  5:06     ` David Miller
2016-06-16 13:52   ` [PATCH 6/8] net: gianfar: fix old-style declaration Arnd Bergmann
2016-06-16 18:02     ` Sergei Shtylyov
2016-06-16 18:11       ` Joe Perches
2016-06-17  5:06     ` David Miller
2016-06-29 15:56   ` [1/8] wireless: airo: rename 'register' variable Kalle Valo
2016-06-29 15:56     ` Kalle Valo
2016-06-16 13:57 ` [PATCH 8/8] sunrpc: fix old-style declaration Arnd Bergmann
2016-06-16 13:59 ` [PATCH 7/8] net: xfrm: " Arnd Bergmann
2016-06-17  5:06   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160616135245.3198419-2-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=arend@broadcom.com \
    --cc=brcm80211-dev-list@broadcom.com \
    --cc=brudley@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=frankyl@broadcom.com \
    --cc=johannes.berg@intel.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=meuleman@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.