From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754942AbcFPOmQ (ORCPT ); Thu, 16 Jun 2016 10:42:16 -0400 Received: from down.free-electrons.com ([37.187.137.238]:49698 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753867AbcFPOmO (ORCPT ); Thu, 16 Jun 2016 10:42:14 -0400 Date: Thu, 16 Jun 2016 16:41:35 +0200 From: Boris Brezillon To: Thomas Gleixner Cc: Alexandre Belloni , Nicolas Ferre , Jean-Christophe Plagniol-Villard , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Lezcano Subject: Re: [PATCH 44/48] clocksource: atmel-pit: allow unselecting ATMEL_PIT Message-ID: <20160616164135.7d810a7b@bbrezillon> In-Reply-To: References: <1465596231-21766-1-git-send-email-alexandre.belloni@free-electrons.com> <1465596231-21766-45-git-send-email-alexandre.belloni@free-electrons.com> <20160611105351.GH19050@piout.net> <20160613210416.4fef01d2@bbrezillon> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thomas, On Mon, 13 Jun 2016 21:14:47 +0200 (CEST) Thomas Gleixner wrote: > On Mon, 13 Jun 2016, Boris Brezillon wrote: > > On Sat, 11 Jun 2016 12:53:51 +0200 > > Alexandre Belloni wrote: > > > > > On 11/06/2016 at 11:43:54 +0200, Thomas Gleixner wrote : > > > > On Sat, 11 Jun 2016, Alexandre Belloni wrote: > > > > > > > > > With the new TCB clocksource driver, atmel platforms are now able to boot > > > > > without the PIT driver. Allow unselecting it. > > > > > > > > Yay! Thanks for doing this! > > > > > > > > > > Sure! Can you still check the request_irq/free_irq in > > > timer-atmel-tcbclksrc? I'm not sure whether this can work reliably or > > > only because we are before SYSTEM_STATE=RUNNING. > > > In the latter case, I have another way of doing that. > > > > > > > Sorry to put it back on the table, but shouldn't we consider adding > > these irq_disable/enable_action() helpers? > > I fear that's the only reliable way to do it. Alexandre told me you had a better implementation (or idea, I don't remember) than what was proposed here [1]. Do you plan to submit something, or should we work on it? Regards, Boris [1]https://lkml.org/lkml/2015/8/3/330 -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@free-electrons.com (Boris Brezillon) Date: Thu, 16 Jun 2016 16:41:35 +0200 Subject: [PATCH 44/48] clocksource: atmel-pit: allow unselecting ATMEL_PIT In-Reply-To: References: <1465596231-21766-1-git-send-email-alexandre.belloni@free-electrons.com> <1465596231-21766-45-git-send-email-alexandre.belloni@free-electrons.com> <20160611105351.GH19050@piout.net> <20160613210416.4fef01d2@bbrezillon> Message-ID: <20160616164135.7d810a7b@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Thomas, On Mon, 13 Jun 2016 21:14:47 +0200 (CEST) Thomas Gleixner wrote: > On Mon, 13 Jun 2016, Boris Brezillon wrote: > > On Sat, 11 Jun 2016 12:53:51 +0200 > > Alexandre Belloni wrote: > > > > > On 11/06/2016 at 11:43:54 +0200, Thomas Gleixner wrote : > > > > On Sat, 11 Jun 2016, Alexandre Belloni wrote: > > > > > > > > > With the new TCB clocksource driver, atmel platforms are now able to boot > > > > > without the PIT driver. Allow unselecting it. > > > > > > > > Yay! Thanks for doing this! > > > > > > > > > > Sure! Can you still check the request_irq/free_irq in > > > timer-atmel-tcbclksrc? I'm not sure whether this can work reliably or > > > only because we are before SYSTEM_STATE=RUNNING. > > > In the latter case, I have another way of doing that. > > > > > > > Sorry to put it back on the table, but shouldn't we consider adding > > these irq_disable/enable_action() helpers? > > I fear that's the only reliable way to do it. Alexandre told me you had a better implementation (or idea, I don't remember) than what was proposed here [1]. Do you plan to submit something, or should we work on it? Regards, Boris [1]https://lkml.org/lkml/2015/8/3/330 -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com