From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754672AbcFPU0p (ORCPT ); Thu, 16 Jun 2016 16:26:45 -0400 Received: from mga04.intel.com ([192.55.52.120]:41594 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752815AbcFPU0o (ORCPT ); Thu, 16 Jun 2016 16:26:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,481,1459839600"; d="scan'208";a="999226280" Date: Thu, 16 Jun 2016 22:26:41 +0200 From: Jarkko Sakkinen To: Ed Swierk Cc: tpmdd-devel@lists.sourceforge.net, stefanb@us.ibm.com, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, jgunthorpe@obsidianresearch.com Subject: Re: [PATCH v6 4/5] tpm: Allow TPM chip drivers to override reported command durations Message-ID: <20160616202641.GC1414@intel.com> References: <1465426818-89356-1-git-send-email-eswierk@skyportsystems.com> <1465610107-87762-1-git-send-email-eswierk@skyportsystems.com> <1465610107-87762-5-git-send-email-eswierk@skyportsystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465610107-87762-5-git-send-email-eswierk@skyportsystems.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 10, 2016 at 06:55:06PM -0700, Ed Swierk wrote: > Some TPM chips report bogus command durations in their capabilities, > just as others report incorrect timeouts. Rework tpm_get_timeouts() to > allow chip drivers to override either via a single callback. Also > clean up handling of TPMs that report milliseconds instead of > microseconds. > > Signed-off-by: Ed Swierk Again, LGTM but have to test :) > --- > drivers/char/tpm/tpm-interface.c | 139 +++++++++++++++++++++------------------ > drivers/char/tpm/tpm_tis.c | 35 +++------- > include/linux/tpm.h | 3 +- > 3 files changed, 85 insertions(+), 92 deletions(-) /Jarkko