All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Woithe <jwoithe@just42.net>
To: Jan-Marek Glogowski <glogow@fbihome.de>
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: Brightness and "touchpad dis-/enable" keys not working for Fujitsu e7x6
Date: Fri, 17 Jun 2016 09:16:30 +0930	[thread overview]
Message-ID: <20160616234630.GB4764@marvin.atrad.com.au> (raw)
In-Reply-To: <575FC4E0.7080501@fbihome.de>

Hi Jan-Marek

On Tue, Jun 14, 2016 at 10:48:32AM +0200, Jan-Marek Glogowski wrote:
> I recently got new Skylake hardware (e7x6) from Fujitsu. Compared to
> previous Haswell generation (e7x4), some of the Fn+X key combination
> stopped working. This includes the brightness and "touchpad dis-/enable"
> key combinations.
> 
> For the brightness control it's understandable, as this was handled by a
> ACPI device FUJ02B1, which is no longer available.

I see.  Perhaps they've rolled this functionality into FUJ02E3 (which
previously has handled everything except brightness control).

> I don't know how the touchpad disable key was actually working, as I don't
> get any scan codes or ACPI events in userspace - probably I'm missing
> something here.

Maybe on the previous hardware generation the touchpad keys were controlled
solely in hardware, and for some reason they've moved them to software in
the latest generation.

> I compiled the git fujitsu-notebook driver ...

I assume this was "fujitsu-laptop".

> ... can see ACPI notifications when any of the non-working combination is
> pressed like:
> 
> [  408.997023] FUJ02B1: call_fext_func: FUNC 0x1000 (args 0x4, 0x0, 0x0)
> returned 0x100
> [  408.997072] FUJ02B1: call_fext_func: FUNC 0x1002 (args 0x1, 0x0, 0x0)
> returned 0x0
> 
> so these button states seems to be handled differently then all the
> other buttons. (FUNC 0x1002 is used to check the special button states).

For clarity, which buttons are the "non-working combinations"?  Is it just
the brightness/touchpad buttons, or are there others which are behaving
similarly?

> BTW: the debug message is a little misleading, as all of them are prefixed
> 'FUJ02B1', even if the ACPI event is handled by the FUJ02E3 device.

Yes, good point.  The use of "FUJ02B1" (via ACPI_FUJITSU_HID) would have
been for convenience and possibly dates from before FUJ02E3 support was
included in the driver.  A case can certainly be made for a more generic
descriptor.

> I checked the DSTD from the old and new HW. The size has more then
> duplicated (414k => 955k) with a 43k diff. The diff for the FUJ02E3
> device is just 356 lines, but I couldn't identify anything, which might
> relate to the keys.

Perhaps they've introduced a new backlight control device with a different
HID (except you mentioned that only FUJ02E3 was listed even on other OSes,
so I guess this is unlikely).

> Any help would be appreciated to get this fixed.

I don't have access to any of the newer Fujitsu hardware so I can't do much
in relation to debugging the problem.  Obviously the buttons concerned
generate ACPI notifications.  Without a FUJ02B1 and any obvious extension 
to FUJ02E3, my only thought at present is that they've taken backlight
control out of ACPI (that is, based on the ACPI button notification they
poke other hardware to effect the brightness control).  It does seem a bit
odd though.

In any case, we'd have to identify what is meant to be done (and what is
done under other OSes) in reponse to these buttons.

I assume that the brightness buttons don't do anything when fujitsu-laptop
is unloaded?  I'm wondering whether the standard backlight driver might be
operational on this hardware.

Regards
  jonathan

  reply	other threads:[~2016-06-17  0:16 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14  8:48 Brightness and "touchpad dis-/enable" keys not working for Fujitsu e7x6 Jan-Marek Glogowski
2016-06-16 23:46 ` Jonathan Woithe [this message]
2016-06-17  9:20   ` Jan-Marek Glogowski
2016-06-21  8:12     ` Jonathan Woithe
2016-06-22  7:32       ` Michał Kępień
2016-06-22 10:18         ` Jan-Marek Glogowski
2016-06-22 10:53           ` Jonathan Woithe
2016-06-22 11:23             ` Jan-Marek Glogowski
2016-06-22 12:39               ` Michał Kępień
2016-06-22 13:22                 ` Jan-Marek Glogowski
2016-06-23 11:18                   ` Michał Kępień
2016-06-23 12:08                     ` Jan-Marek Glogowski
2016-06-23 12:35                       ` Michał Kępień
2016-06-23 13:17                         ` Jan-Marek Glogowski
2016-06-23 13:31                           ` Michał Kępień
2016-06-23 13:42                             ` Jan-Marek Glogowski
2016-06-23 17:23                         ` Jan-Marek Glogowski
2016-06-24  7:12                           ` Michał Kępień
2016-06-24  9:22                             ` Jan-Marek Glogowski
2016-06-24 10:20                               ` Michał Kępień
2016-06-24 11:39                                 ` Jan-Marek Glogowski
2016-06-24 15:43                                 ` Jan-Marek Glogowski
2016-06-24 20:17                                   ` Michał Kępień
2016-06-25  8:50                                     ` Jonathan Woithe
2016-06-25  9:15                                       ` Michał Kępień
2016-06-26  7:41                                         ` [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models Michał Kępień
2016-06-27  8:03                                           ` [PATCH] Register KEY_TOUCHPAD_TOGGLE with input device Jan-Marek Glogowski
2016-06-27 12:48                                           ` [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models Jonathan Woithe
2016-06-27 12:55                                             ` Michał Kępień
2016-06-27 13:19                                             ` [PATCH v2] " Michał Kępień
2016-06-28  1:06                                               ` Jonathan Woithe
2016-06-28  7:25                                                 ` [PATCH v3] " Michał Kępień
2016-06-28 11:19                                                   ` Jonathan Woithe
2016-06-28 17:50                                                     ` Darren Hart
2016-06-27  8:32                                         ` Brightness and "touchpad dis-/enable" keys not working for Fujitsu e7x6 Jan-Marek Glogowski
2016-06-27 11:16                                           ` Michał Kępień
2016-06-27 11:40                                             ` Jan-Marek Glogowski
2016-06-27 12:40                                               ` Jonathan Woithe
2016-06-29 13:59                                           ` Jani Nikula
2016-06-29 15:38                                             ` Jani Nikula
2016-06-22 10:46         ` Jonathan Woithe
2016-06-23 10:02   ` [PATCH 0/2] fujitsu-laptop: Debugging cleanup Michał Kępień
2016-06-23 10:02     ` [PATCH 1/2] fujitsu-laptop: Use module name in debug messages Michał Kępień
2016-06-23 10:02     ` [PATCH 2/2] fujitsu-laptop: Remove unused macros Michał Kępień
2016-06-23 10:35     ` [PATCH 0/2] fujitsu-laptop: Debugging cleanup Jonathan Woithe
2016-06-28 17:49       ` Darren Hart
2016-06-22  7:15 ` Brightness and "touchpad dis-/enable" keys not working for Fujitsu e7x6 Michał Kępień
2016-06-22 10:07   ` Jan-Marek Glogowski
2016-06-22 11:31     ` Michał Kępień

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160616234630.GB4764@marvin.atrad.com.au \
    --to=jwoithe@just42.net \
    --cc=glogow@fbihome.de \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.