From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755283AbcFQH0f (ORCPT ); Fri, 17 Jun 2016 03:26:35 -0400 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:34743 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbcFQH0e (ORCPT ); Fri, 17 Jun 2016 03:26:34 -0400 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: iamjoonsoo.kim@lge.com X-Original-SENDERIP: 10.177.222.138 X-Original-MAILFROM: iamjoonsoo.kim@lge.com Date: Fri, 17 Jun 2016 16:28:48 +0900 From: Joonsoo Kim To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , dri-devel@lists.freedesktop.org, Hugh Dickins , John Einar Reitan , Jonathan Corbet , Konstantin Khlebnikov , Mel Gorman , Naoya Horiguchi , Rafael Aquini , Rik van Riel , Sergey Senozhatsky , virtualization@lists.linux-foundation.org, Gioh Kim , Chan Gyun Jeong , Sangseok Lee , Kyeongdon Kim , Chulmin Kim Subject: Re: [PATCH v7 00/12] Support non-lru page migration Message-ID: <20160617072848.GC810@js1304-P5Q-DELUXE> References: <20160615075909.GA425@swordfish> <20160615231248.GI17127@bbox> <20160616024827.GA497@swordfish> <20160616025800.GO17127@bbox> <20160616042343.GA516@swordfish> <20160616044710.GP17127@bbox> <20160616052209.GB516@swordfish> <20160616064753.GR17127@bbox> <20160616084211.GA432@swordfish> <20160616100932.GS17127@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160616100932.GS17127@bbox> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 16, 2016 at 07:09:32PM +0900, Minchan Kim wrote: > On Thu, Jun 16, 2016 at 05:42:11PM +0900, Sergey Senozhatsky wrote: > > On (06/16/16 15:47), Minchan Kim wrote: > > > > [..] > > > > > > this is what I'm getting with the [zsmalloc: keep first object offset in struct page] > > > > > > applied: "count:0 mapcount:-127". which may be not related to zsmalloc at this point. > > > > > > > > > > > > kernel: BUG: Bad page state in process khugepaged pfn:101db8 > > > > > > kernel: page:ffffea0004076e00 count:0 mapcount:-127 mapping: (null) index:0x1 > > > > > > > > > > Hm, it seems double free. > > > > > > > > > > It doen't happen if you disable zram? IOW, it seems to be related > > > > > zsmalloc migration? > > > > > > > > need to test more, can't confidently answer now. > > > > > > > > > How easy can you reprodcue it? Could you bisect it? > > > > > > > > it takes some (um.. random) time to trigger the bug. > > > > I'll try to come up with more details. > > > > > > Could you revert [1] and retest? > > > > > > [1] mm/compaction: split freepages without holding the zone lock > > > > ok, so this is not related to zsmalloc. finally manged to reproduce > > it. will fork a separate thread. > > The reason I mentioned [1] is that it seems to have a bug. > > isolate_freepages_block > __isolate_free_page > if(!zone_watermark_ok()) > return 0; > list_add_tail(&page->lru, freelist); > > However, the page is not isolated. > Joonsoo? Good job! I will fix it soon. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f200.google.com (mail-io0-f200.google.com [209.85.223.200]) by kanga.kvack.org (Postfix) with ESMTP id 1994C6B0005 for ; Fri, 17 Jun 2016 03:26:34 -0400 (EDT) Received: by mail-io0-f200.google.com with SMTP id l5so155004409ioa.0 for ; Fri, 17 Jun 2016 00:26:34 -0700 (PDT) Received: from lgeamrelo12.lge.com (LGEAMRELO12.lge.com. [156.147.23.52]) by mx.google.com with ESMTP id d194si4671721ith.69.2016.06.17.00.26.32 for ; Fri, 17 Jun 2016 00:26:33 -0700 (PDT) Date: Fri, 17 Jun 2016 16:28:48 +0900 From: Joonsoo Kim Subject: Re: [PATCH v7 00/12] Support non-lru page migration Message-ID: <20160617072848.GC810@js1304-P5Q-DELUXE> References: <20160615075909.GA425@swordfish> <20160615231248.GI17127@bbox> <20160616024827.GA497@swordfish> <20160616025800.GO17127@bbox> <20160616042343.GA516@swordfish> <20160616044710.GP17127@bbox> <20160616052209.GB516@swordfish> <20160616064753.GR17127@bbox> <20160616084211.GA432@swordfish> <20160616100932.GS17127@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160616100932.GS17127@bbox> Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , dri-devel@lists.freedesktop.org, Hugh Dickins , John Einar Reitan , Jonathan Corbet , Konstantin Khlebnikov , Mel Gorman , Naoya Horiguchi , Rafael Aquini , Rik van Riel , Sergey Senozhatsky , virtualization@lists.linux-foundation.org, Gioh Kim , Chan Gyun Jeong , Sangseok Lee , Kyeongdon Kim , Chulmin Kim On Thu, Jun 16, 2016 at 07:09:32PM +0900, Minchan Kim wrote: > On Thu, Jun 16, 2016 at 05:42:11PM +0900, Sergey Senozhatsky wrote: > > On (06/16/16 15:47), Minchan Kim wrote: > > > > [..] > > > > > > this is what I'm getting with the [zsmalloc: keep first object offset in struct page] > > > > > > applied: "count:0 mapcount:-127". which may be not related to zsmalloc at this point. > > > > > > > > > > > > kernel: BUG: Bad page state in process khugepaged pfn:101db8 > > > > > > kernel: page:ffffea0004076e00 count:0 mapcount:-127 mapping: (null) index:0x1 > > > > > > > > > > Hm, it seems double free. > > > > > > > > > > It doen't happen if you disable zram? IOW, it seems to be related > > > > > zsmalloc migration? > > > > > > > > need to test more, can't confidently answer now. > > > > > > > > > How easy can you reprodcue it? Could you bisect it? > > > > > > > > it takes some (um.. random) time to trigger the bug. > > > > I'll try to come up with more details. > > > > > > Could you revert [1] and retest? > > > > > > [1] mm/compaction: split freepages without holding the zone lock > > > > ok, so this is not related to zsmalloc. finally manged to reproduce > > it. will fork a separate thread. > > The reason I mentioned [1] is that it seems to have a bug. > > isolate_freepages_block > __isolate_free_page > if(!zone_watermark_ok()) > return 0; > list_add_tail(&page->lru, freelist); > > However, the page is not isolated. > Joonsoo? Good job! I will fix it soon. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org