From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDt4M-0005SZ-Iv for qemu-devel@nongnu.org; Fri, 17 Jun 2016 08:40:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDt4J-0000Zn-E9 for qemu-devel@nongnu.org; Fri, 17 Jun 2016 08:40:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDt4J-0000ZH-8j for qemu-devel@nongnu.org; Fri, 17 Jun 2016 08:40:15 -0400 Date: Fri, 17 Jun 2016 18:10:11 +0530 From: Amit Shah Message-ID: <20160617124011.GC22759@grmbl.mre> References: <1466157348-14488-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466157348-14488-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] scsi: esp: remove handling of SATN/STOP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, =?iso-8859-1?Q?Herv=E9?= Poussineau , ppandit@redhat.com On (Fri) 17 Jun 2016 [11:55:48], Paolo Bonzini wrote: > The implementation of SATN/STOP is completely busted. The idea > would be that the next DMA read is for a SCSI message and after > that the adapter would transition to the command phase. > > The recent fix to SATN/STOP broke migration, which is one more > reason to drop SATN/STOP handling completely. It is only used > in practice to send 3-byte messages (target number + tag type > + tag number) for tagged command queuing on adapters that lack > the SATN3 command, and we do not advertise support for TCQ. > > Signed-off-by: Paolo Bonzini Thanks, the vmstate bits are fine. Amit