From: Stephen Hemminger <stephen@networkplumber.org>
To: Simon Kagstrom <simon.kagstrom@netinsight.net>
Cc: olivier.matz@6wind.com, dev@dpdk.org
Subject: Re: PATCH] mbuf: rte_pktmbuf_dump: don't add 0x when using %p in format strings
Date: Mon, 20 Jun 2016 09:19:40 -0700 [thread overview]
Message-ID: <20160620091940.75a37c54@xeon-e3> (raw)
In-Reply-To: <20160620124435.23d43f28@miho>
On Mon, 20 Jun 2016 12:44:35 +0200
Simon Kagstrom <simon.kagstrom@netinsight.net> wrote:
> I.e., avoid dump messages with double 0x0x, e.g.,
>
> dump mbuf at 0x0x7fac7b17c800, phys=17b17c880, buf_len=2176
> pkt_len=2064, ol_flags=0, nb_segs=1, in_port=255
> segment at 0x0x7fac7b17c800, data=0x0x7fac7b17c8f0, data_len=2064
>
> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Agreed. Many other places have same glitch.
$ git grep '0x%p'
drivers/net/vmxnet3/vmxnet3_rxtx.c: "RXQ: cmd0 base : 0x%p cmd1 base : 0x%p comp ring base : 0x%p.",
drivers/net/vmxnet3/vmxnet3_rxtx.c: PMD_TX_LOG(DEBUG, "TXQ: cmd base : 0x%p comp ring base : 0x%p data ring base : 0x%p.",
lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_ethtool.c: printk(KERN_DEBUG "ixgbe_get_regs_2 0x%p\n", hw->hw_addr);
lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("tx_phys: 0x%016llx, tx_q addr: 0x%p\n",
lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("rx_phys: 0x%016llx, rx_q addr: 0x%p\n",
lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("alloc_phys: 0x%016llx, alloc_q addr: 0x%p\n",
lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("free_phys: 0x%016llx, free_q addr: 0x%p\n",
lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("req_phys: 0x%016llx, req_q addr: 0x%p\n",
lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("resp_phys: 0x%016llx, resp_q addr: 0x%p\n",
lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("mbuf_phys: 0x%016llx, mbuf_kva: 0x%p\n",
lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_PRINT("mbuf_va: 0x%p\n", dev_info.mbuf_va);
lib/librte_eal/linuxapp/kni/kni_misc.c: KNI_DBG("PCI found: pci=0x%p, lad_dev=0x%p\n",
lib/librte_mbuf/rte_mbuf.c: fprintf(f, "dump mbuf at 0x%p, phys=%"PRIx64", buf_len=%u\n",
lib/librte_mbuf/rte_mbuf.c: fprintf(f, " segment at 0x%p, data=0x%p, data_len=%u\n",
next prev parent reply other threads:[~2016-06-20 16:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 10:44 PATCH] mbuf: rte_pktmbuf_dump: don't add 0x when using %p in format strings Simon Kagstrom
2016-06-20 16:19 ` Stephen Hemminger [this message]
2016-06-21 13:11 ` Ferruh Yigit
2016-06-22 7:08 ` Simon Kågström
2016-06-23 10:52 ` [PATCH] vmxnet3: remove 0x prefix for %p format Ferruh Yigit
2016-06-23 20:45 ` Yong Wang
2016-06-24 16:44 ` Bruce Richardson
2016-06-23 10:58 ` PATCH] mbuf: rte_pktmbuf_dump: don't add 0x when using %p in format strings Ferruh Yigit
2016-06-23 21:26 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620091940.75a37c54@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=simon.kagstrom@netinsight.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.