From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH v3 1/2] mempool: add stack (lifo) mempool handler Date: Mon, 20 Jun 2016 18:55:07 +0530 Message-ID: <20160620132506.GA3301@localhost.localdomain> References: <1463669335-30378-1-git-send-email-david.hunt@intel.com> <1466428091-115821-1-git-send-email-david.hunt@intel.com> <1466428091-115821-2-git-send-email-david.hunt@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: , , , To: David Hunt Return-path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0086.outbound.protection.outlook.com [157.56.111.86]) by dpdk.org (Postfix) with ESMTP id 3ADAA7F14 for ; Mon, 20 Jun 2016 15:25:28 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1466428091-115821-2-git-send-email-david.hunt@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 20, 2016 at 02:08:10PM +0100, David Hunt wrote: > This is a mempool handler that is useful for pipelining apps, where > the mempool cache doesn't really work - example, where we have one > core doing rx (and alloc), and another core doing Tx (and return). In > such a case, the mempool ring simply cycles through all the mbufs, > resulting in a LLC miss on every mbuf allocated when the number of > mbufs is large. A stack recycles buffers more effectively in this > case. > > Signed-off-by: David Hunt > --- > lib/librte_mempool/Makefile | 1 + > lib/librte_mempool/rte_mempool_stack.c | 145 +++++++++++++++++++++++++++++++++ How about moving new mempool handlers to drivers/mempool? (or similar). In future, adding HW specific handlers in lib/librte_mempool/ may be bad idea. Jerin