From mboxrd@z Thu Jan 1 00:00:00 1970 From: panand@redhat.com (Pratyush Anand) Date: Tue, 21 Jun 2016 11:41:28 +0530 Subject: [PATCH 0/2] Simple fix to the ARM kexec tools implementation In-Reply-To: <20160617194405.GN1041@n2100.armlinux.org.uk> References: <20160617194405.GN1041@n2100.armlinux.org.uk> Message-ID: <20160621061128.GC29309@dhcppc9> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 17/06/2016:08:44:05 PM, Russell King - ARM Linux wrote: > This is the "simple" fix for the ARM kexec tools code, which makes > the code actually do what the comments describe. > > There are two problems: > > 1. When placing the initrd, we do not take account of the 32k offset > that is required for the kernel image. > > 2. The code claims to allow the zImage decompressor to expand by a > factor of 4, but only allows space for a factor of 3, since the > decompressor itself has to fit in this memory space as well. > > Changing the code to follow the comments allows Keystone II to kexec > with DEBUG_RODATA enabled, at least with the kernel I've been testing > with. > > This is a stop-gap solution until a better solution can be implemented. Yes, so until we have proper header for zImage, these patches looks fine to me. For both of the patches: Reviewed-by: Pratyush Anand > > kexec/arch/arm/kexec-zImage-arm.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-qk0-f180.google.com ([209.85.220.180]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bFEug-0006Sd-AF for kexec@lists.infradead.org; Tue, 21 Jun 2016 06:11:55 +0000 Received: by mail-qk0-f180.google.com with SMTP id c73so7879423qkg.2 for ; Mon, 20 Jun 2016 23:11:33 -0700 (PDT) Date: Tue, 21 Jun 2016 11:41:28 +0530 From: Pratyush Anand Subject: Re: [PATCH 0/2] Simple fix to the ARM kexec tools implementation Message-ID: <20160621061128.GC29309@dhcppc9> References: <20160617194405.GN1041@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160617194405.GN1041@n2100.armlinux.org.uk> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Russell King - ARM Linux Cc: Simon Horman , kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Baoquan He , Kees Cook On 17/06/2016:08:44:05 PM, Russell King - ARM Linux wrote: > This is the "simple" fix for the ARM kexec tools code, which makes > the code actually do what the comments describe. > > There are two problems: > > 1. When placing the initrd, we do not take account of the 32k offset > that is required for the kernel image. > > 2. The code claims to allow the zImage decompressor to expand by a > factor of 4, but only allows space for a factor of 3, since the > decompressor itself has to fit in this memory space as well. > > Changing the code to follow the comments allows Keystone II to kexec > with DEBUG_RODATA enabled, at least with the kernel I've been testing > with. > > This is a stop-gap solution until a better solution can be implemented. Yes, so until we have proper header for zImage, these patches looks fine to me. For both of the patches: Reviewed-by: Pratyush Anand > > kexec/arch/arm/kexec-zImage-arm.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec