From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752004AbcFVDYd (ORCPT ); Tue, 21 Jun 2016 23:24:33 -0400 Received: from mail-yw0-f193.google.com ([209.85.161.193]:33742 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751804AbcFVDYb (ORCPT ); Tue, 21 Jun 2016 23:24:31 -0400 Date: Tue, 21 Jun 2016 15:49:04 -0500 From: Rob Herring To: Andrey Smirnov Cc: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options Message-ID: <20160621204904.GA9779@rob-hp-laptop> References: <1465970379-14703-1-git-send-email-andrew.smirnov@gmail.com> <1465970379-14703-4-git-send-email-andrew.smirnov@gmail.com> <20160619142934.GA8522@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 19, 2016 at 11:12:55AM -0700, Andrey Smirnov wrote: > On Sun, Jun 19, 2016 at 7:29 AM, Rob Herring wrote: > > On Tue, Jun 14, 2016 at 10:59:29PM -0700, Andrey Smirnov wrote: > >> Add DS1341 specific power-saving options that allow to disable certain > >> functional aspects of the chip in order to minimize its power > >> consumption. > > > > This description doesn't match that you are adding a new binding. It is > > preferred that bindings are a separate patch. > > OK, will split this patch into two in v2. > > > > >> > >> Signed-off-by: Andrey Smirnov > >> --- > >> .../devicetree/bindings/rtc/dallas,ds1341.txt | 23 ++++++++++++++++++ > >> drivers/rtc/rtc-ds1307.c | 28 ++++++++++++++++++++++ > >> 2 files changed, 51 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/rtc/dallas,ds1341.txt > >> > >> diff --git a/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt b/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt > >> new file mode 100644 > >> index 0000000..b8be7a4 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt > >> @@ -0,0 +1,23 @@ > >> +* Dallas DS1341 I2C Serial Real-Time Clock > >> + > >> +Required properties: > >> + > >> +- compatible: Should contain "dallas,ds1341". > >> + > >> +- reg: I2C address for chip > >> + > >> +Optional properties: > >> + > >> +- disable-oscillator-stop-flag : Configure chip to disable oscillator > >> + fault detection circuitry > >> + > >> +- enable-glitch-filter : Configure chip to enable crystal oscillator > >> + output glitch filtering > > > > What determines setting these properties or not? > > Setting those properties allows drastically reduce RTC's power > consumption at the expense of reliability and quality of service. In > my use case, DS1341 is powered by a supercap and enabling those two > setting allows to increase holdup from less than a day do 2+ weeks. So wouldn't you want to set one mode while running and the lower power mode while suspended? I'm trying to understand the frequency of changing this. If it is always one setting for a board, then yes it belongs in DT. If it is a user decision, then it probably shouldn't be in DT. Seeing as these are reused, I've probably already had this discussion... > > They should have vendor prefix and be explicit that they are boolean. > > I was trying to be consistent with ds1339 and ds1390 bindings which do > not have vendor prefixes. Will fix in v2. Okay, then they are fine if you are using existing properties. Perhaps these should all be in a common binding doc though. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail-yw0-f194.google.com (mail-yw0-f194.google.com. [209.85.161.194]) by gmr-mx.google.com with ESMTPS id n132si1232862ywb.1.2016.06.21.13.49.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Jun 2016 13:49:06 -0700 (PDT) Received: by mail-yw0-f194.google.com with SMTP id v77so3498439ywg.2 for ; Tue, 21 Jun 2016 13:49:06 -0700 (PDT) Date: Tue, 21 Jun 2016 15:49:04 -0500 From: Rob Herring To: Andrey Smirnov Cc: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [rtc-linux] Re: [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options Message-ID: <20160621204904.GA9779@rob-hp-laptop> References: <1465970379-14703-1-git-send-email-andrew.smirnov@gmail.com> <1465970379-14703-4-git-send-email-andrew.smirnov@gmail.com> <20160619142934.GA8522@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Sun, Jun 19, 2016 at 11:12:55AM -0700, Andrey Smirnov wrote: > On Sun, Jun 19, 2016 at 7:29 AM, Rob Herring wrote: > > On Tue, Jun 14, 2016 at 10:59:29PM -0700, Andrey Smirnov wrote: > >> Add DS1341 specific power-saving options that allow to disable certain > >> functional aspects of the chip in order to minimize its power > >> consumption. > > > > This description doesn't match that you are adding a new binding. It is > > preferred that bindings are a separate patch. > > OK, will split this patch into two in v2. > > > > >> > >> Signed-off-by: Andrey Smirnov > >> --- > >> .../devicetree/bindings/rtc/dallas,ds1341.txt | 23 ++++++++++++++++++ > >> drivers/rtc/rtc-ds1307.c | 28 ++++++++++++++++++++++ > >> 2 files changed, 51 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/rtc/dallas,ds1341.txt > >> > >> diff --git a/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt b/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt > >> new file mode 100644 > >> index 0000000..b8be7a4 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt > >> @@ -0,0 +1,23 @@ > >> +* Dallas DS1341 I2C Serial Real-Time Clock > >> + > >> +Required properties: > >> + > >> +- compatible: Should contain "dallas,ds1341". > >> + > >> +- reg: I2C address for chip > >> + > >> +Optional properties: > >> + > >> +- disable-oscillator-stop-flag : Configure chip to disable oscillator > >> + fault detection circuitry > >> + > >> +- enable-glitch-filter : Configure chip to enable crystal oscillator > >> + output glitch filtering > > > > What determines setting these properties or not? > > Setting those properties allows drastically reduce RTC's power > consumption at the expense of reliability and quality of service. In > my use case, DS1341 is powered by a supercap and enabling those two > setting allows to increase holdup from less than a day do 2+ weeks. So wouldn't you want to set one mode while running and the lower power mode while suspended? I'm trying to understand the frequency of changing this. If it is always one setting for a board, then yes it belongs in DT. If it is a user decision, then it probably shouldn't be in DT. Seeing as these are reused, I've probably already had this discussion... > > They should have vendor prefix and be explicit that they are boolean. > > I was trying to be consistent with ds1339 and ds1390 bindings which do > not have vendor prefixes. Will fix in v2. Okay, then they are fine if you are using existing properties. Perhaps these should all be in a common binding doc though. Rob -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options Date: Tue, 21 Jun 2016 15:49:04 -0500 Message-ID: <20160621204904.GA9779@rob-hp-laptop> References: <1465970379-14703-1-git-send-email-andrew.smirnov@gmail.com> <1465970379-14703-4-git-send-email-andrew.smirnov@gmail.com> <20160619142934.GA8522@rob-hp-laptop> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Andrey Smirnov Cc: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Alessandro Zummo , Alexandre Belloni , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Sun, Jun 19, 2016 at 11:12:55AM -0700, Andrey Smirnov wrote: > On Sun, Jun 19, 2016 at 7:29 AM, Rob Herring wrote: > > On Tue, Jun 14, 2016 at 10:59:29PM -0700, Andrey Smirnov wrote: > >> Add DS1341 specific power-saving options that allow to disable certain > >> functional aspects of the chip in order to minimize its power > >> consumption. > > > > This description doesn't match that you are adding a new binding. It is > > preferred that bindings are a separate patch. > > OK, will split this patch into two in v2. > > > > >> > >> Signed-off-by: Andrey Smirnov > >> --- > >> .../devicetree/bindings/rtc/dallas,ds1341.txt | 23 ++++++++++++++++++ > >> drivers/rtc/rtc-ds1307.c | 28 ++++++++++++++++++++++ > >> 2 files changed, 51 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/rtc/dallas,ds1341.txt > >> > >> diff --git a/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt b/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt > >> new file mode 100644 > >> index 0000000..b8be7a4 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt > >> @@ -0,0 +1,23 @@ > >> +* Dallas DS1341 I2C Serial Real-Time Clock > >> + > >> +Required properties: > >> + > >> +- compatible: Should contain "dallas,ds1341". > >> + > >> +- reg: I2C address for chip > >> + > >> +Optional properties: > >> + > >> +- disable-oscillator-stop-flag : Configure chip to disable oscillator > >> + fault detection circuitry > >> + > >> +- enable-glitch-filter : Configure chip to enable crystal oscillator > >> + output glitch filtering > > > > What determines setting these properties or not? > > Setting those properties allows drastically reduce RTC's power > consumption at the expense of reliability and quality of service. In > my use case, DS1341 is powered by a supercap and enabling those two > setting allows to increase holdup from less than a day do 2+ weeks. So wouldn't you want to set one mode while running and the lower power mode while suspended? I'm trying to understand the frequency of changing this. If it is always one setting for a board, then yes it belongs in DT. If it is a user decision, then it probably shouldn't be in DT. Seeing as these are reused, I've probably already had this discussion... > > They should have vendor prefix and be explicit that they are boolean. > > I was trying to be consistent with ds1339 and ds1390 bindings which do > not have vendor prefixes. Will fix in v2. Okay, then they are fine if you are using existing properties. Perhaps these should all be in a common binding doc though. Rob -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.