From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haozhong Zhang Subject: Re: [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg Date: Wed, 22 Jun 2016 18:18:33 +0800 Message-ID: <20160622101833.kb37aukooifeer32@hz-desktop> References: <20160616060621.30422-1-haozhong.zhang@intel.com> <20160616060621.30422-4-haozhong.zhang@intel.com> <20160616111951.yvmr6tznzw6tyxlx@hz-desktop> <603c703c-5142-4721-e5a3-2d147c32ccd1@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Paolo Bonzini , qemu-devel@nongnu.org, Richard Henderson , Eduardo Habkost , "Michael S . Tsirkin" , Marcelo Tosatti , kvm@vger.kernel.org, Boris Petkov , Tony Luck , Andi Kleen , rkrcmar@redhat.com, Ashok Raj To: Laszlo Ersek Return-path: Received: from mga14.intel.com ([192.55.52.115]:36827 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750834AbcFVKSh (ORCPT ); Wed, 22 Jun 2016 06:18:37 -0400 Content-Disposition: inline In-Reply-To: <603c703c-5142-4721-e5a3-2d147c32ccd1@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/17/16 19:31, Laszlo Ersek wrote: > Hi Haozhong, > > On 06/16/16 13:19, Haozhong Zhang wrote: > > On 06/16/16 11:52, Paolo Bonzini wrote: [..] > >> Have you prepared a patch for SeaBIOS already? > > > > Yes, I'll send it after I fix the type error (uint32_t => uint64_t) in > > next version. > > This should be supported by OVMF as well (thanks Paolo for the heads-up). > > I'm glad to code that up, but I'd like to ask you to file an RFE > (Request For Enhancement) in the upstream edk2 tracker for OVMF: > > https://github.com/tianocore/edk2/issues/new > > In the RFE, > - the subject line should include "OvmfPkg", > - please describe what the feature is good for (going into the details > of a specific use case is welcome), > - please specify the pathname and the internal format of the fw_cfg > file, > - please clarify if this MSR is considered part of the "chipset state" > that the firmware is responsible for at *every* boot. In particular > whether you expect that the firmware program this MSR at S3 resume as > well. > Done. Pls check https://github.com/tianocore/edk2/issues/97. Thanks, Haozhong From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFfF4-0002Xg-Q3 for qemu-devel@nongnu.org; Wed, 22 Jun 2016 06:18:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFfEz-0004mc-L4 for qemu-devel@nongnu.org; Wed, 22 Jun 2016 06:18:41 -0400 Received: from mga11.intel.com ([192.55.52.93]:30539) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFfEz-0004mE-F9 for qemu-devel@nongnu.org; Wed, 22 Jun 2016 06:18:37 -0400 Date: Wed, 22 Jun 2016 18:18:33 +0800 From: Haozhong Zhang Message-ID: <20160622101833.kb37aukooifeer32@hz-desktop> References: <20160616060621.30422-1-haozhong.zhang@intel.com> <20160616060621.30422-4-haozhong.zhang@intel.com> <20160616111951.yvmr6tznzw6tyxlx@hz-desktop> <603c703c-5142-4721-e5a3-2d147c32ccd1@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <603c703c-5142-4721-e5a3-2d147c32ccd1@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Paolo Bonzini , qemu-devel@nongnu.org, Richard Henderson , Eduardo Habkost , "Michael S . Tsirkin" , Marcelo Tosatti , kvm@vger.kernel.org, Boris Petkov , Tony Luck , Andi Kleen , rkrcmar@redhat.com, Ashok Raj On 06/17/16 19:31, Laszlo Ersek wrote: > Hi Haozhong, > > On 06/16/16 13:19, Haozhong Zhang wrote: > > On 06/16/16 11:52, Paolo Bonzini wrote: [..] > >> Have you prepared a patch for SeaBIOS already? > > > > Yes, I'll send it after I fix the type error (uint32_t => uint64_t) in > > next version. > > This should be supported by OVMF as well (thanks Paolo for the heads-up). > > I'm glad to code that up, but I'd like to ask you to file an RFE > (Request For Enhancement) in the upstream edk2 tracker for OVMF: > > https://github.com/tianocore/edk2/issues/new > > In the RFE, > - the subject line should include "OvmfPkg", > - please describe what the feature is good for (going into the details > of a specific use case is welcome), > - please specify the pathname and the internal format of the fw_cfg > file, > - please clarify if this MSR is considered part of the "chipset state" > that the firmware is responsible for at *every* boot. In particular > whether you expect that the firmware program this MSR at S3 resume as > well. > Done. Pls check https://github.com/tianocore/edk2/issues/97. Thanks, Haozhong