From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59399)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1bFhvD-0003Nr-Iq
	for qemu-devel@nongnu.org; Wed, 22 Jun 2016 09:10:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1bFhv9-0003xc-TH
	for qemu-devel@nongnu.org; Wed, 22 Jun 2016 09:10:22 -0400
Date: Wed, 22 Jun 2016 15:10:10 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20160622131010.GK6134@noname.redhat.com>
References: <cover.1466598035.git.berto@igalia.com>
	<939edcdfa8a02e08f4bd0f6444fee6e41d7150b4.1466598035.git.berto@igalia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <939edcdfa8a02e08f4bd0f6444fee6e41d7150b4.1466598035.git.berto@igalia.com>
Subject: Re: [Qemu-devel] [PATCH v2 05/15] blockjob: Add 'job_id' parameter
 to block_job_create()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>, Eric Blake <eblake@redhat.com>, Jeff Cody <jcody@redhat.com>

Am 22.06.2016 um 14:25 hat Alberto Garcia geschrieben:
> Job IDs are generated automatically when a new job is created. This
> patch adds a new 'job_id' parameter to let the caller provide one
> instead. In this case the ID is verified to be unique and well-formed.
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> Reviewed-by: Max Reitz <mreitz@redhat.com>

> @@ -140,7 +151,7 @@ void *block_job_create(const BlockJobDriver *driver, BlockDriverState *bs,
>  
>      job->driver        = driver;
>      job->device        = g_strdup(bdrv_get_device_name(bs));
> -    job->id            = id_generate(ID_JOB);
> +    job->id            = job_id ? g_strdup(job_id) : id_generate(ID_JOB);
>      job->blk           = blk;
>      job->cb            = cb;
>      job->opaque        = opaque;

This hunk will trivially conflict with removing device names. You can
keep my R-b while resolving that.

Reviewed-by: Kevin Wolf <kwolf@redhat.com>