From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44326)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1bFkEQ-0000DC-N1
	for qemu-devel@nongnu.org; Wed, 22 Jun 2016 11:38:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1bFkEM-0007kp-AY
	for qemu-devel@nongnu.org; Wed, 22 Jun 2016 11:38:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50114)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1bFkEM-0007kl-52
	for qemu-devel@nongnu.org; Wed, 22 Jun 2016 11:38:18 -0400
Date: Wed, 22 Jun 2016 16:38:14 +0100
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20160622153813.GG6604@work-vm>
References: <1466432945-28682-1-git-send-email-pbonzini@redhat.com>
	<1466432945-28682-7-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1466432945-28682-7-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 6/6] serial: remove watch on reset
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, bcketchum@gmail.com

* Paolo Bonzini (pbonzini@redhat.com) wrote:
> Otherwise, this can cause serial_xmit to be entered with LSR.TEMT=0,
> which is invalid and causes an assertion failure.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> Reported-by: Bret Ketchum <bcketchum@gmail.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/char/serial.c | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/char/serial.c b/hw/char/serial.c
> index d232473..7c196e2 100644
> --- a/hw/char/serial.c
> +++ b/hw/char/serial.c
> @@ -228,6 +228,7 @@ static gboolean serial_watch_cb(GIOChannel *chan, GIOCondition cond,
>                                  void *opaque)
>  {
>      SerialState *s = opaque;
> +    s->watch_tag = 0;
>      serial_xmit(s);
>      return FALSE;
>  }
> @@ -258,10 +259,12 @@ static void serial_xmit(SerialState *s)
>          if (s->mcr & UART_MCR_LOOP) {
>              /* in loopback mode, say that we just received a char */
>              serial_receive1(s, &s->tsr, 1);
> -        } else if (qemu_chr_fe_write(s->chr, &s->tsr, 1) != 1) {
> -            if (s->tsr_retry < MAX_XMIT_RETRY &&
> -                qemu_chr_fe_add_watch(s->chr, G_IO_OUT|G_IO_HUP,
> -                                      serial_watch_cb, s) > 0) {
> +        } else if (qemu_chr_fe_write(s->chr, &s->tsr, 1) != 1 &&
> +                   s->tsr_retry < MAX_XMIT_RETRY) {
> +            assert(s->watch_tag == 0);
> +            s->watch_tag = qemu_chr_fe_add_watch(s->chr, G_IO_OUT|G_IO_HUP,
> +                                                 serial_watch_cb, s);
> +            if (s->watch_tag > 0) {
>                  s->tsr_retry++;
>                  return;
>              }
> @@ -834,6 +837,11 @@ static void serial_reset(void *opaque)
>  {
>      SerialState *s = opaque;
>  
> +    if (s->watch_tag > 0) {
> +        g_source_remove(s->watch_tag);
> +        s->watch_tag = 0;
> +    }
> +
>      s->rbr = 0;
>      s->ier = 0;
>      s->iir = UART_IIR_NO_INT;
> -- 
> 2.5.5
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK