From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752514AbcFVQqP (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Jun 2016 12:46:15 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:56570 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751925AbcFVQqO (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Jun 2016 12:46:14 -0400
Date: Wed, 22 Jun 2016 17:46:12 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 5/8] fuse: don't use ->d_time
Message-ID: <20160622164612.GP14480@ZenIV.linux.org.uk>
References: <1466606110-24297-1-git-send-email-mszeredi@redhat.com>
 <1466606110-24297-6-git-send-email-mszeredi@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1466606110-24297-6-git-send-email-mszeredi@redhat.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 22, 2016 at 04:35:07PM +0200, Miklos Szeredi wrote:
> Store in memory pointed to by ->d_fsdata.  Use ->d_allocate() to allocate
> the storage.
> 
> We could cast ->d_fsdata directly on 64bit archs, but I don't think this is
> worth the extra complexity.

Now, _that_ is interesting:

> +static void fuse_dentry_release(struct dentry *dentry)
> +{
> +	kfree(dentry->d_fsdata);
> +}

What happens to fuse_dentry_revalidate() called on dentry in process of
getting dropped?  Unlike freeing struct dentry itself, ->d_release() is
not RCU-delayed.  So you are risking dereference of ->d_fsdata after
kfree(); at the very least, it needs RCU-delayed freeing...