From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752698AbcFVQsK (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Jun 2016 12:48:10 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:56592 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750970AbcFVQsJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Jun 2016 12:48:09 -0400
Date: Wed, 22 Jun 2016 17:48:06 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        Trond Myklebust <trond.myklebust@primarydata.com>
Subject: Re: [PATCH 6/8] nfs: don't use ->d_time
Message-ID: <20160622164806.GQ14480@ZenIV.linux.org.uk>
References: <1466606110-24297-1-git-send-email-mszeredi@redhat.com>
 <1466606110-24297-7-git-send-email-mszeredi@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1466606110-24297-7-git-send-email-mszeredi@redhat.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 22, 2016 at 04:35:08PM +0200, Miklos Szeredi wrote:
>  static void nfs_d_release(struct dentry *dentry)
>  {
>  	/* free cached devname value, if it survived that far */
> -	if (unlikely(dentry->d_fsdata)) {
> +	if (unlikely(NFS_D(dentry)->devname)) {
>  		if (dentry->d_flags & DCACHE_NFSFS_RENAMED)
>  			WARN_ON(1);
>  		else
> -			kfree(dentry->d_fsdata);
> +			kfree(NFS_D(dentry)->devname);
>  	}
> +	kfree(dentry->d_fsdata);

Again, is that safe wrt RCU delays?