From mboxrd@z Thu Jan 1 00:00:00 1970 From: Seth Forshee Subject: Re: [PATCH review 07/13] mnt: Move the FS_USERNS_MOUNT check into sget_userns Date: Wed, 22 Jun 2016 14:43:52 -0500 Message-ID: <20160622194352.GE125285@ubuntu-hedt> References: <87fus77pns.fsf@x220.int.ebiederm.org> <20160620172130.15712-1-ebiederm@xmission.com> <20160620172130.15712-7-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160620172130.15712-7-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Eric W. Biederman" Cc: Miklos Szeredi , Linux Containers , Andy Lutomirski , James Bottomley , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Djalal Harouni List-Id: containers.vger.kernel.org On Mon, Jun 20, 2016 at 12:21:24PM -0500, Eric W. Biederman wrote: > Allowing a filesystem to be mounted by other than root in the initial > user namespace is a filesystem property not a mount namespace property > and as such should be checked in filesystem specific code. Move the > FS_USERNS_MOUNT test into super.c:sget_userns(). > > Signed-off-by: "Eric W. Biederman" Acked-by: Seth Forshee From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f47.google.com ([209.85.218.47]:34079 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752429AbcFVTny (ORCPT ); Wed, 22 Jun 2016 15:43:54 -0400 Received: by mail-oi0-f47.google.com with SMTP id s66so38082383oif.1 for ; Wed, 22 Jun 2016 12:43:54 -0700 (PDT) Date: Wed, 22 Jun 2016 14:43:52 -0500 From: Seth Forshee To: "Eric W. Biederman" Cc: Linux Containers , linux-fsdevel@vger.kernel.org, Miklos Szeredi , James Bottomley , Djalal Harouni , "Serge E. Hallyn" , Andy Lutomirski Subject: Re: [PATCH review 07/13] mnt: Move the FS_USERNS_MOUNT check into sget_userns Message-ID: <20160622194352.GE125285@ubuntu-hedt> References: <87fus77pns.fsf@x220.int.ebiederm.org> <20160620172130.15712-1-ebiederm@xmission.com> <20160620172130.15712-7-ebiederm@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160620172130.15712-7-ebiederm@xmission.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jun 20, 2016 at 12:21:24PM -0500, Eric W. Biederman wrote: > Allowing a filesystem to be mounted by other than root in the initial > user namespace is a filesystem property not a mount namespace property > and as such should be checked in filesystem specific code. Move the > FS_USERNS_MOUNT test into super.c:sget_userns(). > > Signed-off-by: "Eric W. Biederman" Acked-by: Seth Forshee