From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751330AbcFWE66 (ORCPT ); Thu, 23 Jun 2016 00:58:58 -0400 Received: from mail-bn1bon0099.outbound.protection.outlook.com ([157.56.111.99]:59104 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750826AbcFWE65 (ORCPT ); Thu, 23 Jun 2016 00:58:57 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Thu, 23 Jun 2016 07:54:27 +0300 From: Yury Norov To: "Zhangjian (Bamvor)" CC: Andreas Schwab , , , , , , , , , , , , Andrew Pinski , Subject: Re: [PATCH 19/27] [AARCH64] Add typesizes.h for ILP32 Message-ID: <20160623045427.GB13449@yury-N73SV> References: <1466485631-3532-1-git-send-email-ynorov@caviumnetworks.com> <1466485631-3532-21-git-send-email-ynorov@caviumnetworks.com> <57692C1F.8050309@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <57692C1F.8050309@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: AM5PR0901CA0033.eurprd09.prod.outlook.com (10.164.186.171) To CY1PR07MB2247.namprd07.prod.outlook.com (10.164.112.149) X-MS-Office365-Filtering-Correlation-Id: 18e39217-f1ad-4b8e-d085-08d39b231365 X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2247;2:HyAtxWpk1hVjcq66nsGvmmR53R5cycD10lry84p1xA8dfWIOqar5hxiQkNrx5GGfeiLKWcd0f4izGRETg9q0MtIGm5idzZvP1BTeBqakzk0JFLhfDNqSp8u1LUB5QyhwK9iQMoG5JR/qgWClRQ09SBk+Mb0He7j+wkxSzsZqitjlbK9O09qdGJAuo+pu78S6;3:0nhhU8s4PsKXOwdfjgkqOwVIPEp4s/7X0jDUBuxM/xghXSp3w+oiI2jL7TbrNxbTXfkFQoiyCgHYO9Zr0nIXo2sgM8wPu7ypFTKToZ4g+TPKklVr2/JfNkRidRM4dAoQ X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2247; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2247;25:tddjYG2rK8+aGhlWdp38ZBOgcOD82T+vVgQEEH5HjFv49N5dRNd8mrjI8ThAospOrpe17AE5QBW9nV9de9zGw0GgLPdjCLoP2OGp1MAM7WVFqUnPBwZl+oCgYSVzQjD4wJn4lv77umym8BsyzCQ9RzXZ6jlzd2InT1DUIrUD2Kz90JsCLdxOjMTp/aH0KDztta/Pkp61miWewkwA0vzTzyQawA+lKIexsfd/cctMqE4/ZQcWzp2wWJNBBecPe/LgS7KiXDR1gJDg8XOj7y76NWRg4StIx4wyTYPdwFKL/b7b7ejVF4Zvsv84ss6zz8gQCK65KEs7ibSseKeV6FxlYj64tg9x/KrWn9HDtq0btOxlqlVkromBPLViKoT2l6woTn4D3MhzLaTKqeDbzpdIleeH5jAGCaaRQmBfwVRP6YcZ35SQLybKaQCmR8oDJ6tr3ezwtOEPmvex9wk/rQZCrvy8BvZRP5TiNvIz3yHawkEoo37AvX6faT9UMlVYMF4GLgr6Hrt46d6TL6Rx/8hJuHqhOATfbkAF8R9Q9c4sNkEHafxVnTyAMgf9tza+4YbaX1mbFQxDZUCYuydo25Q7Ub0pvTxUZ1sar+ar9Zq19EIcDzIPBT2btjygCcZ1ytL+Re1xc0iPKQlF7aidSs5J9LwYowC5wYW7d4nU0EIwWrPXYjy8uTeL6h5JhzFWkytGu4P7wW6+02wrSHuUpr34bg3pDAYXuKTYhfFSLdmksGcjUCmWjui4IWSqijx1iotR X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2247;20:ttf/al+y9ogWJGw4LdqmfAOQw67JUhFY+XBAShOEN37D2NzPUgRwIiHZ8mYgWoolSB7P4nNqRvXda9zkx6jtddozerJf75qs4xMfcVsfBRobUF5WSZ9e8nHkzNXnZ8prvOyQTTnJnboBs7Tnieq1VsC3GBCprbsTrHc8Sw6C1GUMWOoOyQlM+0qkDYtIbs/2h64BomhjvTcx9tvW1Glk6cbs1+U7KJlla4jgI2fv0PgtcrNEGN1r/DCAS1CrDbTK9RXaoKEZbmgG1Sjm/hWctb8AOPHTg4pJcFqMZ5gSDHHW8JjRHB+4Td4mfZyKHpHUo/0eBjfbZCo+1WdbUaZ8ihNEKBE8rVcaSP8ty0ez8LI1m//C8BqUbeeJn1ZMNd7xs6z9QNylmq6k1ojDQcQDz6+txeju96PiqvVTS8Ru/69UFEaHZ+gjTrAFZ0pEpID0bv7zVIDpZ5+JdcWv2Ojj8ByK8Oul5vazm/K1CKNbkOppSbjxP2fwUErDzwHLJo33sJLl/ZwjAJ3XePMAKQEmKNLiqR0S8qgjM9zeXwwa7uxhUK9eRVDvhmbJt9hmF+e5k4ygVzBY/SYny11RxbSChG2bqDNNGzh3G7o5/RuXWfU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:CY1PR07MB2247;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2247; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2247;4:tDEnOpibqXGITGmPp8QZ29szQ1jJM9a6msGh7jDUzxusKKayYDVMUHLTGKs0joHjQtJyGxP0opFWySFhKRLluR0+n6X2iWFIwCrLlT8Hpe/7B7FcdChE7Bo0XaLBQfFh7vwUhospxBpHC1NXehwQeZdSN1fmABSbijKr3jStopNXJRsHykTx//6cOF+zssjnBAbn9znujRA1/Und+G5N4OzgrQjoyWHb/w2qVoke7GZ+BB6QssE/gePUSm3U4dN7Eu0vuye9M+INzn+4VSElz8xxc/OG2aJrECDsLjlgeTfk7zKFLfucJii1mp2AidNfvq2tb2hxanJ+w7Ys++hFvBQbSdXi2jRtMdpsS8BtKUX23izI2JMEotYkOp0s93qy X-Forefront-PRVS: 098291215C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(189002)(199003)(24454002)(93886004)(97756001)(1076002)(9686002)(77096005)(6116002)(586003)(23726003)(3846002)(50466002)(68736007)(46406003)(42186005)(7736002)(7846002)(92566002)(4326007)(2906002)(189998001)(2950100001)(106356001)(33716001)(66066001)(47776003)(19580405001)(81166006)(83506001)(81156014)(8676002)(19580395003)(4001350100001)(97736004)(50986999)(76176999)(33656002)(54356999)(110136002)(101416001)(105586002)(76506005)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2247;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR07MB2247;23:DgeIbRCr9sxygQcI6OtgJpHS+OuO/1//979PEkjJQ?= =?us-ascii?Q?PXqSd5XI06rDY3ikCKr14iGqcrme9ocaH3WoOAdw8xuBzJRlZ1AhXoRRBQX0?= =?us-ascii?Q?C68u9gzWAMQ7L8FU+e9tJ5eyTsne9NMQOgv+G4GB/1Jp2fyXZmxndNlbSQ/6?= =?us-ascii?Q?f5BeN7Uj3xHsjyVuKDkyGfbeGnWmIPSJy0wbAs+3f6yjGSCRamzbWW+LCL8L?= =?us-ascii?Q?ewwyS4o8+e2IWWkELubMuJxOiWaff4AEog0NZgyoKivIaBDMHPPMLiHNlFyJ?= =?us-ascii?Q?TPesxh9MChoDUkYNcKBme+hn9LJ6oxLdrzoEbtY0LMpDgxcBFgYSIMDFX/f8?= =?us-ascii?Q?aAC/jNJuWkLi5O+hABcwjwuZ2+AjZivLf0xvJ0QN0PmOYlgQOQ+k6dExbUHG?= =?us-ascii?Q?cagknBc2/rspbs8x11l5iUzFs1cl9e9tqTJAk3UNZqy0R5lNtzhaxaV/XLCB?= =?us-ascii?Q?8P4YFTrcjBSWZqe2IgGE3k3dRH/zTu6uFlVeDrACi4WcwlRv3dWPe+UpKM07?= =?us-ascii?Q?RYZxEn2PVVpy6ZtG860UkVE9qpCvXinUQW80z8DvSPoNEF5suh2OGPmYr+bt?= =?us-ascii?Q?qieCXFxmYp9ySgn2uF+haCHgTfSfkHmPybxJzfAxcqn+BHu3PEkUwZoMsF9t?= =?us-ascii?Q?Plid20xzPvsyvzSG8ferBVSNmSq0bWB5DT3bkbV8K6DZnx3NzmkUYR9aIpMx?= =?us-ascii?Q?mULeLvsPZZXFotorsjwJGEUd6AGZg+1+vsaIG7oF8rNxcKL0CDe5wVnEoYLd?= =?us-ascii?Q?cbBU3mrEhQtdgstKfJR0duVzy/hltH6+ibQDzUEu7nRC8wR1EzjH7nHr8T9E?= =?us-ascii?Q?FQuwn/tqjESsZadZYsi0nQ3RDB3L9ii5xYH0JTZ0hfPRvFcTyqQvH4/o0nAO?= =?us-ascii?Q?f99QPHxi53qbYAJEkuJq/mH3rnlPXuRBqddCbUqIe930Sgcn0HdfDSwKT+Yt?= =?us-ascii?Q?R54CIxQ2PcGLshkf+Bu2Vxbjq4FtgE3t9F0+3j9P4XZOflk9sMCImAL7Mn5a?= =?us-ascii?Q?OPr/bvG1ZhT2qFGZZVJzteqQgUZ4yJxVffEPRas1f3+mS0wLvcxgNVIffVAp?= =?us-ascii?Q?Z/pB+Y+QPND5vfKR5RtT9kyL2gxcctlMvQl8vQFjgR5Zj2le4HXPZH8d1Bao?= =?us-ascii?Q?EZKwjGSwRfv2jrYFBeU77ITMmdWiWwpNEU/1Zp1Hi+nBJ+ydt4gdnPZ6nOTN?= =?us-ascii?Q?dXSETWn2LqYfg0=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2247;6:fzWrd2kNFStmCXH3QRnVvTQVHvPvuECi2Uywh5nHzbwGx2dvPKTiybu6uW6QzRHTJ5DYszgfDm3wXMG/61rnNqM2l/6kVxlgTYoItybD2ahckKlvZwSX9yNmXhQiCAKeoFc2t+pXFwbHLWchP4hhIW2f6DaXNW3BNnDQqOmr7XqQBqbsWXB+/x0dMVOsAvdjLNZaRBCATpTAUN4MkbYD8KatTd8Aye6czcT/BGOZN0FqiDvJKD0TbKyZKvi/75s24rKcxWngQlcj2CF/C4xb5EESjzXrZ9ySQKQ1P2e8T2K7+9UF3gsCIgIdkKsZGwTJ;5:DYS+gGSzBa1zRcMD5o1o7JIpM/ZT74ss+duyRa20Xktlg1VHugEBDosLKE+etFWHAaj+ZJF4BRkIWKn36fbVpPK7gM1WM+eBib1tDtbMS1M5iSvtEZlFxbpKhGfPWNK1fEkqBlvxmjcvPEqihx3uJw==;24:Nf7rPFEZJO5Xi5p+7VP2N1PeVRFlG+pD+DvxsgWj5cE+N+OTgu6L/4LAOH4EoIJ5AAUUPxOahG04gTy7pk4Ik6JJud7UcyE9723eTnxpRD4=;7:2ZP74PK+kCrwGFR08LbnsS1VFf3TYHJPnS/ennbD2wuiORuM4qwpJT33FxJWHGn1gwF+SBTgZGNC1dLkfsh+sog4W//GZMXs338RTRbwCxLrivD1NQpVnfAPQzHWS3yo83mnYjoRpIOMjAc9mXCVJUdlOcis6jNhOU0rJAEXl/CBzGkynZBxKTiALAOX8IdjKQW1/LFN1TAeJydseIgpmEhnGRChsqqpjCEMSnsLpRfnIX/r8J6cltdka/rVf1LBzhbJCeTC25Pk8GS+VTWk+A== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2016 04:58:53.7379 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2247 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2016 at 07:59:27PM +0800, Zhangjian (Bamvor) wrote: > Hi, > > On 2016/6/21 15:58, Andreas Schwab wrote: > >Yury Norov writes: > > > >>diff --git a/sysdeps/unix/sysv/linux/sysdep-vdso.h b/sysdeps/unix/sysv/linux/sysdep-vdso.h > >>index e8c4a7b..351d6bb 100644 > >>--- a/sysdeps/unix/sysv/linux/sysdep-vdso.h > >>+++ b/sysdeps/unix/sysv/linux/sysdep-vdso.h > >>@@ -37,7 +37,7 @@ > >> __label__ out; \ > >> __label__ iserr; \ > >> INTERNAL_SYSCALL_DECL (sc_err); \ > >>- long int sc_ret; \ > >>+ __syscall_slong_t sc_ret; \ > >> \ > >> __typeof (__vdso_##name) vdsop = __vdso_##name; \ > >> PTR_DEMANGLE (vdsop); \ > >>@@ -64,7 +64,7 @@ > >> # define INTERNAL_VSYSCALL(name, err, nr, args...) \ > >> ({ \ > >> __label__ out; \ > >>- long v_ret; \ > >>+ __syscall_slong_t v_ret; \ > >> \ > >> __typeof (__vdso_##name) vdsop = __vdso_##name; \ > >> PTR_DEMANGLE (vdsop); \ > > > >That part should have no effect now that __SYSCALL_SLONG_TYPE remains to > >be long. > Agree. According to the discussion in "[PATCH 11/27] [AARCH64] Syscalls for ILP32 are passed > always via 64bit values.". We should update this to long long too. > I think comment to patch 11 is outdated. Andreas right, this chunk is useless. I'll remove it in next submission.