From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752383AbcFWMoj (ORCPT ); Thu, 23 Jun 2016 08:44:39 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:37440 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752332AbcFWMoh (ORCPT ); Thu, 23 Jun 2016 08:44:37 -0400 Date: Thu, 23 Jun 2016 13:44:33 +0100 From: Matt Fleming To: Alex Thorlton Cc: linux-kernel@vger.kernel.org, Russ Anderson , Dimitri Sivanich , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Ard Biesheuvel , Mark Rutland , Roy Franz , linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, x86@kernel.org Subject: Re: [PATCHv2 0/3] x86/UV, x86/efi: Re-factor efi_call_virt for general use Message-ID: <20160623124433.GE8415@codeblueprint.co.uk> References: <1466017455-236934-1-git-send-email-athorlton@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466017455-236934-1-git-send-email-athorlton@sgi.com> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Jun, at 02:04:12PM, Alex Thorlton wrote: > Hey guys, > > This patchset creates a general purpose version of the efi_call_virt > macro that does not assume that the function pointer being passed in is > inside of efi.systab->runtime. It also fixes up uv_bios_call to use the > new functionality, and does a bit of cleanup in the efi_thunk macro. > > Quick breakdown of the patches: > > Patch 1) Move necessary macros to locations where we can access them. > Remove hard-coded efi.systab reference from efi_call_virt. > Rename/create new macros as needed. > Patch 2) Simple change to allow UV code to utilize the new > functionality. Included a detailed explanation of how we got > here. > Patch 3) Replace a few bits of the efi_thunk macro with the > arch_efi_call_setup/teardown macros. > > The first two have been tested on simulators and hardware, but the third > has only been compile-tested. I don't have any hardware to test that > on. > > Updates for v2: > > - Fix up arm and arm64 versions of arch_efi_call_virt. I missed these > on my first pass > - Add some more detail to the commit message for the uv_bios_call fix. > - Change the third patch to use the arch_efi_call_setup/teardown macros > inside of the efi_thunk macro, instead of replacing efi_thunk entirely > for the CONFIG_EFI_MIXED case. Whole series looks good to me Alex, and everything works fine on my mixed-mode config. Applied for v4.8, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCHv2 0/3] x86/UV, x86/efi: Re-factor efi_call_virt for general use Date: Thu, 23 Jun 2016 13:44:33 +0100 Message-ID: <20160623124433.GE8415@codeblueprint.co.uk> References: <1466017455-236934-1-git-send-email-athorlton@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1466017455-236934-1-git-send-email-athorlton-sJ/iWh9BUns@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alex Thorlton Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russ Anderson , Dimitri Sivanich , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Ard Biesheuvel , Mark Rutland , Roy Franz , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: linux-efi@vger.kernel.org On Wed, 15 Jun, at 02:04:12PM, Alex Thorlton wrote: > Hey guys, > > This patchset creates a general purpose version of the efi_call_virt > macro that does not assume that the function pointer being passed in is > inside of efi.systab->runtime. It also fixes up uv_bios_call to use the > new functionality, and does a bit of cleanup in the efi_thunk macro. > > Quick breakdown of the patches: > > Patch 1) Move necessary macros to locations where we can access them. > Remove hard-coded efi.systab reference from efi_call_virt. > Rename/create new macros as needed. > Patch 2) Simple change to allow UV code to utilize the new > functionality. Included a detailed explanation of how we got > here. > Patch 3) Replace a few bits of the efi_thunk macro with the > arch_efi_call_setup/teardown macros. > > The first two have been tested on simulators and hardware, but the third > has only been compile-tested. I don't have any hardware to test that > on. > > Updates for v2: > > - Fix up arm and arm64 versions of arch_efi_call_virt. I missed these > on my first pass > - Add some more detail to the commit message for the uv_bios_call fix. > - Change the third patch to use the arch_efi_call_setup/teardown macros > inside of the efi_thunk macro, instead of replacing efi_thunk entirely > for the CONFIG_EFI_MIXED case. Whole series looks good to me Alex, and everything works fine on my mixed-mode config. Applied for v4.8, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 From: matt@codeblueprint.co.uk (Matt Fleming) Date: Thu, 23 Jun 2016 13:44:33 +0100 Subject: [PATCHv2 0/3] x86/UV, x86/efi: Re-factor efi_call_virt for general use In-Reply-To: <1466017455-236934-1-git-send-email-athorlton@sgi.com> References: <1466017455-236934-1-git-send-email-athorlton@sgi.com> Message-ID: <20160623124433.GE8415@codeblueprint.co.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 15 Jun, at 02:04:12PM, Alex Thorlton wrote: > Hey guys, > > This patchset creates a general purpose version of the efi_call_virt > macro that does not assume that the function pointer being passed in is > inside of efi.systab->runtime. It also fixes up uv_bios_call to use the > new functionality, and does a bit of cleanup in the efi_thunk macro. > > Quick breakdown of the patches: > > Patch 1) Move necessary macros to locations where we can access them. > Remove hard-coded efi.systab reference from efi_call_virt. > Rename/create new macros as needed. > Patch 2) Simple change to allow UV code to utilize the new > functionality. Included a detailed explanation of how we got > here. > Patch 3) Replace a few bits of the efi_thunk macro with the > arch_efi_call_setup/teardown macros. > > The first two have been tested on simulators and hardware, but the third > has only been compile-tested. I don't have any hardware to test that > on. > > Updates for v2: > > - Fix up arm and arm64 versions of arch_efi_call_virt. I missed these > on my first pass > - Add some more detail to the commit message for the uv_bios_call fix. > - Change the third patch to use the arch_efi_call_setup/teardown macros > inside of the efi_thunk macro, instead of replacing efi_thunk entirely > for the CONFIG_EFI_MIXED case. Whole series looks good to me Alex, and everything works fine on my mixed-mode config. Applied for v4.8, thanks!