From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 55/55] dm: Update the of-platdata README for the new features
Date: Thu, 23 Jun 2016 18:55:27 -0400 [thread overview]
Message-ID: <20160623225527.GA19080@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ1E_GKv+GuNeN+HnAe8X6J2iqTz2U6agzB8xOvZ9DLq=w@mail.gmail.com>
On Thu, Jun 23, 2016 at 02:36:55PM -0600, Simon Glass wrote:
> Hi Tom,
>
> On 23 June 2016 at 14:04, Tom Rini <trini@konsulko.com> wrote:
> > On Sun, Jun 12, 2016 at 11:33:36PM -0600, Simon Glass wrote:
> >
> >> Revise the content based on the v2 additions. This is kept as a separate
> >> patch to avoid confusing those who have already reviewed the v1 series.
> >>
> >> Signed-off-by: Simon Glass <sjg@chromium.org>
> >> Suggested-by: Tom Rini <trini@konsulko.com>
> > [snip]
> >> +Converting of-platdata to a useful form
> >> +---------------------------------------
> >> +
> >> +Of course it would be possible use the of-platdata directly in your driver
> >> +whenever configuration information is required. However this meands that the
> >
> > "means"
> >
> > [snip]
> >> +The of-platdata struct contents is copied from the C structure data to the
> >
> > "is copied" -> "are copied"
> >
> > And thanks again for doing all of this!
>
> Obviously I still have a test to write, but other than that, what do
> you think of this feature?
Well, I like it. But I'm also not great at spotting problems before we
run into them sometimes.
> I put quite a bit of info in the caveats. The benefit is clear but it
> is also a bit wonky - e.g. the structure / member naming. I'm really a
> little bit nervous about it all. Do you think we can make sure it is
> used sparingly?
Given the number of places (it feels like) that run in to, or nearly run
in to size limits today in SPL with tiny-printf enabled, no, I can't say
that I think this will be used sparingly. So is there anything we can
do about the structure / member naming to make it less wonky? Or just
wait and see how things work out in the end when people start using it
more?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160623/b3966e96/attachment.sig>
next prev parent reply other threads:[~2016-06-23 22:55 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 5:32 [U-Boot] [PATCH v2 00/55] RFC: dm: rockchip: Add support for compiled-in platform data Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 01/55] sandbox: Don't print a warning for CONFIG_I2C_COMPAT Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 02/55] README: Remove CONFIG_SYS_MALLOC_F_LEN comment Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 03/55] spl: Drop include of i2c.h Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 04/55] Makefile: Allow the SPL final link rule to be overridden Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 05/55] sandbox: Allow chaining from SPL to U-Boot proper Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 06/55] sandbox: Support building an SPL image Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 07/55] sandbox: Correct header file order in cpu.c Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 08/55] sandbox: Add some missing headers " Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 09/55] sandbox: Don't use PCI in SPL Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 10/55] sandbox: Don't include the main loop " Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 11/55] sandbox: Add basic SPL implementation Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 12/55] sandbox: Don't use IDE and iotrace in SPL Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 13/55] sandbox: serial: Don't sync video " Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 14/55] sandbox: Add a new sandbox_spl board Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 15/55] sandbox: Add a test device that uses of-platdata Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 16/55] dm: spl: Don't set up device tree with of-platdata Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 17/55] dm: Makefile: Build of-platdata before SPL Simon Glass
2016-06-13 5:32 ` [U-Boot] [PATCH v2 18/55] dm: core: Don't use device tree with of-platdata Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 19/55] dm: regmap: Add a dummy implementation for of-platdata Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 20/55] dm: syscon: Add support " Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 21/55] dm: sandbox: Add a simple driver to test of-platdata Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 22/55] dm: Add a header that provides access to the of-platdata structs Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 23/55] dm: clk: Add support for of-platdata Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 24/55] dm: serial: " Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 25/55] dm: Don't include fdtdec functions when of-platdata is enabled Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 26/55] dm: Add an option to enable the of-platdata feature Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 27/55] dm: Add a README for of-platdata Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 28/55] dm: Add a library to provide simple device-tree access Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 29/55] dm: Add a tool to generate C code from a device tree Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 30/55] dm: Makefile: Build of-platdata files when the feature is enabled Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 31/55] dm: Add a more efficient libfdt library Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 32/55] Only build the libfdt python module if 'swig' is available Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 33/55] tiny-printf: Support assert() Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 34/55] dm: spl: Bind in all devices in SPL with of-platdata Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 35/55] dm: core: Rename DM_NAME_ALLOCED to DM_FLAG_NAME_ALLOCED Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 36/55] dtoc: Ignore the u-boot, dm-pre-reloc property Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 37/55] dm: Don't attach the device tree to SPL with of-platdata Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 38/55] dm: core: Expand platdata for of-platdata devices Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 39/55] dm: core: Move regmap allocation into a separate function Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 40/55] dm: core: Add an implementation of regmap_init_mem_platdata() Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 41/55] dm: serial: ns16550: Update to support of-platdata Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 42/55] rockchip: serial: Add an of-platdata driver for rockchip Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 43/55] rockchip: Update the sdram-channel property to support of-platdata Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 44/55] rockchip: mmc: Move all DT decoding to ofdata_to_platdata() Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 45/55] rockchip: mmc: Update the driver to support of-platdata Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 46/55] rockchip: clk: Move all DT decoding to ofdata_to_platdata() Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 47/55] rockchip: clk: Update the rk3288 driver to support of-platdata Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 48/55] rockchip: pinctrl: " Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 49/55] rockchip: Move the MMC setup check earlier Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 50/55] rockchip: Don't use spl_boot_device() with of-platdata Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 51/55] rockchip: syscon: Update to work " Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 52/55] rockchip: sdram: Move all DT decoding to ofdata_to_platdata() Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 53/55] rockchip: sdram: Update the driver to support of-platdata Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 54/55] rockchip: Use of-platdata for firefly-rk3288 Simon Glass
2016-06-13 5:33 ` [U-Boot] [PATCH v2 55/55] dm: Update the of-platdata README for the new features Simon Glass
2016-06-23 20:04 ` Tom Rini
2016-06-23 20:36 ` Simon Glass
2016-06-23 22:55 ` Tom Rini [this message]
2016-06-26 3:00 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160623225527.GA19080@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.