All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	qemu-devel@nongnu.org, xen-devel@lists.xen.org
Subject: Re: Change of max-ram-below-4g initial value breaks Xen
Date: Fri, 24 Jun 2016 12:19:04 +0100	[thread overview]
Message-ID: <20160624111904.GV5666__46261.3514544957$1466767223$gmane$org@perard.uk.xensource.com> (raw)
In-Reply-To: <1466747183.16435.1.camel@redhat.com>

On Fri, Jun 24, 2016 at 07:46:23AM +0200, Gerd Hoffmann wrote:
> On Do, 2016-06-23 at 17:18 +0100, Anthony PERARD wrote:
> > On Thu, Jun 23, 2016 at 04:57:54PM +0200, Gerd Hoffmann wrote:
> > >   Hi,
> > > 
> > > > How could xen_ram_init() find out if the value of max-ram-below-4g is
> > > > the default or if a user have set it? Is there another way we could fix
> > > > this?
> > > 
> > > Attached patch should fix it.  Patch survived a quick smoke test on kvm
> > > so far, need to do some more testing tomorrow.  Can you give it a spin
> > > on xen?
> > 
> > Thanks. Unfortunately, it does not work :(.
> > 
> > In this patch, max_ram_below_4g is set before the call to xen_ram_init()
> > and xen_ram_init read it back (via object_property_get_int()).  So, in
> > xen_ram_init, user_lowmem is not 0.
> 
> Ah, I see.  We do the split calculation twice on xen.  That is pretty
> pointless.  New patch attached.

I've tested on Xen, it works fine. Thanks. Also, the patch look good.

Cheers,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-24 11:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-22 15:09 [Qemu-devel] Change of max-ram-below-4g initial value breaks Xen Anthony PERARD
2016-06-22 15:09 ` Anthony PERARD
2016-06-22 15:27 ` Gerd Hoffmann
2016-06-22 15:27 ` [Qemu-devel] " Gerd Hoffmann
2016-06-23 14:57 ` Gerd Hoffmann
2016-06-23 14:57   ` Gerd Hoffmann
2016-06-23 16:18   ` [Qemu-devel] " Anthony PERARD
2016-06-23 16:18     ` Anthony PERARD
2016-06-24  5:46     ` Gerd Hoffmann
2016-06-24  5:46     ` [Qemu-devel] " Gerd Hoffmann
2016-06-24 11:19       ` Anthony PERARD [this message]
2016-06-24 11:19       ` Anthony PERARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20160624111904.GV5666__46261.3514544957$1466767223$gmane$org@perard.uk.xensource.com' \
    --to=anthony.perard@citrix.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.