All of lore.kernel.org
 help / color / mirror / Atom feed
From: Afzal Mohammed <afzal.mohd.ma@gmail.com>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, Sekhar Nori <nsekhar@ti.com>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: cpdma: switch to use genalloc
Date: Fri, 24 Jun 2016 17:27:50 +0530	[thread overview]
Message-ID: <20160624115750.GA5749@afzalpc> (raw)
In-Reply-To: <576CCD9B.2050700@ti.com>

Hi,

On Fri, Jun 24, 2016 at 11:35:15AM +0530, Mugunthan V N wrote:
> On Thursday 23 June 2016 06:26 PM, Ivan Khoronzhuk wrote:

> >> +    if (pool->cpumap) {
> >> +        dma_free_coherent(pool->dev, pool->mem_size, pool->cpumap,
> >> +                  pool->phys);
> >> +    } else {
> >> +        iounmap(pool->iomap);
> >> +    }

> > single if, brackets?
> 
> if() has multiple line statement, so brackets are must.

Another paint to the bikeshed,

seems documented coding style mentions otherwise.

Regards
afzal

  reply	other threads:[~2016-06-24 11:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-23 12:36 [PATCH] net: ethernet: ti: cpdma: switch to use genalloc Grygorii Strashko
2016-06-23 12:36 ` Grygorii Strashko
2016-06-23 12:56 ` Ivan Khoronzhuk
2016-06-24  6:05   ` Mugunthan V N
2016-06-24  6:05     ` Mugunthan V N
2016-06-24 11:57     ` Afzal Mohammed [this message]
2016-06-24 16:15     ` Lennart Sorensen
2016-06-24 16:58       ` Grygorii Strashko
2016-06-24 16:58         ` Grygorii Strashko
2016-06-24 18:39         ` Lennart Sorensen
2016-06-25  8:33       ` Afzal Mohammed
2016-06-23 13:17 ` ivan.khoronzhuk
2016-06-24  6:03 ` Mugunthan V N
2016-06-24  6:03   ` Mugunthan V N

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160624115750.GA5749@afzalpc \
    --to=afzal.mohd.ma@gmail.com \
    --cc=davem@davemloft.net \
    --cc=grygorii.strashko@ti.com \
    --cc=ivan.khoronzhuk@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mugunthanvnm@ti.com \
    --cc=netdev@vger.kernel.org \
    --cc=nsekhar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.