From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751556AbcFXUVl (ORCPT ); Fri, 24 Jun 2016 16:21:41 -0400 Received: from mga14.intel.com ([192.55.52.115]:23653 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbcFXUVj (ORCPT ); Fri, 24 Jun 2016 16:21:39 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,522,1459839600"; d="scan'208";a="1004711058" Date: Fri, 24 Jun 2016 23:21:31 +0300 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: Ed Swierk , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, stefanb@us.ibm.com Subject: Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors Message-ID: <20160624202131.GB8399@intel.com> References: <1466474042-110773-1-git-send-email-eswierk@skyportsystems.com> <1466557831-113440-1-git-send-email-eswierk@skyportsystems.com> <1466557831-113440-2-git-send-email-eswierk@skyportsystems.com> <20160624182515.GC14506@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160624182515.GC14506@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jason, On Fri, Jun 24, 2016 at 12:25:15PM -0600, Jason Gunthorpe wrote: > > expected = be32_to_cpu(*(__be32 *) (buf + 2)); > > if (expected > count) { > > + dev_err(chip->pdev, "Response too long (wanted %zd, got %d)\n", > > + count, expected); > > This all needs to be rebased on Jarkko's tree I guess, chip->pdev is > gone now. > > http://git.infradead.org/users/jjs/linux-tpmdd.git/shortlog/refs/heads/master > > Jarkko, did you miss a pull request for 4.7 or something? This is > 4 month old stuff??? Hmm... Do you mean by 4 month old stuff the stuff that is in mainline and not in my master branch? I'm not sure what happened with 4.7. I merged the changes for in about 4.6-rc5. There was one issue that I fixed that Stephen reported. At the moment linux-next seems contain the stuff that I have in my next. > Jason /Jarkko